From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ifv2BLXIjmDYJQAAWB0awg (envelope-from ) for ; Sun, 02 May 2021 11:43:49 -0400 Received: by simark.ca (Postfix, from userid 112) id 0650F1F11C; Sun, 2 May 2021 11:43:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5DBDB1E54D for ; Sun, 2 May 2021 11:43:48 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C9B673833036; Sun, 2 May 2021 15:43:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C9B673833036 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619970227; bh=LsJYXBpdmY0mMkkt2OOsXyhQslU5QuUMUH0+Vf9j0dY=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=dH6JtOWdHm24e7x8fCb7hr2si5CXCNnPkgo5LG70rBih5QosNKmIr8+NAzN25cIHd dyPcMZCRCvyxrEsQ8wiT3lIKyF6steHgY97nBc+XmaSHMWHDx6sUpyBv3Vcl9N0eEh dot3RlxDeIN0z/VohdmkxSLbbXiSF+HIkFAscCyc= Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id CAE7D3833036 for ; Sun, 2 May 2021 15:43:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CAE7D3833036 Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id F36F133BEBC; Sun, 2 May 2021 15:43:43 +0000 (UTC) Date: Sun, 2 May 2021 11:43:42 -0400 To: Simon Marchi Subject: Re: [PATCH] sim: add ATTRIBUTE_PRINTF / ATTRIBUTE_NULL_PRINTF where necessary Message-ID: Mail-Followup-To: Simon Marchi , gdb-patches@sourceware.org References: <20210502152454.506379-1-simon.marchi@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210502152454.506379-1-simon.marchi@polymtl.ca> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 02 May 2021 11:24, Simon Marchi via Gdb-patches wrote: > I finally got the all-targets sim building with Clang, these are all the > instances where an ATTRIBUTE_PRINTF or ATTRIBUTE_NULL_PRINTF attribute > needed to be added to avoid errors like: > > /home/simark/src/binutils-gdb/sim/aarch64/../common/sim-profile.c:464:19: error: format string is not a string literal [-Werror,-Wformat-nonliteral] > vfprintf (fp, fmt, ap); > ^~~ > There are more fixes needed to get everything building, but adding these > attributes is trivial enough, so I send them all in a single patch. lgtm, thanks -mike