From: Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb-add-index.sh: Remove use of non posix 'local'
Date: Fri, 26 Mar 2021 23:56:13 +0000 [thread overview]
Message-ID: <YF50ne8X+InSPj44@Plymouth> (raw)
In-Reply-To: <dd510543-99cd-21c7-0c64-6716469522a7@polymtl.ca>
Le Fri, Mar 26, 2021 at 02:39:52PM -0400, Simon Marchi a écrit :
> On 2021-03-26 1:14 p.m., Lancelot SIX via Gdb-patches wrote:
> > While working on gdb-add-index.sh, it appeared that it uses the non
> > POSIX 'local' keyword. Instead of using local to allow variable
> > shadowing, I rename the local one to avoid name conflicts altogether.
>
> Thanks, this is OK. You can also mention in the commit message that it
> gets rid of this shellcheck warning:
>
>
> In gdb-add-index.sh line 63:
> local file="$1"
> ^--------^ SC2039: In POSIX sh, 'local' is undefined.
>
>
> Simon
I have added this info to the commit message and pushed.
Thanks,
Lancelot.
prev parent reply other threads:[~2021-03-26 23:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 17:14 Lancelot SIX via Gdb-patches
2021-03-26 18:39 ` Simon Marchi via Gdb-patches
2021-03-26 23:56 ` Lancelot SIX via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YF50ne8X+InSPj44@Plymouth \
--to=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox