From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2WDxGKR0XmBEUAAAWB0awg (envelope-from ) for ; Fri, 26 Mar 2021 19:56:20 -0400 Received: by simark.ca (Postfix, from userid 112) id 58C151EF7C; Fri, 26 Mar 2021 19:56:20 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A8F8C1E590 for ; Fri, 26 Mar 2021 19:56:19 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3573B3858028; Fri, 26 Mar 2021 23:56:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3573B3858028 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1616802979; bh=cLr1BJ1DeAHaVXx8K09Mf8GiapETlVn06IlCv/mKEcQ=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=CnhA+fd4Rjg9PiBV93SMRutfon/DOLLnXIaNaD+vsSwoC0XX1B846J7x+bztHWufl 9Kkgx8dHPK5al2QlhwfQaIXznJ/PhERboyvudRvsXNhZNMIcWehAF64KCxTfguH+Lu EGMP20qWEGHuakRxUZ4C40sS6aEVFFL5i+EKx+68= Received: from lndn.lancelotsix.com (vps-42846194.vps.ovh.net [IPv6:2001:41d0:801:2000::2400]) by sourceware.org (Postfix) with ESMTPS id 1DAB0385801A for ; Fri, 26 Mar 2021 23:56:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1DAB0385801A Received: from Plymouth (unknown [IPv6:2a02:390:9086:0:bc12:e978:8e83:61f8]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 71D42818C3; Fri, 26 Mar 2021 23:56:15 +0000 (UTC) Date: Fri, 26 Mar 2021 23:56:13 +0000 To: Simon Marchi Subject: Re: [PATCH] gdb-add-index.sh: Remove use of non posix 'local' Message-ID: References: <20210326171454.2795-1-lsix@lancelotsix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Fri, 26 Mar 2021 23:56:16 +0000 (UTC) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Le Fri, Mar 26, 2021 at 02:39:52PM -0400, Simon Marchi a écrit : > On 2021-03-26 1:14 p.m., Lancelot SIX via Gdb-patches wrote: > > While working on gdb-add-index.sh, it appeared that it uses the non > > POSIX 'local' keyword. Instead of using local to allow variable > > shadowing, I rename the local one to avoid name conflicts altogether. > > Thanks, this is OK. You can also mention in the commit message that it > gets rid of this shellcheck warning: > > > In gdb-add-index.sh line 63: > local file="$1" > ^--------^ SC2039: In POSIX sh, 'local' is undefined. > > > Simon I have added this info to the commit message and pushed. Thanks, Lancelot.