Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: testsuite: push $arch out to targets
Date: Mon, 18 Jan 2021 13:01:53 -0500	[thread overview]
Message-ID: <YAXNEf6Xoak+sKjB@vapier> (raw)
In-Reply-To: <20210118095201.GN265215@embecosm.com>

On 18 Jan 2021 09:52, Andrew Burgess wrote:
> * Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org> [2021-01-17 11:09:45 -0500]:
> > This is needed to move to automake & its dejagnu-provided logic,
> > and eventually by the unified sim logic.
> 
> I looked through this patch and I didn't understand what's going on
> here.
> 
> Why do you need to set the global arch in some, but not all tests?

it is being done in all tests.  which ones do you think i skipped ?

> If this needs doing at all, could it not be done in some global location?

the sim ports use a unique subdir for their `run` program.  the tests
need to find that path.  this $arch value is what binds the specific
subdir to the test.

as we do multibuilds, we'll have multiple ports active, so a single
variable won't cut it.  moving it here and out of autotols enables
that.  as we do multitarget, this will help smooth the transition as
we won't have to juggle each arch as it migrates.
-mike

  reply	other threads:[~2021-01-18 18:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-17 16:09 Mike Frysinger via Gdb-patches
2021-01-18  9:52 ` Andrew Burgess
2021-01-18 18:01   ` Mike Frysinger via Gdb-patches [this message]
2021-01-20 19:53     ` Tom Tromey
2021-01-21  0:37       ` Mike Frysinger via Gdb-patches
2021-01-22 16:29         ` Tom Tromey
2021-01-23  4:35           ` Mike Frysinger via Gdb-patches
2021-01-23 17:33             ` Tom Tromey
2021-01-25  5:34               ` Mike Frysinger via Gdb-patches
2021-01-21  9:22     ` Andrew Burgess
2021-01-22  6:36       ` Mike Frysinger via Gdb-patches
2021-01-31  1:27         ` Mike Frysinger via Gdb-patches
2021-01-31 10:54         ` Andrew Burgess
2021-01-31 19:41           ` Mike Frysinger via Gdb-patches
2021-02-06 17:16             ` Mike Frysinger via Gdb-patches
2021-02-08 12:12             ` Andrew Burgess
2021-02-09  5:25               ` Mike Frysinger via Gdb-patches
2021-01-18 17:54 ` [PATCH 1/2] sim: switch top level to automake Mike Frysinger via Gdb-patches
2021-01-18 17:54   ` [PATCH 2/2] sim: testsuite: merge into toplevel automake Mike Frysinger via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YAXNEf6Xoak+sKjB@vapier \
    --to=gdb-patches@sourceware.org \
    --cc=andrew.burgess@embecosm.com \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox