From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id B/cuHxTNBWCZIwAAWB0awg (envelope-from ) for ; Mon, 18 Jan 2021 13:01:56 -0500 Received: by simark.ca (Postfix, from userid 112) id 717FE1EF80; Mon, 18 Jan 2021 13:01:56 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DD40F1E940 for ; Mon, 18 Jan 2021 13:01:55 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 845463854838; Mon, 18 Jan 2021 18:01:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 845463854838 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1610992915; bh=I9EewCg2lX9I6hyy8VG+cPBY9rWS3znH1pb5Y6CqCTI=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=UpBURa1J8i2mMEFkGiJ38eDVzmRCM2RnpRzdWSP03wd0OTB/FUpsJ14rz416c3LtD tcC8sxa+tTFaNsKx0Q6HcNDNNsWJLJ5CS9tMCW+bOfUR2ZE0OLKhFOg74A58FzWtVQ D3RMGqQWcIzhVbMFC4Qbxf0jFwaSA6ldXZzcenbo= Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 70F543854838 for ; Mon, 18 Jan 2021 18:01:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 70F543854838 Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id B1821340DE1; Mon, 18 Jan 2021 18:01:52 +0000 (UTC) Date: Mon, 18 Jan 2021 13:01:53 -0500 To: Andrew Burgess Subject: Re: [PATCH] sim: testsuite: push $arch out to targets Message-ID: Mail-Followup-To: Andrew Burgess , gdb-patches@sourceware.org References: <20210117160945.1362-1-vapier@gentoo.org> <20210118095201.GN265215@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210118095201.GN265215@embecosm.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 18 Jan 2021 09:52, Andrew Burgess wrote: > * Mike Frysinger via Gdb-patches [2021-01-17 11:09:45 -0500]: > > This is needed to move to automake & its dejagnu-provided logic, > > and eventually by the unified sim logic. > > I looked through this patch and I didn't understand what's going on > here. > > Why do you need to set the global arch in some, but not all tests? it is being done in all tests. which ones do you think i skipped ? > If this needs doing at all, could it not be done in some global location? the sim ports use a unique subdir for their `run` program. the tests need to find that path. this $arch value is what binds the specific subdir to the test. as we do multibuilds, we'll have multiple ports active, so a single variable won't cut it. moving it here and out of autotols enables that. as we do multitarget, this will help smooth the transition as we won't have to juggle each arch as it migrates. -mike