Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Schimpe, Christina" <christina.schimpe@intel.com>
To: Thiago Jung Bauermann <thiago.bauermann@linaro.org>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH 03/36] GDB: testsuite: intel: Don't return -1 from top-level (sed)
Date: Tue, 28 Apr 2026 15:54:07 +0000	[thread overview]
Message-ID: <SN7PR11MB76385D98EEF72ECE6F36411EF9372@SN7PR11MB7638.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20260427063500.3847618-4-thiago.bauermann@linaro.org>

Hi Thiago, 

Thank you for working on this.

> -----Original Message-----
> From: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
> Sent: Montag, 27. April 2026 08:34
> To: gdb-patches@sourceware.org
> Subject: [PATCH 03/36] GDB: testsuite: intel: Don't return -1 from top-level
> (sed)
> 
> This patch is purely the result of running:
> 
> $ sed -i 's/^    return -1/    return/' \
>       amd64-*.exp* i386-*.exp* x86*.exp* ia64*.exp*
> 
> inside gdb/testsuite/gdb.arch.
> ---
>  gdb/testsuite/gdb.arch/amd64-break-on-asm-line.exp        | 4 ++--
>  gdb/testsuite/gdb.arch/amd64-disp-step-avx.exp            | 2 +-
>  gdb/testsuite/gdb.arch/amd64-disp-step-self-call.exp      | 2 +-
>  gdb/testsuite/gdb.arch/amd64-disp-step.exp                | 2 +-
>  gdb/testsuite/gdb.arch/amd64-entry-value-inline.exp       | 4 ++--
>  gdb/testsuite/gdb.arch/amd64-entry-value-param-dwarf5.exp | 4 ++--
>  gdb/testsuite/gdb.arch/amd64-entry-value-param.exp        | 4 ++--
>  gdb/testsuite/gdb.arch/amd64-entry-value-paramref.exp     | 4 ++--
>  gdb/testsuite/gdb.arch/amd64-entry-value.exp              | 4 ++--
>  gdb/testsuite/gdb.arch/amd64-eval.exp                     | 4 ++--
>  gdb/testsuite/gdb.arch/amd64-frameptr-vecreg-unwind.exp   | 2 +-
>  gdb/testsuite/gdb.arch/amd64-gs_base.exp                  | 4 ++--
>  gdb/testsuite/gdb.arch/amd64-i386-address.exp             | 2 +-
>  gdb/testsuite/gdb.arch/amd64-init-x87-values.exp          | 2 +-
>  gdb/testsuite/gdb.arch/amd64-invalid-stack-middle.exp     | 8 ++++----
>  gdb/testsuite/gdb.arch/amd64-invalid-stack-top.exp        | 8 ++++----
>  gdb/testsuite/gdb.arch/amd64-lam.exp                      | 4 ++--
>  gdb/testsuite/gdb.arch/amd64-optimout-repeat.exp          | 4 ++--
>  gdb/testsuite/gdb.arch/amd64-prologue-xmm.exp             | 4 ++--
>  gdb/testsuite/gdb.arch/amd64-pseudo-unwind.exp            | 2 +-
>  gdb/testsuite/gdb.arch/amd64-stap-expressions.exp         | 4 ++--
>  gdb/testsuite/gdb.arch/amd64-stap-optional-prefix.exp     | 4 ++--
>  gdb/testsuite/gdb.arch/amd64-stap-special-operands.exp    | 4 ++--
>  gdb/testsuite/gdb.arch/amd64-stap-wrong-subexp.exp        | 2 +-
>  gdb/testsuite/gdb.arch/amd64-tailcall-cxx.exp             | 4 ++--
>  gdb/testsuite/gdb.arch/amd64-tailcall-noret.exp           | 4 ++--
>  gdb/testsuite/gdb.arch/amd64-tailcall-ret.exp             | 4 ++--
>  gdb/testsuite/gdb.arch/amd64-tailcall-self.exp            | 4 ++--
>  gdb/testsuite/gdb.arch/amd64-watchpoint-downgrade.exp     | 4 ++--
>  gdb/testsuite/gdb.arch/i386-attach-see-vdso.exp           | 2 +-
>  gdb/testsuite/gdb.arch/i386-avx512.exp                    | 4 ++--
>  gdb/testsuite/gdb.arch/i386-biarch-core.exp               | 4 ++--
>  gdb/testsuite/gdb.arch/i386-bp_permanent.exp              | 2 +-
>  gdb/testsuite/gdb.arch/i386-cfi-notcurrent.exp            | 4 ++--
>  gdb/testsuite/gdb.arch/i386-disp-step-self-call.exp       | 2 +-
>  gdb/testsuite/gdb.arch/i386-disp-step.exp                 | 2 +-
>  gdb/testsuite/gdb.arch/i386-dr3-watch.exp                 | 4 ++--
>  gdb/testsuite/gdb.arch/i386-float.exp                     | 2 +-
>  gdb/testsuite/gdb.arch/i386-gnu-cfi.exp                   | 4 ++--
>  gdb/testsuite/gdb.arch/i386-permbkpt.exp                  | 2 +-
>  gdb/testsuite/gdb.arch/i386-pkru.exp                      | 4 ++--
>  gdb/testsuite/gdb.arch/i386-prologue.exp                  | 2 +-
>  gdb/testsuite/gdb.arch/i386-signal.exp                    | 2 +-
>  gdb/testsuite/gdb.arch/i386-size-overlap.exp              | 2 +-
>  gdb/testsuite/gdb.arch/i386-size.exp                      | 2 +-
>  gdb/testsuite/gdb.arch/i386-sse-stack-align.exp           | 4 ++--
>  gdb/testsuite/gdb.arch/i386-stap-eval-lang-ada.exp        | 4 ++--
>  gdb/testsuite/gdb.arch/i386-unwind.exp                    | 2 +-
>  gdb/testsuite/gdb.arch/ia64-breakpoint-shadow.exp         | 6 +++---
>  gdb/testsuite/gdb.arch/x86-avx512bf16.exp                 | 4 ++--
>  gdb/testsuite/gdb.arch/x86-avx512fp16-abi.exp             | 4 ++--
>  gdb/testsuite/gdb.arch/x86-avx512fp16.exp                 | 4 ++--
>  52 files changed, 90 insertions(+), 90 deletions(-)
> 
> diff --git a/gdb/testsuite/gdb.arch/amd64-break-on-asm-line.exp
> b/gdb/testsuite/gdb.arch/amd64-break-on-asm-line.exp
> index 93e1ed36652b..bd05a4d4ae3a 100644
> --- a/gdb/testsuite/gdb.arch/amd64-break-on-asm-line.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-break-on-asm-line.exp
> @@ -20,11 +20,11 @@ standard_testfile .S  if { [prepare_for_testing "failed
> to prepare" ${testfile} ${srcfile} \
>  	  { debug }] } {
>      untested "could not compile"
> -    return -1
> +    return
>  }
> 
>  if {![runto_main]} {
> -    return -1
> +    return
>  }
> 
>  gdb_breakpoint [gdb_get_line_number "Break here"] diff --git
> a/gdb/testsuite/gdb.arch/amd64-disp-step-avx.exp
> b/gdb/testsuite/gdb.arch/amd64-disp-step-avx.exp
> index 3a16bfb3824f..db458b3a7863 100644
> --- a/gdb/testsuite/gdb.arch/amd64-disp-step-avx.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-disp-step-avx.exp
> @@ -25,7 +25,7 @@ standard_testfile .S
> 
>  set options [list debug nopie]
>  if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} $options] } {
> -    return -1
> +    return
>  }
> 
>  # Get things started.
> diff --git a/gdb/testsuite/gdb.arch/amd64-disp-step-self-call.exp
> b/gdb/testsuite/gdb.arch/amd64-disp-step-self-call.exp
> index ce0283d462e7..38852cb2f272 100644
> --- a/gdb/testsuite/gdb.arch/amd64-disp-step-self-call.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-disp-step-self-call.exp
> @@ -25,7 +25,7 @@ set opts {debug nopie}  standard_testfile .S -alarm.c
> 
>  if { [prepare_for_testing "failed to prepare" $testfile "$srcfile $srcfile2" $opts]
> } {
> -    return -1
> +    return
>  }
> 
>  gdb_test "set displaced-stepping on" ""
> diff --git a/gdb/testsuite/gdb.arch/amd64-disp-step.exp
> b/gdb/testsuite/gdb.arch/amd64-disp-step.exp
> index d05b6760e585..e8f4b7aea8e5 100644
> --- a/gdb/testsuite/gdb.arch/amd64-disp-step.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-disp-step.exp
> @@ -25,7 +25,7 @@ set opts {debug nopie}  standard_testfile .S -signal.c
> 
>  if { [prepare_for_testing "failed to prepare" $testfile "$srcfile $srcfile2" $opts]
> } {
> -    return -1
> +    return
>  }
> 
>  gdb_test "set displaced-stepping on" ""
> diff --git a/gdb/testsuite/gdb.arch/amd64-entry-value-inline.exp
> b/gdb/testsuite/gdb.arch/amd64-entry-value-inline.exp
> index 257a7c8cf604..b67f676b7163 100644
> --- a/gdb/testsuite/gdb.arch/amd64-entry-value-inline.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-entry-value-inline.exp
> @@ -30,11 +30,11 @@ if {[is_remote host]} {  }
> 
>  if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} $opts] } {
> -    return -1
> +    return
>  }
> 
>  if {![runto_main]} {
> -    return -1
> +    return
>  }
> 
>  gdb_breakpoint [gdb_get_line_number "break-here" $srcfile2] diff --git
> a/gdb/testsuite/gdb.arch/amd64-entry-value-param-dwarf5.exp
> b/gdb/testsuite/gdb.arch/amd64-entry-value-param-dwarf5.exp
> index e5697c9c9ab5..8043235eec8e 100644
> --- a/gdb/testsuite/gdb.arch/amd64-entry-value-param-dwarf5.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-entry-value-param-dwarf5.exp
> @@ -30,11 +30,11 @@ if {[is_remote host]} {  }
> 
>  if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} $opts] } {
> -    return -1
> +    return
>  }
> 
>  if {![runto_main]} {
> -    return -1
> +    return
>  }
> 
>  gdb_breakpoint [gdb_get_line_number "break-here" $srcfile2] diff --git
> a/gdb/testsuite/gdb.arch/amd64-entry-value-param.exp
> b/gdb/testsuite/gdb.arch/amd64-entry-value-param.exp
> index 5b2b65e86365..4c1d63ab5a3c 100644
> --- a/gdb/testsuite/gdb.arch/amd64-entry-value-param.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-entry-value-param.exp
> @@ -30,11 +30,11 @@ if {[is_remote host]} {  }
> 
>  if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} $opts] } {
> -    return -1
> +    return
>  }
> 
>  if {![runto_main]} {
> -    return -1
> +    return
>  }
> 
>  gdb_breakpoint [gdb_get_line_number "break-here" $srcfile2] diff --git
> a/gdb/testsuite/gdb.arch/amd64-entry-value-paramref.exp
> b/gdb/testsuite/gdb.arch/amd64-entry-value-paramref.exp
> index 146d92eb2670..cb789b541bc2 100644
> --- a/gdb/testsuite/gdb.arch/amd64-entry-value-paramref.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-entry-value-paramref.exp
> @@ -24,11 +24,11 @@ if {[is_remote host]} {
> 
>  if { [prepare_for_testing_full "failed to prepare" \
>  	  [list $testfile "c++" $srcfile {}]] } {
> -    return -1
> +    return
>  }
> 
>  if {![runto_main]} {
> -    return -1
> +    return
>  }
> 
>  gdb_breakpoint [gdb_get_line_number "break-here" $srcfile2] diff --git
> a/gdb/testsuite/gdb.arch/amd64-entry-value.exp
> b/gdb/testsuite/gdb.arch/amd64-entry-value.exp
> index 65c4ab142c3e..997312ee4375 100644
> --- a/gdb/testsuite/gdb.arch/amd64-entry-value.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-entry-value.exp
> @@ -27,11 +27,11 @@ if {[info exists COMPILE]} {  }
> 
>  if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} $opts] } {
> -    return -1
> +    return
>  }
> 
>  if {![runto_main]} {
> -    return -1
> +    return
>  }
> 
>  gdb_breakpoint "breakhere"
> diff --git a/gdb/testsuite/gdb.arch/amd64-eval.exp
> b/gdb/testsuite/gdb.arch/amd64-eval.exp
> index 34fb21e0678f..2b145375595b 100644
> --- a/gdb/testsuite/gdb.arch/amd64-eval.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-eval.exp
> @@ -23,11 +23,11 @@ standard_testfile .cc
> 
>  if { [prepare_for_testing "failed to prepare" $testfile $srcfile \
>  	  { debug c++ additional_flags=-std=c++11 }] } {
> -    return -1
> +    return
>  }
> 
>  if {![runto_main]} {
> -    return -1
> +    return
>  }
> 
>  gdb_breakpoint [gdb_get_line_number "break-here"] diff --git
> a/gdb/testsuite/gdb.arch/amd64-frameptr-vecreg-unwind.exp
> b/gdb/testsuite/gdb.arch/amd64-frameptr-vecreg-unwind.exp
> index e1ca703881dd..9e358c016427 100644
> --- a/gdb/testsuite/gdb.arch/amd64-frameptr-vecreg-unwind.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-frameptr-vecreg-unwind.exp
> @@ -26,7 +26,7 @@ standard_testfile
> 
>  if { [prepare_for_testing "failed to prepare" ${testfile} \
>  	"${srcfile}" {debug}] } {
> -    return -1
> +    return
>  }
> 
>  if {![runto_main]} {
> diff --git a/gdb/testsuite/gdb.arch/amd64-gs_base.exp
> b/gdb/testsuite/gdb.arch/amd64-gs_base.exp
> index db64c52d89fd..c879cd9d2bf6 100644
> --- a/gdb/testsuite/gdb.arch/amd64-gs_base.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-gs_base.exp
> @@ -19,11 +19,11 @@ require is_amd64_regs_target
> 
>  if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \
>       [list debug nowarnings]] } {
> -    return -1
> +    return
>  }
> 
>  if {![runto_main]} {
> -    return -1
> +    return
>  }
> 
>  gdb_test "print /x \$fs_base" "= $hex" "print fs_base"
> diff --git a/gdb/testsuite/gdb.arch/amd64-i386-address.exp
> b/gdb/testsuite/gdb.arch/amd64-i386-address.exp
> index 710e9c0cdb46..c9e759272355 100644
> --- a/gdb/testsuite/gdb.arch/amd64-i386-address.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-i386-address.exp
> @@ -22,7 +22,7 @@ require {is_any_target "x86_64-*-*" "i?86-*-*"}
> is_lp64_target  require {!istarget "*-*-openbsd*"}
> 
>  if {[prepare_for_testing "failed to prepare" amd64-i386-address amd64-i386-
> address.S [list debug "additional_flags=-m32 -nostdlib"]]} {
> -    return -1
> +    return
>  }
> 
>  gdb_run_cmd
> diff --git a/gdb/testsuite/gdb.arch/amd64-init-x87-values.exp
> b/gdb/testsuite/gdb.arch/amd64-init-x87-values.exp
> index 91c198e43a31..4c7664676d63 100644
> --- a/gdb/testsuite/gdb.arch/amd64-init-x87-values.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-init-x87-values.exp
> @@ -26,7 +26,7 @@ set options [list debug \
>  		 additional_flags=-static \
>  		 ldflags=-nostartfiles]
>  if { [build_executable "failed to prepare" ${testfile} ${srcfile} $options] } {
> -    return -1
> +    return
>  }
> 
>  # Start the test file, and check the x87 control registers (and diff --git
> a/gdb/testsuite/gdb.arch/amd64-invalid-stack-middle.exp
> b/gdb/testsuite/gdb.arch/amd64-invalid-stack-middle.exp
> index 713bef8ba473..a48896d60a6c 100644
> --- a/gdb/testsuite/gdb.arch/amd64-invalid-stack-middle.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-invalid-stack-middle.exp
> @@ -32,11 +32,11 @@ standard_testfile .S  require is_x86_64_m64_target
> 
>  if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} {nopie}] } {
> -    return -1
> +    return
>  }
> 
>  if {![runto breakpt]} {
> -    return -1
> +    return
>  }
> 
>  gdb_test "bt" "^#0 +breakpt *\\(\\) \[^\r\n\]*\r\n#1 +${::hex} in
> func5\[^\r\n\]*\r\n#2 +${::hex} in func4\[^\r\n\]*\r\n#3 +${::hex} in
> func3\[^\r\n\]*\r\nBacktrace stopped: Cannot access memory at address
> ${::hex}" \ @@ -48,7 +48,7 @@ gdb_test "bt" "^#0 +breakpt *\\(\\)
> \[^\r\n\]*\r\n#1 +${::hex} in func5\[^\r\n\]  clean_restart ${::testfile}
> 
>  if {![runto breakpt]} {
> -    return -1
> +    return
>  }
> 
>  gdb_test "interpreter-exec mi \"-stack-info-depth\"" \ @@ -62,7 +62,7 @@
> gdb_test "interpreter-exec mi \"-stack-info-depth\"" \  clean_restart
> ${::testfile}
> 
>  if {![runto breakpt]} {
> -    return -1
> +    return
>  }
> 
>  gdb_test "interpreter-exec mi \"-stack-list-frames\"" \ diff --git
> a/gdb/testsuite/gdb.arch/amd64-invalid-stack-top.exp
> b/gdb/testsuite/gdb.arch/amd64-invalid-stack-top.exp
> index 9a4f2e2663e2..d3ad91ed64fd 100644
> --- a/gdb/testsuite/gdb.arch/amd64-invalid-stack-top.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-invalid-stack-top.exp
> @@ -33,11 +33,11 @@ standard_testfile .c  require is_x86_64_m64_target
> 
>  if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} $opts] } {
> -    return -1
> +    return
>  }
> 
>  if {![runto breakpt]} {
> -    return -1
> +    return
>  }
> 
>  # Use 'bt no-filters' here as the python filters will raise their own @@ -52,7
> +52,7 @@ gdb_test "bt no-filters" "^#0 +$hex in func2 \\(\\)\r\nBacktrace
> stopped: Cannot  clean_restart ${::testfile}
> 
>  if {![runto breakpt]} {
> -    return -1
> +    return
>  }
> 
>  gdb_test "interpreter-exec mi \"-stack-info-depth\"" \ @@ -66,7 +66,7 @@
> gdb_test "interpreter-exec mi \"-stack-info-depth\"" \  clean_restart
> ${::testfile}
> 
>  if {![runto breakpt]} {
> -    return -1
> +    return
>  }
> 
>  gdb_test "interpreter-exec mi \"-stack-list-frames\"" \ diff --git
> a/gdb/testsuite/gdb.arch/amd64-lam.exp b/gdb/testsuite/gdb.arch/amd64-
> lam.exp
> index 746ab313871b..3abdb3116d88 100644
> --- a/gdb/testsuite/gdb.arch/amd64-lam.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-lam.exp
> @@ -21,11 +21,11 @@ standard_testfile amd64-lam.c
> 
>  # Test LAM 57.
>  if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } {
> -    return -1
> +    return
>  }
> 
>  if { ![runto_main] } {
> -    return -1
> +    return
>  }
> 
>  gdb_breakpoint [gdb_get_line_number "Breakpoint here"] diff --git
> a/gdb/testsuite/gdb.arch/amd64-optimout-repeat.exp
> b/gdb/testsuite/gdb.arch/amd64-optimout-repeat.exp
> index 209aa240e623..a2651898b0c6 100644
> --- a/gdb/testsuite/gdb.arch/amd64-optimout-repeat.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-optimout-repeat.exp
> @@ -25,11 +25,11 @@ if {[info exists COMPILE]} {  }
> 
>  if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} $opts] } {
> -    return -1
> +    return
>  }
> 
>  if {![runto_main]} {
> -    return -1
> +    return
>  }
> 
>  gdb_test "print v" { = {i = 0, xxx = {<optimized out> <repeats 256 times>}}}
> diff --git a/gdb/testsuite/gdb.arch/amd64-prologue-xmm.exp
> b/gdb/testsuite/gdb.arch/amd64-prologue-xmm.exp
> index bae24da9cf76..f402350acdee 100644
> --- a/gdb/testsuite/gdb.arch/amd64-prologue-xmm.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-prologue-xmm.exp
> @@ -29,11 +29,11 @@ if {[info exists COMPILE]} {  }
> 
>  if {[prepare_for_testing "failed to prepare" ${testfile} $srcfile $opts]} {
> -    return -1
> +    return
>  }
> 
>  if {![runto_main]} {
> -    return -1
> +    return
>  }
> 
>  gdb_breakpoint "func"
> diff --git a/gdb/testsuite/gdb.arch/amd64-pseudo-unwind.exp
> b/gdb/testsuite/gdb.arch/amd64-pseudo-unwind.exp
> index a50978d439eb..44ef137d8758 100644
> --- a/gdb/testsuite/gdb.arch/amd64-pseudo-unwind.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-pseudo-unwind.exp
> @@ -29,7 +29,7 @@ standard_testfile amd64-pseudo-unwind.c amd64-
> pseudo-unwind-asm.S
> 
>  if { [prepare_for_testing "failed to prepare" ${testfile} \
>  	"${srcfile} ${srcfile2}" {debug}] } {
> -    return -1
> +    return
>  }
> 
>  clean_restart ${::testfile}
> diff --git a/gdb/testsuite/gdb.arch/amd64-stap-expressions.exp
> b/gdb/testsuite/gdb.arch/amd64-stap-expressions.exp
> index 4f2c6c26dab4..1d6d0cf786c5 100644
> --- a/gdb/testsuite/gdb.arch/amd64-stap-expressions.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-stap-expressions.exp
> @@ -18,7 +18,7 @@ standard_testfile ".S"
>  require is_x86_64_m64_target
> 
>  if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } {
> -    return -1
> +    return
>  }
> 
>  # Helper procedure to go to probe NAME
> @@ -38,7 +38,7 @@ proc test_probe_value { value } {  }
> 
>  if { ![runto_main] } {
> -    return -1
> +    return
>  }
> 
>  # Name and expected value for each probe.
> diff --git a/gdb/testsuite/gdb.arch/amd64-stap-optional-prefix.exp
> b/gdb/testsuite/gdb.arch/amd64-stap-optional-prefix.exp
> index 4b4d0543f64d..9cd7dec166c1 100644
> --- a/gdb/testsuite/gdb.arch/amd64-stap-optional-prefix.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-stap-optional-prefix.exp
> @@ -20,7 +20,7 @@ standard_testfile ".S"
>  require is_x86_64_m64_target
> 
>  if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } {
> -    return -1
> +    return
>  }
> 
>  # Helper procedure to go to probe NAME
> @@ -46,7 +46,7 @@ proc test_probe_value_without_reg { value } {  }
> 
>  if { ![runto_main] } {
> -    return -1
> +    return
>  }
> 
>  foreach probe_name [list "foo" "bar" "foo_prefix" "bar_prefix"] \ diff --git
> a/gdb/testsuite/gdb.arch/amd64-stap-special-operands.exp
> b/gdb/testsuite/gdb.arch/amd64-stap-special-operands.exp
> index 9c819e490acd..3fbdae9197de 100644
> --- a/gdb/testsuite/gdb.arch/amd64-stap-special-operands.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-stap-special-operands.exp
> @@ -29,7 +29,7 @@ proc test_probe { probe_name } {  standard_testfile
> amd64-stap-triplet.S
> 
>  if { [prepare_for_testing "failed to prepare" $testfile-triplet $srcfile] } {
> -    return -1
> +    return
>  }
> 
>  test_probe "triplet"
> @@ -38,7 +38,7 @@ standard_testfile amd64-stap-three-arg-disp.S
> 
>  if { [prepare_for_testing "failed to prepare" $testfile-three-arg-displ \
>  	  $srcfile] } {
> -    return -1
> +    return
>  }
> 
>  test_probe "three_arg"
> diff --git a/gdb/testsuite/gdb.arch/amd64-stap-wrong-subexp.exp
> b/gdb/testsuite/gdb.arch/amd64-stap-wrong-subexp.exp
> index 2f55fbdf82c8..e7089c20f489 100644
> --- a/gdb/testsuite/gdb.arch/amd64-stap-wrong-subexp.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-stap-wrong-subexp.exp
> @@ -18,7 +18,7 @@ require is_x86_64_m64_target  standard_testfile
> amd64-stap-wrong-subexp.S
> 
>  if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } {
> -    return -1
> +    return
>  }
> 
>  proc goto_probe { probe_name } {
> diff --git a/gdb/testsuite/gdb.arch/amd64-tailcall-cxx.exp
> b/gdb/testsuite/gdb.arch/amd64-tailcall-cxx.exp
> index 5d6ae1776c66..c2cffe0793b2 100644
> --- a/gdb/testsuite/gdb.arch/amd64-tailcall-cxx.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-tailcall-cxx.exp
> @@ -27,11 +27,11 @@ if {[info exists COMPILE]} {  }
> 
>  if { [prepare_for_testing "failed to prepare" ${testfile} "${srcfile} ${srcfile2}"
> $opts] } {
> -    return -1
> +    return
>  }
> 
>  if {![runto g]} {
> -    return -1
> +    return
>  }
> 
>  gdb_test "bt" "\r\n#0 +g \\(x=x@entry=2\\) at \[^\r\n\]*\r\n#1 +${::hex} in f
> \\(x=x@entry=1\\) at \[^\r\n\]*\r\n#2 +${::hex} in main .*"
> diff --git a/gdb/testsuite/gdb.arch/amd64-tailcall-noret.exp
> b/gdb/testsuite/gdb.arch/amd64-tailcall-noret.exp
> index 8a58dda00b1d..767602805b97 100644
> --- a/gdb/testsuite/gdb.arch/amd64-tailcall-noret.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-tailcall-noret.exp
> @@ -27,11 +27,11 @@ if {[info exists COMPILE]} {  lappend opts nopie
> 
>  if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} $opts] } {
> -    return -1
> +    return
>  }
> 
>  if {![runto noret]} {
> -    return -1
> +    return
>  }
> 
>  gdb_test "bt" "#0 +noret \\(x=1\\) at \[^\r\n\]*\r\n#1 +${::hex} in mayret
> \\(x=x@entry=1\\) at \[^\r\n\]*\r\n#2 +${::hex} in tailcall \\(x=x@entry=1\\)
> at \[^\r\n\]*\r\n#3 +${::hex} in main \\(\\) at .*"
> diff --git a/gdb/testsuite/gdb.arch/amd64-tailcall-ret.exp
> b/gdb/testsuite/gdb.arch/amd64-tailcall-ret.exp
> index 00ed2323a620..7ae151c690f3 100644
> --- a/gdb/testsuite/gdb.arch/amd64-tailcall-ret.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-tailcall-ret.exp
> @@ -30,11 +30,11 @@ if {[is_remote host]} {  }
> 
>  if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} $opts] } {
> -    return -1
> +    return
>  }
> 
>  if {![runto_main]} {
> -    return -1
> +    return
>  }
> 
>  gdb_breakpoint "g"
> diff --git a/gdb/testsuite/gdb.arch/amd64-tailcall-self.exp
> b/gdb/testsuite/gdb.arch/amd64-tailcall-self.exp
> index 63a3e00411a9..f1c6396d5108 100644
> --- a/gdb/testsuite/gdb.arch/amd64-tailcall-self.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-tailcall-self.exp
> @@ -18,11 +18,11 @@ standard_testfile .S  require is_x86_64_m64_target
> 
>  if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} {}] } {
> -    return -1
> +    return
>  }
> 
>  if {![runto b]} {
> -    return -1
> +    return
>  }
> 
>  gdb_test "bt" "#0 +b \\(\\) at \[^\r\n\]*\r\n#1 +${::hex} in a \\(q=<optimized
> out>\\) at \[^\r\n\]*\r\n#2 +${::hex} in main \\(\[^\r\n\]*\\) at .*"
> diff --git a/gdb/testsuite/gdb.arch/amd64-watchpoint-downgrade.exp
> b/gdb/testsuite/gdb.arch/amd64-watchpoint-downgrade.exp
> index e26d6efb201c..459330563f87 100644
> --- a/gdb/testsuite/gdb.arch/amd64-watchpoint-downgrade.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-watchpoint-downgrade.exp
> @@ -31,14 +31,14 @@ require target_can_use_run_cmd
> is_x86_64_m64_target  if {[target_info gdb_protocol] == "remote"
>      || [target_info gdb_protocol] == "extended-remote"} {
>      unsupported "using [target_info gdb_protocol] protocol"
> -    return -1
> +    return
>  }
> 
>  standard_testfile
> 
>  if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \
>  	  { debug }] } {
> -    return -1
> +    return
>  }
> 
>  # Insert the watchpoint, it should default to a h/w watchpoint.
> diff --git a/gdb/testsuite/gdb.arch/i386-attach-see-vdso.exp
> b/gdb/testsuite/gdb.arch/i386-attach-see-vdso.exp
> index 46f81f28c2d4..a53e14bf33d0 100644
> --- a/gdb/testsuite/gdb.arch/i386-attach-see-vdso.exp
> +++ b/gdb/testsuite/gdb.arch/i386-attach-see-vdso.exp
> @@ -28,7 +28,7 @@ if {![istarget "i386-*-*"]} {
> 
>  # The kernel VDSO is used for the syscalls returns only on i386 (not x86_64).
>  if { [build_executable "failed to prepare" $testfile $srcfile $options] } {
> -    return -1
> +    return
>  }
> 
>  # Don't tell GDB which executable we're debugging.
> diff --git a/gdb/testsuite/gdb.arch/i386-avx512.exp
> b/gdb/testsuite/gdb.arch/i386-avx512.exp
> index f1a0d59ccd89..c79563366dc8 100644
> --- a/gdb/testsuite/gdb.arch/i386-avx512.exp
> +++ b/gdb/testsuite/gdb.arch/i386-avx512.exp
> @@ -28,11 +28,11 @@ set comp_flags "-mavx512f -I${srcdir}/../nat"
> 
>  if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \
>       [list debug nowarnings additional_flags=${comp_flags}]] } {
> -    return -1
> +    return
>  }
> 
>  if {![runto_main]} {
> -    return -1
> +    return
>  }
> 
>  set supports_avx512 0
> diff --git a/gdb/testsuite/gdb.arch/i386-biarch-core.exp
> b/gdb/testsuite/gdb.arch/i386-biarch-core.exp
> index 95b1a3e29cb0..a9102559e5b5 100644
> --- a/gdb/testsuite/gdb.arch/i386-biarch-core.exp
> +++ b/gdb/testsuite/gdb.arch/i386-biarch-core.exp
> @@ -40,13 +40,13 @@ set address 0x400078  set corefile [decompress_bz2
> $corebz2file]  if { $corefile == "" } {
>      untested "failed bzip2"
> -    return -1
> +    return
>  }
> 
>  file stat ${corefile} corestat
>  if {$corestat(size) != 102400} {
>      untested "bzip2 produces invalid result"
> -    return -1
> +    return
>  }
> 
>  set corefile [gdb_remote_download host $corefile] diff --git
> a/gdb/testsuite/gdb.arch/i386-bp_permanent.exp
> b/gdb/testsuite/gdb.arch/i386-bp_permanent.exp
> index d2fcf0a311f9..ef4d0370de89 100644
> --- a/gdb/testsuite/gdb.arch/i386-bp_permanent.exp
> +++ b/gdb/testsuite/gdb.arch/i386-bp_permanent.exp
> @@ -29,7 +29,7 @@ set additional_flags [gdb_target_symbol_prefix_flags]
> # fragments.
>  if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable [list
> $additional_flags]] != "" } {
>      untested "failed to compile"
> -    return -1
> +    return
>  }
> 
> 
> diff --git a/gdb/testsuite/gdb.arch/i386-cfi-notcurrent.exp
> b/gdb/testsuite/gdb.arch/i386-cfi-notcurrent.exp
> index 11a9f0331928..a340182c1d88 100644
> --- a/gdb/testsuite/gdb.arch/i386-cfi-notcurrent.exp
> +++ b/gdb/testsuite/gdb.arch/i386-cfi-notcurrent.exp
> @@ -22,11 +22,11 @@ set testfile "i386-cfi-notcurrent"
>  set srcfile ${testfile}.S
> 
>  if {[prepare_for_testing "failed to prepare" ${testfile} ${srcfile} {nodebug}]} {
> -    return -1
> +    return
>  }
> 
>  if {![runto f]} {
> -    return -1
> +    return
>  }
> 
>  gdb_test "backtrace" "#0 \[^\r\n\]* f \[^\r\n\]*\r\n#1 \[^\r\n\]* g
> \[^\r\n\]*\r\n#2 \[^\r\n\]* main \[^\r\n\]*"
> diff --git a/gdb/testsuite/gdb.arch/i386-disp-step-self-call.exp
> b/gdb/testsuite/gdb.arch/i386-disp-step-self-call.exp
> index 8c7061ecd78e..5ea8d8f543af 100644
> --- a/gdb/testsuite/gdb.arch/i386-disp-step-self-call.exp
> +++ b/gdb/testsuite/gdb.arch/i386-disp-step-self-call.exp
> @@ -25,7 +25,7 @@ set opts {debug nopie}  standard_testfile .S -alarm.c
> 
>  if { [prepare_for_testing "failed to prepare" $testfile "$srcfile $srcfile2" $opts]
> } {
> -    return -1
> +    return
>  }
> 
>  gdb_test "set displaced-stepping on" ""
> diff --git a/gdb/testsuite/gdb.arch/i386-disp-step.exp
> b/gdb/testsuite/gdb.arch/i386-disp-step.exp
> index b593651ad45c..ba8931e8ff19 100644
> --- a/gdb/testsuite/gdb.arch/i386-disp-step.exp
> +++ b/gdb/testsuite/gdb.arch/i386-disp-step.exp
> @@ -27,7 +27,7 @@ lappend opts debug
>  lappend opts nopie
> 
>  if { [prepare_for_testing "failed to prepare" $testfile $srcfile $opts] } {
> -    return -1
> +    return
>  }
> 
>  gdb_test "set displaced-stepping on" ""
> diff --git a/gdb/testsuite/gdb.arch/i386-dr3-watch.exp
> b/gdb/testsuite/gdb.arch/i386-dr3-watch.exp
> index 058eefdb0051..d0c9209f62c3 100644
> --- a/gdb/testsuite/gdb.arch/i386-dr3-watch.exp
> +++ b/gdb/testsuite/gdb.arch/i386-dr3-watch.exp
> @@ -24,11 +24,11 @@ require {is_any_target "i?86-*-*" "x86_64-*-*"}
> standard_testfile
> 
>  if {[prepare_for_testing "failed to prepare" ${testfile} ${srcfile} {debug
> $additional_flags}]} {
> -    return -1
> +    return
>  }
> 
>  if {![runto_main]} {
> -    return -1
> +    return
>  }
> 
>  gdb_test_no_output "set breakpoint always-inserted on"
> diff --git a/gdb/testsuite/gdb.arch/i386-float.exp
> b/gdb/testsuite/gdb.arch/i386-float.exp
> index 23db5f843c2c..e1e8af45f056 100644
> --- a/gdb/testsuite/gdb.arch/i386-float.exp
> +++ b/gdb/testsuite/gdb.arch/i386-float.exp
> @@ -26,7 +26,7 @@ standard_testfile .S
>  set additional_flags [gdb_target_symbol_prefix_flags_asm]
> 
>  if { [prepare_for_testing "failed to prepare" $testfile $srcfile [list debug nopie
> $additional_flags]] } {
> -    return -1
> +    return
>  }
> 
>  if {![runto_main]} {
> diff --git a/gdb/testsuite/gdb.arch/i386-gnu-cfi.exp
> b/gdb/testsuite/gdb.arch/i386-gnu-cfi.exp
> index c7e019829e75..458a902fb974 100644
> --- a/gdb/testsuite/gdb.arch/i386-gnu-cfi.exp
> +++ b/gdb/testsuite/gdb.arch/i386-gnu-cfi.exp
> @@ -35,7 +35,7 @@ set additional_flags [gdb_target_symbol_prefix_flags]
> 
>  if { [gdb_compile "${srcdir}/${subdir}/${srcfilec}
> ${srcdir}/${subdir}/${srcfileasm}" "${binfile}" executable [list debug
> $additional_flags]] != "" } {
>      untested "failed to compile"
> -    return -1
> +    return
>  }
> 
>  # Get things started.
> @@ -67,7 +67,7 @@ gdb_test_multiple "backtrace" "" {
>      }
>  }
>  if { $gate_n == "" } {
> -    return -1
> +    return
>  }
> 
>  # Check we see the inserted `DW_CFA_GNU_negative_offset_extended' CFI.
> diff --git a/gdb/testsuite/gdb.arch/i386-permbkpt.exp
> b/gdb/testsuite/gdb.arch/i386-permbkpt.exp
> index f365597e052e..58ab263688a1 100644
> --- a/gdb/testsuite/gdb.arch/i386-permbkpt.exp
> +++ b/gdb/testsuite/gdb.arch/i386-permbkpt.exp
> @@ -27,7 +27,7 @@ set additional_flags
> [gdb_target_symbol_prefix_flags_asm]
> 
>  if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable [list
> debug $additional_flags]] != "" } {
>      untested "failed to compile"
> -    return -1
> +    return
>  }
> 
>  clean_restart ${::testfile}
> diff --git a/gdb/testsuite/gdb.arch/i386-pkru.exp
> b/gdb/testsuite/gdb.arch/i386-pkru.exp
> index 94cf2101e18b..b9b0b99b0de3 100644
> --- a/gdb/testsuite/gdb.arch/i386-pkru.exp
> +++ b/gdb/testsuite/gdb.arch/i386-pkru.exp
> @@ -31,11 +31,11 @@ set comp_flags "-I${srcdir}/../nat/"
>  if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \
>       [list debug additional_flags=${comp_flags}]] } {
>      untested "failed to compile x86 PKEYS test."
> -    return -1
> +    return
>  }
> 
>  if {![runto_main]} {
> -    return -1
> +    return
>  }
> 
>  set supports_pkru 0
> diff --git a/gdb/testsuite/gdb.arch/i386-prologue.exp
> b/gdb/testsuite/gdb.arch/i386-prologue.exp
> index 03a32ba9c3f9..c02858efe4c3 100644
> --- a/gdb/testsuite/gdb.arch/i386-prologue.exp
> +++ b/gdb/testsuite/gdb.arch/i386-prologue.exp
> @@ -34,7 +34,7 @@ set additional_flags [gdb_target_symbol_prefix_flags]
> # fragments.
>  if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable [list
> $additional_flags]] != "" } {
>      untested "failed to compile"
> -    return -1
> +    return
>  }
> 
> 
> diff --git a/gdb/testsuite/gdb.arch/i386-signal.exp
> b/gdb/testsuite/gdb.arch/i386-signal.exp
> index 9e7976b5a275..35096076d6f4 100644
> --- a/gdb/testsuite/gdb.arch/i386-signal.exp
> +++ b/gdb/testsuite/gdb.arch/i386-signal.exp
> @@ -27,7 +27,7 @@ lappend opts additional_flags=-
> DIS_AMD64_REGS_TARGET=[is_amd64_regs_target]
>  if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" \
>  	  executable $opts] != "" } {
>      untested "failed to compile"
> -    return -1
> +    return
>  }
> 
>  clean_restart $::testfile
> diff --git a/gdb/testsuite/gdb.arch/i386-size-overlap.exp
> b/gdb/testsuite/gdb.arch/i386-size-overlap.exp
> index ccc1d56e6dbc..7991dc9cfc8a 100644
> --- a/gdb/testsuite/gdb.arch/i386-size-overlap.exp
> +++ b/gdb/testsuite/gdb.arch/i386-size-overlap.exp
> @@ -27,7 +27,7 @@ set additional_flags [gdb_target_symbol_prefix_flags]
> if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" \
>  	  executable [list debug $additional_flags]] != "" } {
>      untested "failed to compile"
> -    return -1
> +    return
>  }
> 
>  clean_restart $::testfile
> diff --git a/gdb/testsuite/gdb.arch/i386-size.exp
> b/gdb/testsuite/gdb.arch/i386-size.exp
> index 0b2b2a3c3bda..723a96a3673f 100644
> --- a/gdb/testsuite/gdb.arch/i386-size.exp
> +++ b/gdb/testsuite/gdb.arch/i386-size.exp
> @@ -32,7 +32,7 @@ set additional_flags [gdb_target_symbol_prefix_flags]
> if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" \
>  	  executable [list debug $additional_flags]] != "" } {
>      untested "i386-size"
> -    return -1
> +    return
>  }
> 
>  clean_restart $::testfile
> diff --git a/gdb/testsuite/gdb.arch/i386-sse-stack-align.exp
> b/gdb/testsuite/gdb.arch/i386-sse-stack-align.exp
> index 60b83b525fd5..8732279fc28a 100644
> --- a/gdb/testsuite/gdb.arch/i386-sse-stack-align.exp
> +++ b/gdb/testsuite/gdb.arch/i386-sse-stack-align.exp
> @@ -29,13 +29,13 @@ if {[info exists COMPILE]} {
> 
>  if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable
> $opts] != "" } {
>      unsupported "failed to compile"
> -    return -1
> +    return
>  }
> 
>  clean_restart $executable
> 
>  if {![runto_main]} {
> -    return -1
> +    return
>  }
> 
>  set args ""
> diff --git a/gdb/testsuite/gdb.arch/i386-stap-eval-lang-ada.exp
> b/gdb/testsuite/gdb.arch/i386-stap-eval-lang-ada.exp
> index 21beeb400054..63b3ef17adb2 100644
> --- a/gdb/testsuite/gdb.arch/i386-stap-eval-lang-ada.exp
> +++ b/gdb/testsuite/gdb.arch/i386-stap-eval-lang-ada.exp
> @@ -19,13 +19,13 @@ standard_testfile ".S"
>  require is_x86_like_target
> 
>  if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } {
> -    return -1
> +    return
>  }
> 
>  gdb_test_no_output "set language ada"
> 
>  if { ![runto "-pstap bar"] } {
> -    return -1
> +    return
>  }
> 
>  gdb_test "print \$_probe_arg0" " = 40" \ diff --git
> a/gdb/testsuite/gdb.arch/i386-unwind.exp b/gdb/testsuite/gdb.arch/i386-
> unwind.exp
> index 8f522308fe46..7d816aa2ec5c 100644
> --- a/gdb/testsuite/gdb.arch/i386-unwind.exp
> +++ b/gdb/testsuite/gdb.arch/i386-unwind.exp
> @@ -30,7 +30,7 @@ set additional_flags [gdb_target_symbol_prefix_flags]
> 
>  if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable [list
> debug $additional_flags]] != "" } {
>      untested "failed to compile"
> -    return -1
> +    return
>  }
> 
>  clean_restart $::testfile
> diff --git a/gdb/testsuite/gdb.arch/ia64-breakpoint-shadow.exp
> b/gdb/testsuite/gdb.arch/ia64-breakpoint-shadow.exp
> index e206c07cefef..7c746c12e294 100644
> --- a/gdb/testsuite/gdb.arch/ia64-breakpoint-shadow.exp
> +++ b/gdb/testsuite/gdb.arch/ia64-breakpoint-shadow.exp
> @@ -20,7 +20,7 @@ set srcfile ${testfile}.S  set binfile
> ${objdir}/${subdir}/${testfile}  if  { [gdb_compile
> "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
>      untested "failed to compile"
> -    return -1
> +    return
>  }
> 
>  clean_restart
> @@ -28,7 +28,7 @@ gdb_load $binfile
> 
>  # We need to start the inferior to place the breakpoints in the memory at all.
>  if {![runto_main]} {
> -    return -1
> +    return
>  }
> 
>  # The default "auto" mode removes all the breakpoints when we stop (and
> not @@ -55,7 +55,7 @@ gdb_test_multiple "b bundle" $test {  }
> 
>  if {![info exists bpt2address]} {
> -    return -1
> +    return
>  }
> 
>  gdb_test "b *($bpt2address + 1)" "Breakpoint \[0-9\] at .*" "slot 1 breakpoint
> placed"
> diff --git a/gdb/testsuite/gdb.arch/x86-avx512bf16.exp
> b/gdb/testsuite/gdb.arch/x86-avx512bf16.exp
> index cebea7c3b620..08d4849bae20 100644
> --- a/gdb/testsuite/gdb.arch/x86-avx512bf16.exp
> +++ b/gdb/testsuite/gdb.arch/x86-avx512bf16.exp
> @@ -23,11 +23,11 @@ require allow_avx512bf16_tests  standard_testfile
> 
>  if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } {
> -    return -1
> +    return
>  }
> 
>  if { ![runto_main] } {
> -    return -1
> +    return
>  }
> 
>  # Test xmm
> diff --git a/gdb/testsuite/gdb.arch/x86-avx512fp16-abi.exp
> b/gdb/testsuite/gdb.arch/x86-avx512fp16-abi.exp
> index 4b2e3e547e88..6adff2155313 100644
> --- a/gdb/testsuite/gdb.arch/x86-avx512fp16-abi.exp
> +++ b/gdb/testsuite/gdb.arch/x86-avx512fp16-abi.exp
> @@ -21,11 +21,11 @@ standard_testfile
> 
>  if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \
>       {debug additional_flags="-mavx512fp16"}] } {
> -    return -1
> +    return
>  }
> 
>  if { ![runto_main] } {
> -    return -1
> +    return
>  }
> 
>  gdb_test "p square(2.2)" "= 4\\.8359"
> diff --git a/gdb/testsuite/gdb.arch/x86-avx512fp16.exp
> b/gdb/testsuite/gdb.arch/x86-avx512fp16.exp
> index 2d3ab6814c35..e99ec13f7d0e 100644
> --- a/gdb/testsuite/gdb.arch/x86-avx512fp16.exp
> +++ b/gdb/testsuite/gdb.arch/x86-avx512fp16.exp
> @@ -20,11 +20,11 @@ require allow_avx512fp16_tests  standard_testfile
> 
>  if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } {
> -    return -1
> +    return
>  }
> 
>  if { ![runto_main] } {
> -    return -1
> +    return
>  }
> 
>  # Test xmm.

In other areas of this series, you fix the "return 0" lines, too.
But it seems for this area that there are some "return 0" lines missing, for instance in i386-avx.exp.
Would you mind creating a separate patch ?
Or you can also merge it in this one, both is fine for me if you mention that in the commit message.

Besides that, I checked this patch and it looks good to me.

But I would avoid "intel" in the commit message, since x86, amd64, i386 is not Intel‑only.

What about simply writing it out:  "x86, amd64, i386" ?

Christina

Intel Deutschland GmbH
Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany
Tel: +49 89 991 430, www.intel.de
Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
Chairperson of the Supervisory Board: Nicole Lau
Registered Seat: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

  reply	other threads:[~2026-04-28 15:54 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27  6:34 [PATCH 00/36] GDB: testsuite: Fix top-level returns Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 01/36] GDB: testsuite: aarch64, arm: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 02/36] GDB: testsuite: aarch64, arm: Don't return -1 from top-level (manual) Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 03/36] GDB: testsuite: intel: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-28 15:54   ` Schimpe, Christina [this message]
2026-04-28 16:42     ` Schimpe, Christina
2026-04-27  6:34 ` [PATCH 04/36] GDB: testsuite: intel: Don't return -1 from top-level (manual) Thiago Jung Bauermann
2026-04-28 16:39   ` Schimpe, Christina
2026-04-28 21:48     ` Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 05/36] GDB: testsuite: powerpc: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 06/36] GDB: testsuite: powerpc: Don't return -1 from top-level (manual) Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 07/36] GDB: testsuite: riscv: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 08/36] GDB: testsuite: riscv: Don't return -1 from top-level (manual) Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 09/36] GDB: testsuite: s390: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 10/36] GDB: testsuite: sparc: " Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 11/36] GDB: testsuite: Don't return -1 from top-level in tests of various arches Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 12/36] GDB: testsuite: Don't return -1 from top-level in multi-arch tests Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 13/36] GDB: testsuite: base: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 14/36] GDB: testsuite: base: Don't return 0 " Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 15/36] GDB: testsuite: base: Don't return -1 from top-level (manual) Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 16/36] GDB: testsuite: C++: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 17/36] GDB: testsuite: C++: Don't return -1 from top-level (manual) Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 18/36] GDB: testsuite: DWARF: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 19/36] GDB: testsuite: DWARF: Don't return -1 from top-level (manual) Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 20/36] GDB: testsuite: GDB: Don't return -1 from top-level Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 21/36] GDB: testsuite: Guile: " Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 22/36] GDB: testsuite: Python: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 23/36] GDB: testsuite: Python: Don't return -1 from top-level (manual) Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 24/36] GDB: testsuite: linespec: Don't return -1 from top-level Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 25/36] GDB: testsuite: MI: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 26/36] GDB: testsuite: MI: Don't return -1 from top-level (manual) Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 27/36] GDB: testsuite: reverse: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 28/36] GDB: testsuite: reverse: Don't return -1 from top-level (manual) Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 29/36] GDB: testsuite: server: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 30/36] GDB: testsuite: server: Don't return -1 from top-level (manual) Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 31/36] GDB: testsuite: threads: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 32/36] GDB: testsuite: threads: Don't return 0 " Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 33/36] GDB: testsuite: threads: Don't return -1 from top-level (manual) Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 34/36] GDB: testsuite: TUI: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-27  6:34 ` [PATCH 35/36] GDB: testsuite: TUI: Don't return 0 from top-level (manual) Thiago Jung Bauermann
2026-04-27  6:35 ` [PATCH 36/36] GDB: testsuite: XML: Don't return -1 nor 0 from top-level Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN7PR11MB76385D98EEF72ECE6F36411EF9372@SN7PR11MB7638.namprd11.prod.outlook.com \
    --to=christina.schimpe@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=thiago.bauermann@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox