From: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
To: gdb-patches@sourceware.org
Subject: [PATCH 34/36] GDB: testsuite: TUI: Don't return -1 from top-level (sed)
Date: Mon, 27 Apr 2026 03:34:58 -0300 [thread overview]
Message-ID: <20260427063500.3847618-35-thiago.bauermann@linaro.org> (raw)
In-Reply-To: <20260427063500.3847618-1-thiago.bauermann@linaro.org>
This patch is purely the result of running:
$ sed -i 's/^ return -1/ return/' *.exp*
inside gdb/testsuite/gdb.tui.
---
gdb/testsuite/gdb.tui/basic.exp | 2 +-
gdb/testsuite/gdb.tui/break.exp | 2 +-
gdb/testsuite/gdb.tui/compact-source.exp | 2 +-
gdb/testsuite/gdb.tui/corefile-run.exp | 6 +++---
gdb/testsuite/gdb.tui/flush-after-run.exp | 2 +-
gdb/testsuite/gdb.tui/list-before.exp | 2 +-
gdb/testsuite/gdb.tui/list.exp | 2 +-
gdb/testsuite/gdb.tui/main-2.exp | 2 +-
gdb/testsuite/gdb.tui/main.exp | 2 +-
gdb/testsuite/gdb.tui/new-layout.exp | 2 +-
gdb/testsuite/gdb.tui/regs.exp | 2 +-
gdb/testsuite/gdb.tui/reread.exp | 2 +-
gdb/testsuite/gdb.tui/resize-3.exp | 2 +-
gdb/testsuite/gdb.tui/resize-one-line.exp | 2 +-
gdb/testsuite/gdb.tui/resize.exp | 2 +-
gdb/testsuite/gdb.tui/scroll.exp | 2 +-
gdb/testsuite/gdb.tui/tui-focus.exp | 2 +-
gdb/testsuite/gdb.tui/tui-init-source.exp | 2 +-
gdb/testsuite/gdb.tui/tui-layout-asm-short-prog.exp | 2 +-
gdb/testsuite/gdb.tui/tui-layout-asm.exp | 2 +-
gdb/testsuite/gdb.tui/tui-layout.exp | 2 +-
gdb/testsuite/gdb.tui/winheight.exp | 2 +-
gdb/testsuite/gdb.tui/winwidth.exp | 2 +-
23 files changed, 25 insertions(+), 25 deletions(-)
diff --git a/gdb/testsuite/gdb.tui/basic.exp b/gdb/testsuite/gdb.tui/basic.exp
index 7909cea674d6..26264082a163 100644
--- a/gdb/testsuite/gdb.tui/basic.exp
+++ b/gdb/testsuite/gdb.tui/basic.exp
@@ -24,7 +24,7 @@ standard_testfile main-one-line.c
set main_line [gdb_get_line_number "int main"]
if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} {
- return -1
+ return
}
Term::clean_restart 24 80 $testfile
diff --git a/gdb/testsuite/gdb.tui/break.exp b/gdb/testsuite/gdb.tui/break.exp
index 4e07a0c0b691..154ca40b69fa 100644
--- a/gdb/testsuite/gdb.tui/break.exp
+++ b/gdb/testsuite/gdb.tui/break.exp
@@ -20,7 +20,7 @@ tuiterm_env
standard_testfile tui-layout.c
if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} {
- return -1
+ return
}
Term::clean_restart 24 80 $testfile
diff --git a/gdb/testsuite/gdb.tui/compact-source.exp b/gdb/testsuite/gdb.tui/compact-source.exp
index 9f41a160b3f4..e9478bbeb863 100644
--- a/gdb/testsuite/gdb.tui/compact-source.exp
+++ b/gdb/testsuite/gdb.tui/compact-source.exp
@@ -38,7 +38,7 @@ puts $fd $src_txt
close $fd
if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} {
- return -1
+ return
}
Term::clean_restart 24 80 $testfile
diff --git a/gdb/testsuite/gdb.tui/corefile-run.exp b/gdb/testsuite/gdb.tui/corefile-run.exp
index 7e1184ecf040..1361e4a7f6de 100644
--- a/gdb/testsuite/gdb.tui/corefile-run.exp
+++ b/gdb/testsuite/gdb.tui/corefile-run.exp
@@ -27,19 +27,19 @@ standard_testfile tui-layout.c
set core [standard_output_file "${testfile}.core"]
if { [prepare_for_testing "failed to prepare" $testfile $srcfile debug] } {
- return -1
+ return
}
# Only run on native boards.
require {target_can_use_run_cmd core}
if { ![runto_main] } {
- return -1
+ return
}
if { ![gdb_gcore_cmd "$core" "save a corefile"] } {
untested "could not generate a corefile"
- return -1
+ return
}
set src_line "return 0;"
diff --git a/gdb/testsuite/gdb.tui/flush-after-run.exp b/gdb/testsuite/gdb.tui/flush-after-run.exp
index ecc2caafc33d..db20b8cee80b 100644
--- a/gdb/testsuite/gdb.tui/flush-after-run.exp
+++ b/gdb/testsuite/gdb.tui/flush-after-run.exp
@@ -24,7 +24,7 @@ tuiterm_env
standard_testfile
if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} {
- return -1
+ return
}
Term::clean_restart 24 80 $testfile
diff --git a/gdb/testsuite/gdb.tui/list-before.exp b/gdb/testsuite/gdb.tui/list-before.exp
index 55485aa5629c..5d3cef954d49 100644
--- a/gdb/testsuite/gdb.tui/list-before.exp
+++ b/gdb/testsuite/gdb.tui/list-before.exp
@@ -20,7 +20,7 @@ tuiterm_env
standard_testfile tui-layout.c
if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} {
- return -1
+ return
}
Term::clean_restart 24 80 $testfile
diff --git a/gdb/testsuite/gdb.tui/list.exp b/gdb/testsuite/gdb.tui/list.exp
index de58afa53e1a..5cefebc7e016 100644
--- a/gdb/testsuite/gdb.tui/list.exp
+++ b/gdb/testsuite/gdb.tui/list.exp
@@ -20,7 +20,7 @@ tuiterm_env
standard_testfile tui-layout.c
if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} {
- return -1
+ return
}
Term::clean_restart 24 80 $testfile
diff --git a/gdb/testsuite/gdb.tui/main-2.exp b/gdb/testsuite/gdb.tui/main-2.exp
index 1b8068e3a361..9b3b38645b0f 100644
--- a/gdb/testsuite/gdb.tui/main-2.exp
+++ b/gdb/testsuite/gdb.tui/main-2.exp
@@ -23,7 +23,7 @@ tuiterm_env
standard_testfile tui-layout.c
if { [build_executable "failed to prepare" $testfile $srcfile ] == -1} {
- return -1
+ return
}
Term::clean_restart 24 80 $testfile
diff --git a/gdb/testsuite/gdb.tui/main.exp b/gdb/testsuite/gdb.tui/main.exp
index 5bc6b91cdee4..d8a9c8eebe85 100644
--- a/gdb/testsuite/gdb.tui/main.exp
+++ b/gdb/testsuite/gdb.tui/main.exp
@@ -22,7 +22,7 @@ tuiterm_env
standard_testfile tui-layout.c
if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} {
- return -1
+ return
}
# Note: don't pass the executable here
diff --git a/gdb/testsuite/gdb.tui/new-layout.exp b/gdb/testsuite/gdb.tui/new-layout.exp
index f293773f9d15..e544ef6fd90a 100644
--- a/gdb/testsuite/gdb.tui/new-layout.exp
+++ b/gdb/testsuite/gdb.tui/new-layout.exp
@@ -20,7 +20,7 @@ tuiterm_env
standard_testfile tui-layout.c
if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} {
- return -1
+ return
}
# Make sure TUI is supported before continuing.
diff --git a/gdb/testsuite/gdb.tui/regs.exp b/gdb/testsuite/gdb.tui/regs.exp
index 3c524ad49a70..8169538da85c 100644
--- a/gdb/testsuite/gdb.tui/regs.exp
+++ b/gdb/testsuite/gdb.tui/regs.exp
@@ -20,7 +20,7 @@ tuiterm_env
standard_testfile tui-layout.c
if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} {
- return -1
+ return
}
Term::clean_restart 24 80 $testfile
diff --git a/gdb/testsuite/gdb.tui/reread.exp b/gdb/testsuite/gdb.tui/reread.exp
index de35fef744cd..3ed0839e1c83 100644
--- a/gdb/testsuite/gdb.tui/reread.exp
+++ b/gdb/testsuite/gdb.tui/reread.exp
@@ -23,7 +23,7 @@ tuiterm_env
standard_testfile main-one-line.c
if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} {
- return -1
+ return
}
Term::clean_restart 24 80 $testfile
diff --git a/gdb/testsuite/gdb.tui/resize-3.exp b/gdb/testsuite/gdb.tui/resize-3.exp
index d9e0948a9a80..fdaffe006419 100644
--- a/gdb/testsuite/gdb.tui/resize-3.exp
+++ b/gdb/testsuite/gdb.tui/resize-3.exp
@@ -23,7 +23,7 @@ if { [build_executable_from_specs "failed to prepare" \
$testfile {debug} \
$srcfile {debug} \
$srcfile2 {nodebug}] == -1 } {
- return -1
+ return
}
tuiterm_env
diff --git a/gdb/testsuite/gdb.tui/resize-one-line.exp b/gdb/testsuite/gdb.tui/resize-one-line.exp
index f5e2858b05d2..0a47dcf0e7f8 100644
--- a/gdb/testsuite/gdb.tui/resize-one-line.exp
+++ b/gdb/testsuite/gdb.tui/resize-one-line.exp
@@ -22,7 +22,7 @@ tuiterm_env
standard_testfile main-one-line.c
if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} {
- return -1
+ return
}
Term::clean_restart 24 80 $testfile
diff --git a/gdb/testsuite/gdb.tui/resize.exp b/gdb/testsuite/gdb.tui/resize.exp
index 93918f3b3560..25f52c6a5b8e 100644
--- a/gdb/testsuite/gdb.tui/resize.exp
+++ b/gdb/testsuite/gdb.tui/resize.exp
@@ -20,7 +20,7 @@ tuiterm_env
standard_testfile tui-layout.c
if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} {
- return -1
+ return
}
Term::clean_restart 24 80 $testfile
diff --git a/gdb/testsuite/gdb.tui/scroll.exp b/gdb/testsuite/gdb.tui/scroll.exp
index e9fa829f40ec..0162cfd8db7b 100644
--- a/gdb/testsuite/gdb.tui/scroll.exp
+++ b/gdb/testsuite/gdb.tui/scroll.exp
@@ -24,7 +24,7 @@ tuiterm_env
standard_testfile tui-layout.c
if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} {
- return -1
+ return
}
Term::clean_restart 24 80 $testfile
diff --git a/gdb/testsuite/gdb.tui/tui-focus.exp b/gdb/testsuite/gdb.tui/tui-focus.exp
index 5df76b59b864..310b3a473206 100644
--- a/gdb/testsuite/gdb.tui/tui-focus.exp
+++ b/gdb/testsuite/gdb.tui/tui-focus.exp
@@ -23,7 +23,7 @@ load_lib gdb-python.exp
standard_testfile
if {[prepare_for_testing "failed to prepare" ${testfile} ${srcfile}]} {
- return -1
+ return
}
# Run a series of tests based on various test specifications.
diff --git a/gdb/testsuite/gdb.tui/tui-init-source.exp b/gdb/testsuite/gdb.tui/tui-init-source.exp
index edd364e05b12..f49b0ecdcbdb 100644
--- a/gdb/testsuite/gdb.tui/tui-init-source.exp
+++ b/gdb/testsuite/gdb.tui/tui-init-source.exp
@@ -23,7 +23,7 @@ tuiterm_env
standard_testfile
if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} {
- return -1
+ return
}
Term::clean_restart 24 80 $testfile
diff --git a/gdb/testsuite/gdb.tui/tui-layout-asm-short-prog.exp b/gdb/testsuite/gdb.tui/tui-layout-asm-short-prog.exp
index e54ae69997ed..b3dd72ce1ceb 100644
--- a/gdb/testsuite/gdb.tui/tui-layout-asm-short-prog.exp
+++ b/gdb/testsuite/gdb.tui/tui-layout-asm-short-prog.exp
@@ -27,7 +27,7 @@ lappend opts additional_flags=-nostdlib
lappend opts ldflags=-nostartfiles
if { [build_executable "failed to prepare" $testfile $srcfile $opts] == -1 } {
- return -1
+ return
}
Term::clean_restart 24 80 $testfile
diff --git a/gdb/testsuite/gdb.tui/tui-layout-asm.exp b/gdb/testsuite/gdb.tui/tui-layout-asm.exp
index bbaa4f9b846f..01193b6fb44b 100644
--- a/gdb/testsuite/gdb.tui/tui-layout-asm.exp
+++ b/gdb/testsuite/gdb.tui/tui-layout-asm.exp
@@ -21,7 +21,7 @@ tuiterm_env
standard_testfile tui-layout.c
if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} {
- return -1
+ return
}
# The wider the window is, the less line truncation happens, so matching
diff --git a/gdb/testsuite/gdb.tui/tui-layout.exp b/gdb/testsuite/gdb.tui/tui-layout.exp
index 05ca3b450290..1cb70504e3f8 100644
--- a/gdb/testsuite/gdb.tui/tui-layout.exp
+++ b/gdb/testsuite/gdb.tui/tui-layout.exp
@@ -23,7 +23,7 @@ tuiterm_env
standard_testfile
if {[prepare_for_testing "failed to prepare" ${testfile} ${srcfile}]} {
- return -1
+ return
}
# Run one test of the 'layout' command, selecting LAYOUT_NAME.
diff --git a/gdb/testsuite/gdb.tui/winheight.exp b/gdb/testsuite/gdb.tui/winheight.exp
index 758f23d8f723..9daf08916af8 100644
--- a/gdb/testsuite/gdb.tui/winheight.exp
+++ b/gdb/testsuite/gdb.tui/winheight.exp
@@ -20,7 +20,7 @@ tuiterm_env
standard_testfile tui-layout.c
if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} {
- return -1
+ return
}
Term::clean_restart 24 80 $testfile
diff --git a/gdb/testsuite/gdb.tui/winwidth.exp b/gdb/testsuite/gdb.tui/winwidth.exp
index a18ff4edba1f..cc6c7dcd1536 100644
--- a/gdb/testsuite/gdb.tui/winwidth.exp
+++ b/gdb/testsuite/gdb.tui/winwidth.exp
@@ -20,7 +20,7 @@ tuiterm_env
standard_testfile tui-layout.c
if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} {
- return -1
+ return
}
Term::clean_restart 24 80 $testfile
next prev parent reply other threads:[~2026-04-27 6:41 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 6:34 [PATCH 00/36] GDB: testsuite: Fix top-level returns Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 01/36] GDB: testsuite: aarch64, arm: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 02/36] GDB: testsuite: aarch64, arm: Don't return -1 from top-level (manual) Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 03/36] GDB: testsuite: intel: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-28 15:54 ` Schimpe, Christina
2026-04-28 16:42 ` Schimpe, Christina
2026-04-27 6:34 ` [PATCH 04/36] GDB: testsuite: intel: Don't return -1 from top-level (manual) Thiago Jung Bauermann
2026-04-28 16:39 ` Schimpe, Christina
2026-04-28 21:48 ` Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 05/36] GDB: testsuite: powerpc: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 06/36] GDB: testsuite: powerpc: Don't return -1 from top-level (manual) Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 07/36] GDB: testsuite: riscv: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 08/36] GDB: testsuite: riscv: Don't return -1 from top-level (manual) Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 09/36] GDB: testsuite: s390: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 10/36] GDB: testsuite: sparc: " Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 11/36] GDB: testsuite: Don't return -1 from top-level in tests of various arches Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 12/36] GDB: testsuite: Don't return -1 from top-level in multi-arch tests Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 13/36] GDB: testsuite: base: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 14/36] GDB: testsuite: base: Don't return 0 " Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 15/36] GDB: testsuite: base: Don't return -1 from top-level (manual) Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 16/36] GDB: testsuite: C++: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 17/36] GDB: testsuite: C++: Don't return -1 from top-level (manual) Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 18/36] GDB: testsuite: DWARF: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 19/36] GDB: testsuite: DWARF: Don't return -1 from top-level (manual) Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 20/36] GDB: testsuite: GDB: Don't return -1 from top-level Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 21/36] GDB: testsuite: Guile: " Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 22/36] GDB: testsuite: Python: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 23/36] GDB: testsuite: Python: Don't return -1 from top-level (manual) Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 24/36] GDB: testsuite: linespec: Don't return -1 from top-level Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 25/36] GDB: testsuite: MI: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 26/36] GDB: testsuite: MI: Don't return -1 from top-level (manual) Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 27/36] GDB: testsuite: reverse: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 28/36] GDB: testsuite: reverse: Don't return -1 from top-level (manual) Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 29/36] GDB: testsuite: server: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 30/36] GDB: testsuite: server: Don't return -1 from top-level (manual) Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 31/36] GDB: testsuite: threads: Don't return -1 from top-level (sed) Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 32/36] GDB: testsuite: threads: Don't return 0 " Thiago Jung Bauermann
2026-04-27 6:34 ` [PATCH 33/36] GDB: testsuite: threads: Don't return -1 from top-level (manual) Thiago Jung Bauermann
2026-04-27 6:34 ` Thiago Jung Bauermann [this message]
2026-04-27 6:34 ` [PATCH 35/36] GDB: testsuite: TUI: Don't return 0 " Thiago Jung Bauermann
2026-04-27 6:35 ` [PATCH 36/36] GDB: testsuite: XML: Don't return -1 nor 0 from top-level Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260427063500.3847618-35-thiago.bauermann@linaro.org \
--to=thiago.bauermann@linaro.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox