RE: [PATCH 32 0/2] Handle the new .note section introduced in Linux

["Schimpe, Christina" <christina.schimpe@intel.com>]

Hi Vignesh, 

Is this series regression tested ? On my system with old linux kernel (5.15) gdb hangs if I load a corefile that I generated with gcore.

And it might be a good idea to check the patches formatting we have several options:

- Clang-format: https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=.clang-format;h=fd4f2d951e22b78f6228fdd16d2138a69a472eaa;hb=refs/heads/master
- GNU style script together with a pre-commit hook:
https://github.com/gcc-mirror/gcc/blob/master/contrib/check_GNU_style.sh
https://pre-commit.com/

Christina

> -----Original Message-----
> From: Vignesh Balasubramanian <vigbalas@amd.com>
> Sent: Montag, 8. Dezember 2025 09:38
> To: gdb-patches@sourceware.org; jinisusan.george@amd.com; Schimpe,
> Christina <christina.schimpe@intel.com>; AlokKumar.Sharma@amd.com;
> jhb@FreeBSD.org; simark@simark.ca
> Cc: Vignesh Balasubramanian <vigbalas@amd.com>
> Subject: [PATCH 32 0/2] Handle the new .note section introduced in Linux
> 
> The XSAVE layout of the machine where the core file is dumped is not visible to
> GDB. It is assumed currently using some heuristics.
> 
> It has been addressed to some extent recently but still uses heuristics.
> https://inbox.sourceware.org/gdb-patches/2628f45a-77f7-8b2c-20aa-
> da65d1d82a37@simark.ca/T/#m4c67d59c18a5962f771ba8ca1e2bee9365ad1
> ab2
> 
> New patches have been committed to the linux kernel (version 6.12) to resolve
> this issue by adding a new .note section which contains descriptions of the
> xsave layout to the core file.
> 
> The first of this patch set consumes this new .note section and uses that to
> identify the xsave layout.
> The second one enables gdb to generate a similar .note section if the corefile is
> dumped through the 'gcore' command.
> 
> Working on test case patch, will share it in a few days.
> 
> This patch shoud be applied on top of binutils patch:
> https://sourceware.org/pipermail/binutils/2025-September/144207.html
> 
> Co-Authored-By: Jini Susan George <jinisusan.george@amd.com>
> 
> Vignesh Balasubramanian (2):
>   core: Consume the new .note section that contains descriptions of
>     xsave layout
>   gcore: Create a new .note section for x86
> 
>  gdb/amd64-linux-tdep.c     |  2 +-
>  gdb/gcore-elf.c            | 18 ++++++++
>  gdb/gcore-elf.h            |  8 ++++
>  gdb/i386-linux-tdep.c      | 25 ++++++++---
>  gdb/i386-linux-tdep.h      |  3 +-
>  gdb/i387-tdep.c            | 86 ++++++++++++++++++++++++++++++++++++++
>  gdb/i387-tdep.h            | 12 ++++++
>  gdb/linux-tdep.c           |  1 +
>  gdb/nat/x86-xstate.c       | 31 ++++++++++++++
>  gdb/nat/x86-xstate.h       |  6 +++
>  gdb/target-debug.h         |  6 +++
>  gdb/target-delegates-gen.c | 26 ++++++++++++
>  gdb/target.c               |  5 +++
>  gdb/target.h               | 10 +++++
>  gdb/x86-linux-nat.c        |  6 +++
>  gdb/x86-linux-nat.h        |  1 +
>  gdbsupport/x86-xstate.h    |  6 +++
>  17 files changed, 244 insertions(+), 8 deletions(-)
> 
> --
> 2.34.1

Intel Deutschland GmbH
Registered Address: Dornacher Straße 1, 85622 Feldkirchen, Germany
Tel: +49 89 991 430, www.intel.de
Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
Chairperson of the Supervisory Board: Nicole Lau
Registered Seat: Munich
Commercial Register: Amtsgericht München HRB 186928