Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Schimpe, Christina" <christina.schimpe@intel.com>
To: Vignesh Balasubramanian <vigbalas@amd.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	"jinisusan.george@amd.com" <jinisusan.george@amd.com>,
	"AlokKumar.Sharma@amd.com" <AlokKumar.Sharma@amd.com>,
	"jhb@FreeBSD.org" <jhb@FreeBSD.org>,
	"simark@simark.ca" <simark@simark.ca>
Subject: RE: [PATCH 32 0/2] Handle the new .note section introduced in Linux
Date: Sun, 14 Dec 2025 13:39:12 +0000	[thread overview]
Message-ID: <SN7PR11MB76384822431D85238D8B5165F9ACA@SN7PR11MB7638.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20251208083819.2560894-1-vigbalas@amd.com>

Hi Vignesh, 

I'll review the patches once we have clarified the opens for the test. Please see my comment below.

> -----Original Message-----
> From: Vignesh Balasubramanian <vigbalas@amd.com>
> Sent: Montag, 8. Dezember 2025 09:38
> To: gdb-patches@sourceware.org; jinisusan.george@amd.com; Schimpe,
> Christina <christina.schimpe@intel.com>; AlokKumar.Sharma@amd.com;
> jhb@FreeBSD.org; simark@simark.ca
> Cc: Vignesh Balasubramanian <vigbalas@amd.com>
> Subject: [PATCH 32 0/2] Handle the new .note section introduced in Linux
> 
> The XSAVE layout of the machine where the core file is dumped is not visible
> to GDB. It is assumed currently using some heuristics.
> 
> It has been addressed to some extent recently but still uses heuristics.
> https://inbox.sourceware.org/gdb-patches/2628f45a-77f7-8b2c-20aa-
> da65d1d82a37@simark.ca/T/#m4c67d59c18a5962f771ba8ca1e2bee9365ad
> 1ab2
> 
> New patches have been committed to the linux kernel (version 6.12) to
> resolve this issue by adding a new .note section which contains descriptions
> of the xsave layout to the core file.
> 
> The first of this patch set consumes this new .note section and uses that to
> identify the xsave layout.
> The second one enables gdb to generate a similar .note section if the corefile
> is dumped through the 'gcore' command.
> 
> Working on test case patch, will share it in a few days.

In the gdb testsuite we already have tests for (g)core commands and for OS generated corefiles.

Based on the test that you shared initially
https://sourceware.org/pipermail/gdb-patches/2025-July/219369.html
I wonder what your test will cover that is not tested already with existing tests.

Would it be sufficient to extend the existing tests in case a linux kernel >= 6.12 is used ?

Christina

Intel Deutschland GmbH
Registered Address: Dornacher Straße 1, 85622 Feldkirchen, Germany
Tel: +49 89 991 430, www.intel.de
Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
Chairperson of the Supervisory Board: Nicole Lau
Registered Seat: Munich
Commercial Register: Amtsgericht München HRB 186928

  parent reply	other threads:[~2025-12-14 13:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-08  8:38 Vignesh Balasubramanian
2025-12-08  8:38 ` [PATCH 32 1/2] core: Consume the new .note section that contains descriptions of xsave layout Vignesh Balasubramanian
2025-12-08  8:38 ` [PATCH 32 2/2] gcore: Create a new .note section for x86 Vignesh Balasubramanian
2025-12-14 13:39 ` Schimpe, Christina [this message]
2026-01-06  6:48   ` [PATCH 32 0/2] Handle the new .note section introduced in Linux Balasubrmanian, Vignesh
2026-03-06  7:08     ` Schimpe, Christina
2026-03-06  7:42       ` Balasubrmanian, Vignesh
2026-03-06  8:13         ` Schimpe, Christina
2026-03-11  9:50           ` Schimpe, Christina
2026-03-13 14:08             ` Schimpe, Christina
2026-03-17 10:02               ` Schimpe, Christina
2026-02-08  4:18   ` Vignesh Balasubramanian
2026-03-16 12:59 ` [PATCH 32 0/2] Handle the new .note section introduced in Linux Schimpe, Christina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN7PR11MB76384822431D85238D8B5165F9ACA@SN7PR11MB7638.namprd11.prod.outlook.com \
    --to=christina.schimpe@intel.com \
    --cc=AlokKumar.Sharma@amd.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jhb@FreeBSD.org \
    --cc=jinisusan.george@amd.com \
    --cc=simark@simark.ca \
    --cc=vigbalas@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox