RE: [PATCH v5 08/12] gdb: Handle shadow stack pointer register unwinding for amd64 linux.

["Schimpe, Christina" <christina.schimpe@intel.com>]

Hi Andrew,

Thanks a lot for the review.

> -----Original Message-----
> From: Andrew Burgess <aburgess@redhat.com>
> Sent: Wednesday, July 30, 2025 11:59 AM
> To: Schimpe, Christina <christina.schimpe@intel.com>; gdb-
> patches@sourceware.org
> Cc: thiago.bauermann@linaro.org; luis.machado@arm.com
> Subject: Re: [PATCH v5 08/12] gdb: Handle shadow stack pointer register
> unwinding for amd64 linux.
> 
> Christina Schimpe <christina.schimpe@intel.com> writes:
> 
> > Unwind the $pl3_ssp register.
> > We now have an updated value for the shadow stack pointer when moving
> > up or down the frame level.  Note that $pl3_ssp can become unavailable
> > when moving to a frame before the shadow stack enablement.  In the
> > example below, shadow stack is enabled in the function 'call1'.  Thus,
> > when moving to a frame level above the function, $pl3_ssp will become
> > unavaiable.
> > Following the restriction of the linux kernel, implement the unwinding
> > for amd64 linux only.
> >
> > Before this patch:
> > ~~~
> > Breakpoint 1, call2 (j=3) at sample.c:44
> > 44	  return 42;
> > (gdb) p $pl3_ssp
> > $1 = (void *) 0x7ffff79ffff8
> > (gdb) up
> > 55	  call2 (3);
> > (gdb) p $pl3_ssp
> > $2 = (void *) 0x7ffff79ffff8
> > (gdb) up
> > 68	  call1 (43);
> > (gdb) p $pl3_ssp
> > $3 = (void *) 0x7ffff79ffff8
> > ~~~
> >
> > After this patch:
> > ~~~
> > Breakpoint 1, call2 (j=3) at sample.c:44
> > 44	  return 42;
> > (gdb) p $pl3_ssp
> > $1 = (void *) 0x7ffff79ffff8
> > (gdb) up
> > 55	  call2 (3);
> > (gdb) p $pl3_ssp
> > $2 = (void *) 0x7ffff7a00000
> > (gdb) up
> > 68	  call1 (43i);
> > (gdb) p $pl3_ssp
> > $3 = <unavailable>
> > ~~~
> >
> > As we now have an updated value for each selected frame, the return
> > command is now enabled for shadow stack enabled programs, too.
> >
> > We therefore add a test for the return command and shadow stack
> > support, and for an updated shadow stack pointer after a frame level
> change.
> >
> > Reviewed-by: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
> > Reviewed-By: Luis Machado <luis.machado@arm.com>
> > ---
> >  gdb/amd64-linux-tdep.c                        | 85 ++++++++++++++++++
> >  gdb/linux-tdep.c                              | 47 ++++++++++
> >  gdb/linux-tdep.h                              |  7 ++
> >  .../gdb.arch/amd64-shadow-stack-cmds.exp      | 88
> +++++++++++++++++++
> >  gdb/testsuite/gdb.arch/amd64-shadow-stack.c   | 13 +++
> >  5 files changed, 240 insertions(+)
> >  create mode 100644 gdb/testsuite/gdb.arch/amd64-shadow-stack-
> cmds.exp
> >
> 
> > diff --git a/gdb/testsuite/gdb.arch/amd64-shadow-stack-cmds.exp
> > b/gdb/testsuite/gdb.arch/amd64-shadow-stack-cmds.exp
> > new file mode 100644
> > index 00000000000..17f32ce3964
> > --- /dev/null
> > +++ b/gdb/testsuite/gdb.arch/amd64-shadow-stack-cmds.exp
> > @@ -0,0 +1,88 @@
> > +# Copyright 2018-2024 Free Software Foundation, Inc.
> 
> Is this date range correct?  Or a copy & paste error?  The start date should
> be when the patches were first posted to the list, or otherwise made
> publicly available (e.g. Intel specific GDB release?).  The end date should be
> updated to 2025.

Yes, it should be 2025 for the end date and I'll use 2024 as start date, as I posted
the series in December 2024 for the first time in this list and the patches made were
 available in the Intel specific GDB release in 2024.

Draft versions were available before 2024, but mostly experimental.

I'll also adapt the copyright in test files of the previous patches in the series, so they'll
all have 2024-2025.
 
> With that fixed:
> 
> Approved-By: Andrew Burgess <aburgess@redhat.com>
> 
> Thanks,
> Andrew
> 
> > +
> > +# This program is free software; you can redistribute it and/or
> > +modify # it under the terms of the GNU General Public License as
> > +published by # the Free Software Foundation; either version 3 of the
> > +License, or # (at your option) any later version.
> > +#

Kind Regards,
Christina

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928