From: "Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>
To: Simon Marchi <simark@simark.ca>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH v2 2/3] gdb/jit: return bool in jit_breakpoint_re_set_internal and jit_read_descriptor
Date: Mon, 22 Jun 2020 12:05:14 +0000 [thread overview]
Message-ID: <SN6PR11MB2893F0A55C44C487631F0088C4970@SN6PR11MB2893.namprd11.prod.outlook.com> (raw)
In-Reply-To: <94b61d45-22bd-edd2-495d-8160963d9743@simark.ca>
On Sunday, June 21, 2020 5:44 AM, Simon Marchi wrote:
> On 2020-06-16 5:49 a.m., Tankut Baris Aktemur via Gdb-patches wrote:
> > This is a minor refactoring that converts the return type of
> > jit_read_descriptor and jit_breakpoint_re_set_internal functions
> > from 'int' to 'bool'.
>
> Please mention that you are reversnig the return value logic of jit_breakpoint_re_set_internal,
> otherwise at first glance it can look like a mistake.
>
> Otherwise this LGTM, I think you can push it right away.
>
> Simon
Pushed with that note in the commit message and ChangeLog entry.
Thanks.
-Baris
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2020-06-22 12:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 9:49 [PATCH v2 0/3] Handling multiple JITers Tankut Baris Aktemur
2020-06-16 9:49 ` [PATCH v2 1/3] gdb/jit: pass the jiter objfile as an argument to jit_event_handler Tankut Baris Aktemur
2020-06-16 9:49 ` [PATCH v2 2/3] gdb/jit: return bool in jit_breakpoint_re_set_internal and jit_read_descriptor Tankut Baris Aktemur
2020-06-21 3:43 ` Simon Marchi
2020-06-22 12:05 ` Aktemur, Tankut Baris [this message]
2020-06-16 9:49 ` [PATCH v2 3/3] gdb/jit: enable tracking multiple jitter objfiles Tankut Baris Aktemur
2020-06-21 3:32 ` Simon Marchi
2020-06-22 16:28 ` Pedro Alves
2020-06-22 16:39 ` Simon Marchi
2020-06-22 16:53 ` Aktemur, Tankut Baris
2020-06-22 17:00 ` Simon Marchi
2020-06-23 8:16 ` Aktemur, Tankut Baris
2020-06-22 16:53 ` Pedro Alves
2020-06-22 16:52 ` Aktemur, Tankut Baris
2020-06-30 8:17 ` Aktemur, Tankut Baris
2020-07-03 2:19 ` Simon Marchi
2020-07-03 7:29 ` Aktemur, Tankut Baris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB2893F0A55C44C487631F0088C4970@SN6PR11MB2893.namprd11.prod.outlook.com \
--to=tankut.baris.aktemur@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox