From: Simon Marchi <simark@simark.ca>
To: "Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2 3/3] gdb/jit: enable tracking multiple jitter objfiles
Date: Thu, 2 Jul 2020 22:19:44 -0400 [thread overview]
Message-ID: <1fe7742a-dd3b-dda6-8964-a985703473df@simark.ca> (raw)
In-Reply-To: <SN6PR11MB28936EADACF737FB38A8335CC46F0@SN6PR11MB2893.namprd11.prod.outlook.com>
On 2020-06-30 4:17 a.m., Aktemur, Tankut Baris wrote:
> Hi Simon,
>
> On Sunday, June 21, 2020 5:33 AM, Simon Marchi wrote:
>> Please tell me what you think about this. If you agree with the direction, I could
>> officially post it to the list.
>
> Any plan to post the series these days?
>
> -Baris
Arf, I don't think I'll have time to polish and post it soon :(. If this is on your critical
path, would you mind doing it?
One thing I didn't like and wanted to re-visit before posting is the fact that in
jit_breakpoint_re_set_internal, we always loop over all objfiles. This means that when a new
objfile appears and we call jit_breakpoint_re_set_internal, we look up the magic symbols in all
the previously existing objfiles, even we have already looked them up earlier. If we haven't
found the symbols in a a given objfile before, there's no need to search in that objfile again.
Or maybe that's not really a problem in practice.
Simon
next prev parent reply other threads:[~2020-07-03 2:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 9:49 [PATCH v2 0/3] Handling multiple JITers Tankut Baris Aktemur
2020-06-16 9:49 ` [PATCH v2 1/3] gdb/jit: pass the jiter objfile as an argument to jit_event_handler Tankut Baris Aktemur
2020-06-16 9:49 ` [PATCH v2 2/3] gdb/jit: return bool in jit_breakpoint_re_set_internal and jit_read_descriptor Tankut Baris Aktemur
2020-06-21 3:43 ` Simon Marchi
2020-06-22 12:05 ` Aktemur, Tankut Baris
2020-06-16 9:49 ` [PATCH v2 3/3] gdb/jit: enable tracking multiple jitter objfiles Tankut Baris Aktemur
2020-06-21 3:32 ` Simon Marchi
2020-06-22 16:28 ` Pedro Alves
2020-06-22 16:39 ` Simon Marchi
2020-06-22 16:53 ` Aktemur, Tankut Baris
2020-06-22 17:00 ` Simon Marchi
2020-06-23 8:16 ` Aktemur, Tankut Baris
2020-06-22 16:53 ` Pedro Alves
2020-06-22 16:52 ` Aktemur, Tankut Baris
2020-06-30 8:17 ` Aktemur, Tankut Baris
2020-07-03 2:19 ` Simon Marchi [this message]
2020-07-03 7:29 ` Aktemur, Tankut Baris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fe7742a-dd3b-dda6-8964-a985703473df@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox