RE: [PATCH v11 08/10] gdb, mi: Skip trampoline functions for the -stack-list-frames command.

["Ijaz, Abdul B" <abdul.b.ijaz@intel.com>]

Thanks Tom, for the feedback.

Please see the inline reply below:

>> This change skips trampoline functions for the '-stack-list-frames' 
>> command when the option 'skip-trampoline-functions' is set to 'on'.  
>> Before this change, GDB prints the frames indicated by the compiler 
>> with DIE "DW_AT_trampoline" in the backtrace for mi command 
>> stack-list-frames, but for better user experience, all such frames can be hidden from the user.

Tom> This is another spot where the Python layer seems to already have related functionality.
Tom> It doesn't seem to be documented :-(
Tom> But from py-framefilter.c, it seems to put the elided frames into a "children" element of the parent frame.
Tom> This way the UI can decide for itself what to do.
Tom> Anyway, I wonder whether the new work should perhaps just follow the existing precedent here.

Abdul> This is the same question as for the backtrace command, which we are discussing in the reply to 04/10 ("gdb: Skip trampoline frames for the backtrace command").  The MI -stack-list-* commands will follow whatever we decide there: if trampoline frames become elided frames, they will be reported as "children" of the frame they lead to, as the frame filter code already does for MI.  I will update this patch and the -stack-list-arguments accordingly. 

Best Regards,
Abdul Basit

-----Original Message-----
From: Tom Tromey <tom@tromey.com> 
Sent: Wednesday, October 21, 2026 10:58 PM
To: Ijaz, Abdul B <abdul.b.ijaz@intel.com>
Cc: gdb-patches@sourceware.org; JiniSusan.George@amd.com; tom@tromey.com; eliz@gnu.org
Subject: Re: [PATCH v11 08/10] gdb, mi: Skip trampoline functions for the -stack-list-frames command.

>>>>> Abdul Basit Ijaz <abdul.b.ijaz@intel.com> writes:

> This change skips trampoline functions for the '-stack-list-frames' 
> command when the option 'skip-trampoline-functions' is set to 'on'.  
> Before this change, GDB prints the frames indicated by the compiler 
> with DIE "DW_AT_trampoline" in the backtrace for mi command 
> stack-list-frames, but for better user experience, all such frames can be hidden from the user.

This is another spot where the Python layer seems to already have related functionality.

It doesn't seem to be documented :-(

But from py-framefilter.c, it seems to put the elided frames into a "children" element of the parent frame.

This way the UI can decide for itself what to do.

Anyway, I wonder whether the new work should perhaps just follow the existing precedent here.

There's a similar issue in DAP, BTW.  See gdb/python/lib/gdb/dap/frames.py and in particular the work done in _frame_id_generator.

Tom
________________________________________
Intel Deutschland GmbH 

Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany 

Tel: +49 (89) 99143-0 

www.intel.de 

Managing Directors: Candice Moore, Jeffrey Schneiderman, Ramachandran Sitaraman

Chairperson of the Supervisory Board: Sonja Pierer

Registered Seat: Munich Commercial Register B: Amtsgericht Munich HRB 186928

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.