RE: [PATCH v11 05/10] gdb: Skip trampoline functions for the finish and reverse-finish commands.

["Ijaz, Abdul B" <abdul.b.ijaz@intel.com>]

Thanks Tom, for the feedback.

Please see the inline reply below:

>> +      for (int i = 0; (SAFE_TRAMPOLINE_CHAIN (i, frame)
>> +                   && in_trampoline_frame (frame)); ++i)
>> +    frame = get_prev_frame (frame);

Tom> This snippet appears in several places and I think it would be better as a function.
Tom> Then maybe the SAFE_TRAMPOLINE_CHAIN macro could be dispensed with as well.

Abdul> Agreed.  For v12 I will add a function, next to in_trampoline_frame.   It will be added in this patch, the first one that needs it, and used for "finish", "up", the MI -stack-list-frames and -stack-list-arguments commands and the Python frame filters.  The chain limit moves into the function, so SAFE_TRAMPOLINE_CHAIN goes away.
The "return" command handling is different: it pops the trampoline frames one by one and looks at the new current frame each time, so it keeps its own loop, but without the macro.

Best Regards,
Abdul Basit

-----Original Message-----
From: Tom Tromey <tom@tromey.com> 
Sent: Wednesday, October 21, 2026 10:53 PM
To: Ijaz, Abdul B <abdul.b.ijaz@intel.com>
Cc: gdb-patches@sourceware.org; JiniSusan.George@amd.com; tom@tromey.com; eliz@gnu.org
Subject: Re: [PATCH v11 05/10] gdb: Skip trampoline functions for the finish and reverse-finish commands.

>>>>> Abdul Basit Ijaz <abdul.b.ijaz@intel.com> writes:

> This change skips trampoline functions when the option 
> 'skip-trampoline-functions' is set to 'on' for the finish or 
> reverse-finish command.  Before this change, for these commands GDB 
> returns to the trampoline function indicated by the compiler with DIE 
> "DW_AT_trampoline".  For better user experience, all such frames can be hidden from the user.

Ah, ok.  I was looking at the patches mostly in order, so I missed that there was a separate patch for "finish".

> +      for (int i = 0; (SAFE_TRAMPOLINE_CHAIN (i, frame)
> +		       && in_trampoline_frame (frame)); ++i)
> +	frame = get_prev_frame (frame);

This snippet appears in several places and I think it would be better as a function.

Then maybe the SAFE_TRAMPOLINE_CHAIN macro could be dispensed with as well.

Tom
________________________________________
Intel Deutschland GmbH 

Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany 

Tel: +49 (89) 99143-0 

www.intel.de 

Managing Directors: Candice Moore, Jeffrey Schneiderman, Ramachandran Sitaraman

Chairperson of the Supervisory Board: Sonja Pierer

Registered Seat: Munich Commercial Register B: Amtsgericht Munich HRB 186928

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.