[PATCH] Let gdb know that cygwin is dosish

[PATCH] Let gdb know that cygwin is dosish

[Christopher Faylor]

I'm not sure if this falls into my jurisdiction or not, but unless
there are objections, I'm going to make the following change.

I recently found that a bug that I'd been halfheartedly tracking
down for months was caused by the fact that some of gdb's code didn't
recognize the fact that f:/ was an absolute path under cygwin.

This patch should fix that as well as a number of other odd
incompatibilities with mixed case.

cgf

2001-10-16  Christopher Faylor  <cgf@redhat.com>

	* filenames.h: Add cygwin to the list of dosish style path systems.

Index: filenames.h
===================================================================
RCS file: /cvs/uberbaum/include/filenames.h,v
retrieving revision 1.1
diff -u -p -r1.1 filenames.h
--- filenames.h	2000/05/26 13:11:57	1.1
+++ filenames.h	2001/10/16 04:59:01
@@ -5,7 +5,7 @@
    use forward- and back-slash in path names interchangeably, and
    some of them have case-insensitive file names.
 
-   Copyright 2000 Free Software Foundation, Inc.
+   Copyright 2000, 2001 Free Software Foundation, Inc.
 
 This file is part of BFD, the Binary File Descriptor library.
 
@@ -26,7 +26,7 @@ Foundation, Inc., 59 Temple Place - Suit
 #ifndef FILENAMES_H
 #define FILENAMES_H
 
-#if defined(__MSDOS__) || defined(_WIN32) || defined(__OS2__)
+#if defined(__MSDOS__) || defined(_WIN32) || defined(__OS2__) || defined (__CYGWIN__)
 
 #ifndef HAVE_DOS_BASED_FILE_SYSTEM
 #define HAVE_DOS_BASED_FILE_SYSTEM 1

Re: [PATCH] Let gdb know that cygwin is dosish

[Eli Zaretskii]

On Tue, 16 Oct 2001, Christopher Faylor wrote:

> I recently found that a bug that I'd been halfheartedly tracking
> down for months was caused by the fact that some of gdb's code didn't
> recognize the fact that f:/ was an absolute path under cygwin.
> 
> This patch should fix that as well as a number of other odd
> incompatibilities with mixed case.

Sounds fine to me (and long overdue ;-), but do Cygwin library
functions support the drive letter braindamage?  If not, you will get
yourself in trouble.

I wrote filenames.h, so if you need my approval, you've got it.  I don't 
know who's its responsible maintainer, though.

Re: [PATCH] Let gdb know that cygwin is dosish

[Christopher Faylor]

On Tue, Oct 16, 2001 at 11:12:48AM +0200, Eli Zaretskii wrote:
>On Tue, 16 Oct 2001, Christopher Faylor wrote:
>>I recently found that a bug that I'd been halfheartedly tracking down
>>for months was caused by the fact that some of gdb's code didn't
>>recognize the fact that f:/ was an absolute path under cygwin.
>>
>>This patch should fix that as well as a number of other odd
>>incompatibilities with mixed case.
>
>Sounds fine to me (and long overdue ;-), but do Cygwin library
>functions support the drive letter braindamage?  If not, you will get
>yourself in trouble.

Sure.  DOS files just bypass cygwin's path manipulation, for the most
part.

>I wrote filenames.h, so if you need my approval, you've got it.  I don't 
>know who's its responsible maintainer, though.

I assume that only you and I really care about this.  :-)

cgf

Re: [PATCH] Let gdb know that cygwin is dosish

[DJ Delorie]

> I wrote filenames.h, so if you need my approval, you've got it.  I don't 
> know who's its responsible maintainer, though.

It's not in libiberty but it looks like the kind of thing that could
(should?) be added to libiberty.  But, I'll put on my binutils
maintainer hat and give it my approval anyway :-)

gcc's gcc/system.h has a similar set of macros.  I vaguely recall a
patch to migrate all that to libiberty, but can't find it now, but it
would be a useful thing for someone to work on...

Re: [PATCH] Let gdb know that cygwin is dosish

[Christopher Faylor]

On Tue, Oct 16, 2001 at 01:07:10PM -0400, DJ Delorie wrote:
>>I wrote filenames.h, so if you need my approval, you've got it.  I
>>don't know who's its responsible maintainer, though.
>
>It's not in libiberty but it looks like the kind of thing that could
>(should?) be added to libiberty.  But, I'll put on my binutils
>maintainer hat and give it my approval anyway :-)

I've checked this in.

cgf