Re: [PATCH]: ser-tcp.c: Use `localhost' as default hostname

Re: [PATCH]: ser-tcp.c: Use `localhost' as default hostname

[Andrew Cagney]

> Hi,
> 
> I don't like to type
> 
>   target remote localhost:1234
> 
> all the time. It"s possible to abbreviate it to
> 
>   ta r localhost:1234
> 
> but I don't see a need to type `localhost'. I would like to have
> `localhost' as default if no hostname is given like in:
> 
>   ta r :1234


I don't have an opinion.  Does anyone strongly object or concure with this?

	Andrew

Re: [PATCH]: ser-tcp.c: Use `localhost' as default hostname

[Kevin Buettner]

On Aug 1,  2:34pm, Andrew Cagney wrote:

> > I don't like to type
> > 
> >   target remote localhost:1234
> > 
> > all the time. It"s possible to abbreviate it to
> > 
> >   ta r localhost:1234
> > 
> > but I don't see a need to type `localhost'. I would like to have
> > `localhost' as default if no hostname is given like in:
> > 
> >   ta r :1234
> 
> 
> I don't have an opinion.  Does anyone strongly object or concure with this?

I don't strongly object or concur.

But I will observe that commands like ``target remote localhost:1234''
might be better placed in a .gdbinit file or some other file which can
be explicitly sourced.  I.e,

    so myinits

doesn't seem so bad to type.  (And if it's placed in .gdbinit, there's
no typing at all.)

Kevin

Re: [PATCH]: ser-tcp.c: Use `localhost' as default hostname

[Stan Shebs]

Andrew Cagney wrote:
> 
> >   ta r :1234
> 
> I don't have an opinion.  Does anyone strongly object or concure with this?

Heh, for some reason I thought this already worked.  But yeah, it
seems like the right thing - ':' is not normally the first character
of a host name, so no ambiguity.

Stan

Re: [PATCH]: ser-tcp.c: Use `localhost' as default hostname

[Michael Snyder]

Andrew Cagney wrote:
> 
> > Hi,
> >
> > I don't like to type
> >
> >   target remote localhost:1234
> >
> > all the time. It"s possible to abbreviate it to
> >
> >   ta r localhost:1234
> >
> > but I don't see a need to type `localhost'. I would like to have
> > `localhost' as default if no hostname is given like in:
> >
> >   ta r :1234
> 
> I don't have an opinion.  Does anyone strongly object or concure with this?

I think it's a great idea.  The default for "host" should be "this host".
And like Stan says, it shouldn't do any harm...

Re: [PATCH]: ser-tcp.c: Use `localhost' as default hostname

[Andrew Cagney]

Corinna,

Can you please add your self to the write-after-approval list of the 
gdb/MAINTAINERS file as an ``obvious fix'' (don't forget to post the 
corresponding change).

Your patch is approved.  Should this be mentioned in the doco?

     Andrew

Re: [PATCH]: ser-tcp.c: Use `localhost' as default hostname

[Eli Zaretskii]

On Wed, 1 Aug 2001, Andrew Cagney wrote:

> > I don't like to type
> > 
> >   target remote localhost:1234
> > 
> > all the time. It"s possible to abbreviate it to
> > 
> >   ta r localhost:1234
> > 
> > but I don't see a need to type `localhost'. I would like to have
> > `localhost' as default if no hostname is given like in:
> > 
> >   ta r :1234
> 
> I don't have an opinion.  Does anyone strongly object or concure with this?

Can the string after "target remote" ever be a file name?  If so, the
code that implements this should need to exercise caution not to break
the DOS/Windows drive-letter brain-damage.

Re: [PATCH]: ser-tcp.c: Use `localhost' as default hostname

[Eli Zaretskii]

On Thu, 2 Aug 2001, Andrew Cagney wrote:

> Your patch is approved.  Should this be mentioned in the doco?

Of course.

Re: [PATCH]: ser-tcp.c: Use `localhost' as default hostname

[Corinna Vinschen]

On Thu, Aug 02, 2001 at 01:25:43AM -0400, Andrew Cagney wrote:
> Corinna,
> 
> Can you please add your self to the write-after-approval list of the 
> gdb/MAINTAINERS file as an ``obvious fix'' (don't forget to post the 
> corresponding change).
> 
> Your patch is approved.  Should this be mentioned in the doco?

Applied.

What about the following patch to the docu:

2001-08-02  Corinna Vinschen  <vinschen@redhat.com>

        * gdb.texinfo: Explain omitting the hostname in the
        `target remote' command.

Index: gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.47
diff -u -p -r1.47 gdb.texinfo
--- gdb.texinfo 2001/07/28 19:35:20     1.47
+++ gdb.texinfo 2001/08/02 09:01:48
@@ -9636,6 +9636,17 @@ terminal server named @code{manyfarms}:
 @example
 target remote manyfarms:2828
 @end example
+
+If your remote target is actually running on the same machine as
+your debugger session (e.g. a simulator of your target running on
+the same host) you can omit the hostname.  For example, to connect
+to port 1234 on your local machine:
+
+@example
+target remote :1234
+@end example
+
+Note that the colon is still required here.
 @end enumerate

 Now you can use all the usual commands to examine and change data and to

Corinna

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:vinschen@redhat.com

Re: [PATCH]: ser-tcp.c: Use `localhost' as default hostname

[Eli Zaretskii]

On Thu, 2 Aug 2001, Corinna Vinschen wrote:

> What about the following patch to the docu:
> 
> 2001-08-02  Corinna Vinschen  <vinschen@redhat.com>
> 
>         * gdb.texinfo: Explain omitting the hostname in the
>         `target remote' command.

Thanks.  This is approved, with the following nitpicking:

> +your debugger session (e.g. a simulator of your target running on

Please use "e.g.@:", to get TeX typeset this correctly (a period before a 
blank is by default taken as ending the sentence).

> +the same host) you can omit the hostname.  For example, to connect
                ^
You need a comma after the right parenthesis.

> +@example
> +target remote :1234
> +@end example
> +
> +Note that the colon is still required here.

Please add @noindent, on a line by itself, before the last line (since 
that line should not be indented, as it continues the example that's 
before it).

Re: [PATCH]: ser-tcp.c: Use `localhost' as default hostname

[Corinna Vinschen]

On Thu, Aug 02, 2001 at 01:11:08PM +0300, Eli Zaretskii wrote:
> 
> On Thu, 2 Aug 2001, Corinna Vinschen wrote:
> 
> > What about the following patch to the docu:
> > 
> > 2001-08-02  Corinna Vinschen  <vinschen@redhat.com>
> > 
> >         * gdb.texinfo: Explain omitting the hostname in the
> >         `target remote' command.
> 
> Thanks.  This is approved, with the following nitpicking:
> 
> > +your debugger session (e.g. a simulator of your target running on
> 
> Please use "e.g.@:", to get TeX typeset this correctly (a period before a 
> blank is by default taken as ending the sentence).
> 
> > +the same host) you can omit the hostname.  For example, to connect
>                 ^
> You need a comma after the right parenthesis.
> 
> > +@example
> > +target remote :1234
> > +@end example
> > +
> > +Note that the colon is still required here.
> 
> Please add @noindent, on a line by itself, before the last line (since 
> that line should not be indented, as it continues the example that's 
> before it).

Thanks for the hints. Applied with the above changes.

Corinna

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:vinschen@redhat.com