[RFA] Remove unused declaration in top.c

[RFA] Remove unused declaration in top.c

[Eli Zaretskii]

I'm asking for approval of the following patch which removes an unused 
definition of struct user_args variable in top.c.  AFAICS, this is a 
relic left behind when cli-* files were separated from top.c.  The reason 
I payed attention to it was that the Irix linker printed a warning about 
duplicate definition (one in top.c, the other in cli-script.c).

Okay to commit?  (It looks like an obvious fix, but...)

2001-05-17  Eli Zaretskii  <eliz@is.elta.co.il>

	* top.c (user_args): Remove unused declaration.


--- gdb/top.c~	Thu Apr  5 18:59:30 2001
+++ gdb/top.c	Thu May 17 17:36:24 2001
@@ -224,21 +224,6 @@
 /* Level of control structure.  */
 static int control_level;
 
-/* Structure for arguments to user defined functions.  */
-#define MAXUSERARGS 10
-struct user_args
-  {
-    struct user_args *next;
-    struct
-      {
-	char *arg;
-	int len;
-      }
-    a[MAXUSERARGS];
-    int count;
-  }
- *user_args;
-
 /* Signal to catch ^Z typed while reading a command: SIGTSTP or SIGCONT.  */
 
 #ifndef STOP_SIGNAL

Re: [RFA] Remove unused declaration in top.c

[Elena Zannoni]

Eli Zaretskii writes:
 > I'm asking for approval of the following patch which removes an unused 
 > definition of struct user_args variable in top.c.  AFAICS, this is a 
 > relic left behind when cli-* files were separated from top.c.  The reason 
 > I payed attention to it was that the Irix linker printed a warning about 
 > duplicate definition (one in top.c, the other in cli-script.c).
 > 
 > Okay to commit?  (It looks like an obvious fix, but...)
 > 

Yes, thanks!

Elena



 > 2001-05-17  Eli Zaretskii  <eliz@is.elta.co.il>
 > 
 > 	* top.c (user_args): Remove unused declaration.
 > 
 > 
 > --- gdb/top.c~	Thu Apr  5 18:59:30 2001
 > +++ gdb/top.c	Thu May 17 17:36:24 2001
 > @@ -224,21 +224,6 @@
 >  /* Level of control structure.  */
 >  static int control_level;
 >  
 > -/* Structure for arguments to user defined functions.  */
 > -#define MAXUSERARGS 10
 > -struct user_args
 > -  {
 > -    struct user_args *next;
 > -    struct
 > -      {
 > -	char *arg;
 > -	int len;
 > -      }
 > -    a[MAXUSERARGS];
 > -    int count;
 > -  }
 > - *user_args;
 > -
 >  /* Signal to catch ^Z typed while reading a command: SIGTSTP or SIGCONT.  */
 >  
 >  #ifndef STOP_SIGNAL
 > 

Re: [RFA] Remove unused declaration in top.c

[Eli Zaretskii]

On Thu, 17 May 2001, Elena Zannoni wrote:

> Eli Zaretskii writes:
>  > I'm asking for approval of the following patch which removes an unused 
>  > definition of struct user_args variable in top.c.  AFAICS, this is a 
>  > relic left behind when cli-* files were separated from top.c.  The reason 
>  > I payed attention to it was that the Irix linker printed a warning about 
>  > duplicate definition (one in top.c, the other in cli-script.c).
>  > 
>  > Okay to commit?  (It looks like an obvious fix, but...)
>  > 
> 
> Yes, thanks!

Commited.  Thanks for the fast response.

> 
> Elena
> 
> 
> 
>  > 2001-05-17  Eli Zaretskii  <eliz@is.elta.co.il>
>  > 
>  > 	* top.c (user_args): Remove unused declaration.
>  > 
>  > 
>  > --- gdb/top.c~	Thu Apr  5 18:59:30 2001
>  > +++ gdb/top.c	Thu May 17 17:36:24 2001
>  > @@ -224,21 +224,6 @@
>  >  /* Level of control structure.  */
>  >  static int control_level;
>  >  
>  > -/* Structure for arguments to user defined functions.  */
>  > -#define MAXUSERARGS 10
>  > -struct user_args
>  > -  {
>  > -    struct user_args *next;
>  > -    struct
>  > -      {
>  > -	char *arg;
>  > -	int len;
>  > -      }
>  > -    a[MAXUSERARGS];
>  > -    int count;
>  > -  }
>  > - *user_args;
>  > -
>  >  /* Signal to catch ^Z typed while reading a command: SIGTSTP or SIGCONT.  */
>  >  
>  >  #ifndef STOP_SIGNAL
>  > 
>