Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@is.elta.co.il>
To: Fernando Nasser <fnasser@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] File-name completion improvements
Date: Thu, 15 Feb 2001 03:13:00 -0000	[thread overview]
Message-ID: <Pine.SUN.3.91.1010215131046.27892H-100000@is> (raw)
In-Reply-To: <3A8ACFD3.7700B474@cygnus.com>

On Wed, 14 Feb 2001, Fernando Nasser wrote:

> Instead of changing this:
> rl_completer_word_break_characters =
>                          gdb_completer_file_name_break_characters;
> into this:
> char *fbc = gdb_completer_file_name_break_characters;
> rl_completer_word_break_characters = fbc;
> so you can use the shorthand here:
> p > tmp_command && strchr (fbc, p[-1]) == NULL;
> just use the full name:
> p > tmp_command && strchr (gdb_completer_file_name_break_characters, \
>                            p[-1]) == NULL;
> 
> I know, it is an awful long variable name.

The _real_ reason for that funky shorthand was not that it's long to
type ("M-/" in Emacs makes that problem go away ;-).  The real reason
was that, due to reindentation, the code either looks ugly or gets
past column 80.  If people don't mind that, there's no point in
introducing a new variable.

> After committing, please post the final version so it makes into the
> list archives.

Will do.


  reply	other threads:[~2001-02-15  3:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-02-12  0:18 Eli Zaretskii
2001-02-14 10:35 ` Fernando Nasser
2001-02-15  3:13   ` Eli Zaretskii [this message]
2001-02-17 23:05   ` Eli Zaretskii
2001-02-17 23:34     ` [RFA] More " Eli Zaretskii
2001-02-18  6:58       ` Fernando Nasser
2001-02-18  7:58         ` Eli Zaretskii
2001-02-18  8:40       ` Kevin Buettner
2001-02-18  9:56         ` Fernando Nasser
2001-02-18 10:39           ` Kevin Buettner
2001-02-18 10:49             ` Fernando Nasser
2001-02-18 12:22               ` Eli Zaretskii
2001-02-19  3:48               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.SUN.3.91.1010215131046.27892H-100000@is \
    --to=eliz@is.elta.co.il \
    --cc=fnasser@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox