From: Keith Seitz <keiths@cygnus.com>
To: Eli Zaretskii <eliz@is.elta.co.il>
Cc: jmoore@redhat.com, gdb-patches@sources.redhat.com
Subject: Re: [RFA] Add dependency of gdb on tcl/tk libraries
Date: Fri, 13 Apr 2001 07:23:00 -0000 [thread overview]
Message-ID: <Pine.SOL.3.91.1010413071138.24475H-100000@ryobi.cygnus.com> (raw)
In-Reply-To: <200104130640.CAA07506@delorie.com>
On Fri, 13 Apr 2001, Eli Zaretskii wrote:
> > 2001-04-12 John R. Moore <jmoore@redhat.com>
> >
> > * configure.in: Added dependency of gdb on tcl/tk libraries.
> > * Makefile.in: Likewise.
> > * configure: Regenerated with the above using autoconf.
>
> Hmm... am I missing something, or does this patch _require_ tcl to be
> linked in? What about ports that *never* build with tcl, such as
> DJGPP? What if the Tcl and Tk directories don't exist at configure
> time?
This patch only really affects configure.in. The machinery for it has
existed in gdb for over three years. You've been using it all along.
(Spooky -- almost Erin Brokovich-ish.. Water, anyone?)
The configury change that John is adding (which appears good) is confined
only to Insight. A quick read of the surrounding code has:
if test "${enable_gdbtk}" = "yes"; then
[...]
TCL_DEPS="${tcldir}${TCL_LIB_FILE}"
[...]
fi
So, unless you configure with "--enable-gdbtk" or you have the insight
module present (which enables "--enable-gdbtk" by default), you'll never
see this.
However, to be safe... John, have you/can you check out the gdb module
(without Insight) and tried this? Does it cause any additional problems
(TCL_DEPS, TK_DEPS, etc should all be blank).
I have tested this patch with the insight module, both with
--enable-gdbtk and without, and it works just fine in both cases.
Keith
next prev parent reply other threads:[~2001-04-13 7:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-12 15:04 John R. Moore
2001-04-12 23:40 ` Eli Zaretskii
2001-04-13 7:23 ` Keith Seitz [this message]
2001-04-13 7:46 ` Fernando Nasser
2001-04-13 8:19 ` Keith Seitz
2001-04-13 8:21 ` Fernando Nasser
2001-04-13 10:24 ` John R. Moore
2001-04-13 10:18 ` John R. Moore
2001-04-13 10:24 ` Keith Seitz
2001-04-13 11:44 ` John R. Moore
2001-04-13 12:22 ` Keith Seitz
2001-04-13 15:46 ` Christopher Faylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.SOL.3.91.1010413071138.24475H-100000@ryobi.cygnus.com \
--to=keiths@cygnus.com \
--cc=eliz@is.elta.co.il \
--cc=gdb-patches@sources.redhat.com \
--cc=jmoore@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox