From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keith Seitz <keiths@cygnus.com>
To: Eli Zaretskii <eliz@is.elta.co.il>
Cc: jmoore@redhat.com, gdb-patches@sources.redhat.com
Subject: Re: [RFA] Add dependency of gdb on tcl/tk libraries
Date: Fri, 13 Apr 2001 07:23:00 -0000
Message-id: <Pine.SOL.3.91.1010413071138.24475H-100000@ryobi.cygnus.com>
References: <200104130640.CAA07506@delorie.com>
X-SW-Source: 2001-04/msg00136.html

On Fri, 13 Apr 2001, Eli Zaretskii wrote:

> > 2001-04-12  John R. Moore  <jmoore@redhat.com>
> > 
> >	* configure.in: Added dependency of gdb on tcl/tk libraries.
> >	* Makefile.in: Likewise.
> >	* configure: Regenerated with the above using autoconf.
> 
> Hmm... am I missing something, or does this patch _require_ tcl to be
> linked in?  What about ports that *never* build with tcl, such as
> DJGPP?  What if the Tcl and Tk directories don't exist at configure
> time?

This patch only really affects configure.in. The machinery for it has 
existed in gdb for over three years. You've been using it all along. 
(Spooky -- almost Erin Brokovich-ish.. Water, anyone?)

The configury change that John is adding (which appears good) is confined 
only to Insight. A quick read of the surrounding code has:

if test "${enable_gdbtk}" = "yes"; then
  [...]
  TCL_DEPS="${tcldir}${TCL_LIB_FILE}"
  [...]
fi

So, unless you configure with "--enable-gdbtk" or you have the insight 
module present (which enables "--enable-gdbtk" by default), you'll never 
see this.

However, to be safe... John, have you/can you check out the gdb module 
(without Insight) and tried this? Does it cause any additional problems 
(TCL_DEPS, TK_DEPS, etc should all be blank).

I have tested this patch with the insight module, both with 
--enable-gdbtk and without, and it works just fine in both cases.

Keith