From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Sandra Loosemore <sandra@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [patch 3/4] Nios II gdbserver support
Date: Tue, 23 Apr 2013 02:45:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1304222101460.8464@digraph.polyomino.org.uk> (raw)
In-Reply-To: <5174820E.6090500@codesourcery.com>
On Sun, 21 Apr 2013, Sandra Loosemore wrote:
> + Copyright (C) 2008, 2012, 2013
> + Free Software Foundation, Inc.
GDB now uses copyright year ranges, so
Copyright (C) 2008-2013 Free Software Foundation, Inc.
(all on one line) and likewise for any other new files in this patch
series.
> +#ifndef PTRACE_GET_THREAD_AREA
> +#define PTRACE_GET_THREAD_AREA 25
> +#endif
The same comment I made on the AArch64 port applies here: for native code
in new ports, as opposed to use of new definitions in existing ports, you
should just be able to assume recent-enough headers (at least until the
Linux kernel port goes upstream, at which point the first upstream release
with the code can be the minimum version of kernel headers supported)
rather than having such #if conditionals.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2013-04-22 21:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 13:31 Sandra Loosemore
2013-04-23 2:45 ` Joseph S. Myers [this message]
2013-04-23 9:33 ` Sandra Loosemore
2013-04-24 0:00 ` Joseph S. Myers
[not found] ` <20130426064547.GQ3525@adacore.com>
2013-05-03 3:45 ` [patch 3/4] Nios II gdbserver support, version 2 Sandra Loosemore
2013-05-03 18:09 ` Pedro Alves
2013-05-05 2:16 ` [patch 3/4] Nios II gdbserver support, version 3 Sandra Loosemore
2013-05-06 9:15 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1304222101460.8464@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=sandra@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox