From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27865 invoked by alias); 22 Apr 2013 21:06:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27853 invoked by uid 89); 22 Apr 2013 21:06:25 -0000 X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 22 Apr 2013 21:06:04 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UUNw3-0003VC-27 from joseph_myers@mentor.com for gdb-patches@sourceware.org; Mon, 22 Apr 2013 14:06:03 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 22 Apr 2013 14:06:02 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Mon, 22 Apr 2013 22:06:00 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1UUNvz-0002t2-77; Mon, 22 Apr 2013 21:05:59 +0000 Date: Tue, 23 Apr 2013 02:45:00 -0000 From: "Joseph S. Myers" To: Sandra Loosemore CC: Subject: Re: [patch 3/4] Nios II gdbserver support In-Reply-To: <5174820E.6090500@codesourcery.com> Message-ID: References: <5174820E.6090500@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2013-04/txt/msg00686.txt.bz2 On Sun, 21 Apr 2013, Sandra Loosemore wrote: > + Copyright (C) 2008, 2012, 2013 > + Free Software Foundation, Inc. GDB now uses copyright year ranges, so Copyright (C) 2008-2013 Free Software Foundation, Inc. (all on one line) and likewise for any other new files in this patch series. > +#ifndef PTRACE_GET_THREAD_AREA > +#define PTRACE_GET_THREAD_AREA 25 > +#endif The same comment I made on the AArch64 port applies here: for native code in new ports, as opposed to use of new definitions in existing ports, you should just be able to assume recent-enough headers (at least until the Linux kernel port goes upstream, at which point the first upstream release with the code can be the minimum version of kernel headers supported) rather than having such #if conditionals. -- Joseph S. Myers joseph@codesourcery.com