From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: use character classes rather than ranges
Date: Mon, 19 Mar 2012 11:52:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1203191148440.9545@digraph.polyomino.org.uk> (raw)
In-Reply-To: <1332132828-4576-1-git-send-email-vapier@gentoo.org>
On Mon, 19 Mar 2012, Mike Frysinger wrote:
> A-Z ranges don't work in all locales, so use character classes instead.
Are these patterns really meant to depend on the user's locale (and
support locale-specific letters) or are they related to the checked-in
source code (in which case they should support just ASCII letters and
digits - either the relevant program should be run in the C locale, or as
in GCC's option-handling awk scripts the full sets of letters and digits
should be given explicitly somewhere)?
(Using character classes like you do is fine - *if* either the user's
locale is correct for this code or the programs explicitly run in the C
locale.)
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2012-03-19 11:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 4:54 Mike Frysinger
2012-03-19 11:52 ` Joseph S. Myers [this message]
2012-03-19 15:07 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1203191148440.9545@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox