From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14509 invoked by alias); 19 Mar 2012 11:52:34 -0000 Received: (qmail 14501 invoked by uid 22791); 19 Mar 2012 11:52:33 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Mar 2012 11:52:11 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1S9b8E-0007jR-I8 from joseph_myers@mentor.com ; Mon, 19 Mar 2012 04:52:10 -0700 Received: from digraph.polyomino.org.uk ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 19 Mar 2012 11:52:08 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.74) (envelope-from ) id 1S9b8C-0003Fp-7V; Mon, 19 Mar 2012 11:52:08 +0000 Date: Mon, 19 Mar 2012 11:52:00 -0000 From: "Joseph S. Myers" To: Mike Frysinger cc: gdb-patches@sourceware.org Subject: Re: [PATCH] sim: use character classes rather than ranges In-Reply-To: <1332132828-4576-1-git-send-email-vapier@gentoo.org> Message-ID: References: <1332132828-4576-1-git-send-email-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00697.txt.bz2 On Mon, 19 Mar 2012, Mike Frysinger wrote: > A-Z ranges don't work in all locales, so use character classes instead. Are these patterns really meant to depend on the user's locale (and support locale-specific letters) or are they related to the checked-in source code (in which case they should support just ASCII letters and digits - either the relevant program should be run in the C locale, or as in GCC's option-handling awk scripts the full sets of letters and digits should be given explicitly somewhere)? (Using character classes like you do is fine - *if* either the user's locale is correct for this code or the programs explicitly run in the C locale.) -- Joseph S. Myers joseph@codesourcery.com