Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Joseph S. Myers" <joseph@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: binutils@sourceware.org, gcc-patches@gcc.gnu.org
Subject: Fix ACX_LARGEFILE to use canonical host/target names
Date: Fri, 20 Nov 2009 22:39:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.64.0911202236450.4910@digraph.polyomino.org.uk> (raw)

The ACX_LARGEFILE macro checks the values of $host and $target, which
may or may not be canonical names at this point depending on which
other macros have been called first; it should require
AC_CANONICAL_HOST and AC_CANONICAL_TARGET to ensure they are both
canonical.  This shows up as build failures for GDB configured
--build=i686-pc-linux-gnu --host=i686-solaris2.10
--target=i686-solaris2.10.  OK to commit this patch (GCC and src),
with regeneration of the GDB and binutils configure scripts that use
ACX_LARGEFILE?

2009-11-20  Joseph Myers  <joseph@codesourcery.com>

	* largefile.m4 (ACX_LARGEFILE): Require AC_CANONICAL_HOST and
	AC_CANONICAL_TARGET.

Index: config/largefile.m4
===================================================================
RCS file: /cvs/src/src/config/largefile.m4,v
retrieving revision 1.2
diff -u -r1.2 largefile.m4
--- config/largefile.m4	9 Nov 2009 23:19:11 -0000	1.2
+++ config/largefile.m4	20 Nov 2009 22:33:02 -0000
@@ -5,6 +5,11 @@
 
 AC_DEFUN([ACX_LARGEFILE],[dnl
 
+# The tests for host and target for $enable_largefile require
+# canonical names.
+AC_REQUIRE([AC_CANONICAL_HOST])
+AC_REQUIRE([AC_CANONICAL_TARGET])
+
 # As the $enable_largefile decision depends on --enable-plugins we must set it
 # even in directories otherwise not depending on the $plugins option.
 

-- 
Joseph S. Myers
joseph@codesourcery.com


             reply	other threads:[~2009-11-20 22:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-20 22:39 Joseph S. Myers [this message]
2009-11-22 14:20 ` Jan Kratochvil
2009-11-28 20:11 ` Ping " Joseph S. Myers
2009-11-30 10:31 ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0911202236450.4910@digraph.polyomino.org.uk \
    --to=joseph@codesourcery.com \
    --cc=binutils@sourceware.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox