From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25730 invoked by alias); 20 Nov 2009 22:39:26 -0000 Received: (qmail 25699 invoked by uid 22791); 20 Nov 2009 22:39:23 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 20 Nov 2009 22:38:19 +0000 Received: (qmail 8916 invoked from network); 20 Nov 2009 22:38:17 -0000 Received: from unknown (HELO digraph.polyomino.org.uk) (joseph@127.0.0.2) by mail.codesourcery.com with ESMTPA; 20 Nov 2009 22:38:17 -0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.69) (envelope-from ) id 1NBc7M-0005ca-7C; Fri, 20 Nov 2009 22:38:16 +0000 Date: Fri, 20 Nov 2009 22:39:00 -0000 From: "Joseph S. Myers" To: gdb-patches@sourceware.org cc: binutils@sourceware.org, gcc-patches@gcc.gnu.org Subject: Fix ACX_LARGEFILE to use canonical host/target names Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00452.txt.bz2 The ACX_LARGEFILE macro checks the values of $host and $target, which may or may not be canonical names at this point depending on which other macros have been called first; it should require AC_CANONICAL_HOST and AC_CANONICAL_TARGET to ensure they are both canonical. This shows up as build failures for GDB configured --build=i686-pc-linux-gnu --host=i686-solaris2.10 --target=i686-solaris2.10. OK to commit this patch (GCC and src), with regeneration of the GDB and binutils configure scripts that use ACX_LARGEFILE? 2009-11-20 Joseph Myers * largefile.m4 (ACX_LARGEFILE): Require AC_CANONICAL_HOST and AC_CANONICAL_TARGET. Index: config/largefile.m4 =================================================================== RCS file: /cvs/src/src/config/largefile.m4,v retrieving revision 1.2 diff -u -r1.2 largefile.m4 --- config/largefile.m4 9 Nov 2009 23:19:11 -0000 1.2 +++ config/largefile.m4 20 Nov 2009 22:33:02 -0000 @@ -5,6 +5,11 @@ AC_DEFUN([ACX_LARGEFILE],[dnl +# The tests for host and target for $enable_largefile require +# canonical names. +AC_REQUIRE([AC_CANONICAL_HOST]) +AC_REQUIRE([AC_CANONICAL_TARGET]) + # As the $enable_largefile decision depends on --enable-plugins we must set it # even in directories otherwise not depending on the $plugins option. -- Joseph S. Myers joseph@codesourcery.com