* [PATCH/m68k] Fix length of lea insn.
@ 2008-05-23 5:00 Roman Zippel
2008-05-29 10:07 ` Daniel Jacobowitz
0 siblings, 1 reply; 3+ messages in thread
From: Roman Zippel @ 2008-05-23 5:00 UTC (permalink / raw)
To: gdb-patches
Hi,
This patch is needed to correctly set a breakpoint in a library, otherwise
gdb will put the breakpoint in the middle of the instruction and cause a
segfault.
bye, Roman
2008-05-22 Roman Zippel <zippel@linux-m68k.org>
* m68k-tdep.c (m68k_analyze_prologue): Fix length of lea insn.
Index: m68k-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/m68k-tdep.c,v
retrieving revision 1.136
diff -u -r1.136 m68k-tdep.c
--- m68k-tdep.c 16 May 2008 00:27:23 -0000 1.136
+++ m68k-tdep.c 22 May 2008 18:26:53 -0000
@@ -804,7 +804,7 @@
if (op == P_LEA_PC_A5)
{
/* lea (%pc,N),%a5 */
- return pc + 6;
+ return pc + 8;
}
return pc;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH/m68k] Fix length of lea insn.
2008-05-23 5:00 [PATCH/m68k] Fix length of lea insn Roman Zippel
@ 2008-05-29 10:07 ` Daniel Jacobowitz
[not found] ` <Pine.LNX.4.64.0805310429160.5372@localhost.localdomain>
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Jacobowitz @ 2008-05-29 10:07 UTC (permalink / raw)
To: Roman Zippel; +Cc: gdb-patches
On Thu, May 22, 2008 at 08:42:25PM +0200, Roman Zippel wrote:
> Hi,
>
> This patch is needed to correctly set a breakpoint in a library, otherwise
> gdb will put the breakpoint in the middle of the instruction and cause a
> segfault.
>
> bye, Roman
>
> 2008-05-22 Roman Zippel <zippel@linux-m68k.org>
>
> * m68k-tdep.c (m68k_analyze_prologue): Fix length of lea insn.
OK, thanks. Do you have write access and/or a copyright assignment?
--
Daniel Jacobowitz
CodeSourcery
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH/m68k] Fix length of lea insn.
[not found] ` <Pine.LNX.4.64.0805310429160.5372@localhost.localdomain>
@ 2008-06-02 16:08 ` Joel Brobecker
0 siblings, 0 replies; 3+ messages in thread
From: Joel Brobecker @ 2008-06-02 16:08 UTC (permalink / raw)
To: Roman Zippel; +Cc: Daniel Jacobowitz, gdb-patches
Roman,
> > > * m68k-tdep.c (m68k_analyze_prologue): Fix length of lea insn.
> >
> > OK, thanks. Do you have write access and/or a copyright assignment?
>
> Only the latter.
I checked both patches in for you. If you think you might be submitting
additional patches and would like to have write access to the repository,
let us know.
--
Joel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-06-02 16:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-05-23 5:00 [PATCH/m68k] Fix length of lea insn Roman Zippel
2008-05-29 10:07 ` Daniel Jacobowitz
[not found] ` <Pine.LNX.4.64.0805310429160.5372@localhost.localdomain>
2008-06-02 16:08 ` Joel Brobecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox