Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* remote-utils.c: Add missing space
@ 2007-03-30 11:28 Maciej W. Rozycki
  2007-03-30 11:38 ` Daniel Jacobowitz
  0 siblings, 1 reply; 4+ messages in thread
From: Maciej W. Rozycki @ 2007-03-30 11:28 UTC (permalink / raw)
  To: gdb-patches; +Cc: Chris Dearman, Maciej W. Rozycki

Hello,

 This change should be obvious, but it modifies run-time behaviour, so I'm 
asking just in case it hits somebody doing something strange.

2007-03-30  Chris Dearman  <chris@mips.com>

	* remote-utils.c (gr_files_info): Add missing space when printing
	baud rate.

 OK to apply?

  Maciej

12226-1.diff
Index: binutils-quilt/src/gdb/remote-utils.c
===================================================================
--- binutils-quilt.orig/src/gdb/remote-utils.c	2007-03-30 12:23:08.000000000 +0100
+++ binutils-quilt/src/gdb/remote-utils.c	2007-03-30 12:23:38.000000000 +0100
@@ -437,7 +437,7 @@
 #else
   printf_filtered ("\tAttached to %s", sr_get_device ());
   if (baud_rate != -1)
-    printf_filtered ("at %d baud", baud_rate);
+    printf_filtered (" at %d baud", baud_rate);
   printf_filtered ("\n");
 #endif
 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: remote-utils.c: Add missing space
  2007-03-30 11:28 remote-utils.c: Add missing space Maciej W. Rozycki
@ 2007-03-30 11:38 ` Daniel Jacobowitz
  2007-03-30 12:02   ` Maciej W. Rozycki
  0 siblings, 1 reply; 4+ messages in thread
From: Daniel Jacobowitz @ 2007-03-30 11:38 UTC (permalink / raw)
  To: Maciej W. Rozycki; +Cc: gdb-patches, Chris Dearman, Maciej W. Rozycki

On Fri, Mar 30, 2007 at 12:28:29PM +0100, Maciej W. Rozycki wrote:
> Hello,
> 
>  This change should be obvious, but it modifies run-time behaviour, so I'm 
> asking just in case it hits somebody doing something strange.
> 
> 2007-03-30  Chris Dearman  <chris@mips.com>
> 
> 	* remote-utils.c (gr_files_info): Add missing space when printing
> 	baud rate.
> 
>  OK to apply?

Interesting timing...

Have you encountered this code at runtime?  I ask because this file
was on my list to delete for this week.  There are no callers in-tree.

-- 
Daniel Jacobowitz
CodeSourcery


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: remote-utils.c: Add missing space
  2007-03-30 11:38 ` Daniel Jacobowitz
@ 2007-03-30 12:02   ` Maciej W. Rozycki
  2007-03-30 13:26     ` Chris Dearman
  0 siblings, 1 reply; 4+ messages in thread
From: Maciej W. Rozycki @ 2007-03-30 12:02 UTC (permalink / raw)
  To: Daniel Jacobowitz; +Cc: gdb-patches, Chris Dearman, Maciej W. Rozycki

On Fri, 30 Mar 2007, Daniel Jacobowitz wrote:

> Have you encountered this code at runtime?  I ask because this file
> was on my list to delete for this week.  There are no callers in-tree.

 I have not -- the patch comes from our internal tree and I am a mere 
messenger. ;-)  It might just have been a casual fix for a typo spotted.  
Chris?

  Maciej


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: remote-utils.c: Add missing space
  2007-03-30 12:02   ` Maciej W. Rozycki
@ 2007-03-30 13:26     ` Chris Dearman
  0 siblings, 0 replies; 4+ messages in thread
From: Chris Dearman @ 2007-03-30 13:26 UTC (permalink / raw)
  To: Maciej W. Rozycki; +Cc: Daniel Jacobowitz, gdb-patches, Maciej W. Rozycki

Maciej W. Rozycki wrote:

>  I have not -- the patch comes from our internal tree and I am a mere 
> messenger. ;-)  It might just have been a casual fix for a typo spotted.  
> Chris?

   I think that's probably the case. If there are no callers to the 
function and it's slated for removal I think the case is closed :)

Chris

-- 
Chris Dearman          7200 Cambridge Research Park     +44 1223 203108
MIPS Technologies (UK) Waterbeach, Cambs CB25 9TL  fax  +44 1223 203181


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-03-30 13:26 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-03-30 11:28 remote-utils.c: Add missing space Maciej W. Rozycki
2007-03-30 11:38 ` Daniel Jacobowitz
2007-03-30 12:02   ` Maciej W. Rozycki
2007-03-30 13:26     ` Chris Dearman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox