* [RFC] psim.c file is missing a header file libiberty.h
@ 2005-04-20 15:06 Manoj Iyer
2005-04-20 22:09 ` Mark Kettenis
0 siblings, 1 reply; 3+ messages in thread
From: Manoj Iyer @ 2005-04-20 15:06 UTC (permalink / raw)
To: gdb-patches
The psim.c file is missing a header file libiberty.h, this causes the
linker (AIX) to report an unresolved symbol namely ".alloca". cc -g -o
psim main.o libsim.a ../../bfd/libbfd.a ../../libiberty/libiberty.a ld:
0711-317 ERROR: Undefined symbol: .alloca ld: 0711-345 Use the -bloadmap
or -bnoquiet option to obtain more information.
The patch below adds the headerfile to psim.c file. Please review and ok
to commit.
------------------------------------------------------------------------
2005-04-20 Manoj Iyer <manjo@austin.ibm.com>
* psim.c: Added libiberty.h header file.
--- src/sim/ppc/psim.c 2003-06-22 11:48:12.000000000 -0500
+++ new/src/sim/ppc/psim.c 2005-04-20 10:02:43.000000000 -0500
@@ -49,6 +49,7 @@
#include "bfd.h"
+#include "libiberty.h"
/* system structure, actual size of processor array determined at
Thanks
-----
manjo
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ Cogito ergo sum +
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC] psim.c file is missing a header file libiberty.h
2005-04-20 15:06 [RFC] psim.c file is missing a header file libiberty.h Manoj Iyer
@ 2005-04-20 22:09 ` Mark Kettenis
2005-04-20 22:34 ` [COMMIT] " Manoj Iyer
0 siblings, 1 reply; 3+ messages in thread
From: Mark Kettenis @ 2005-04-20 22:09 UTC (permalink / raw)
To: manjo; +Cc: gdb-patches
Date: Wed, 20 Apr 2005 10:07:32 -0500 (CDT)
From: Manoj Iyer <manjo@austin.ibm.com>
The psim.c file is missing a header file libiberty.h, this causes the
linker (AIX) to report an unresolved symbol namely ".alloca". cc -g -o
psim main.o libsim.a ../../bfd/libbfd.a ../../libiberty/libiberty.a ld:
0711-317 ERROR: Undefined symbol: .alloca ld: 0711-345 Use the -bloadmap
or -bnoquiet option to obtain more information.
The patch below adds the headerfile to psim.c file. Please review and ok
to commit.
This is ok, but please make sure there's a blank line between the
header and the actual content of the ChangeLog entry when you check it
in.
Mark
------------------------------------------------------------------------
2005-04-20 Manoj Iyer <manjo@austin.ibm.com>
* psim.c: Added libiberty.h header file.
--- src/sim/ppc/psim.c 2003-06-22 11:48:12.000000000 -0500
+++ new/src/sim/ppc/psim.c 2005-04-20 10:02:43.000000000 -0500
@@ -49,6 +49,7 @@
#include "bfd.h"
+#include "libiberty.h"
/* system structure, actual size of processor array determined at
^ permalink raw reply [flat|nested] 3+ messages in thread
* [COMMIT] psim.c file is missing a header file libiberty.h
2005-04-20 22:09 ` Mark Kettenis
@ 2005-04-20 22:34 ` Manoj Iyer
0 siblings, 0 replies; 3+ messages in thread
From: Manoj Iyer @ 2005-04-20 22:34 UTC (permalink / raw)
To: Mark Kettenis; +Cc: gdb-patches
Commited patch to add missing library to psim.c and also fixed change logs
to add a new line after the header.
Thanks
-----
manjo
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ Cogito ergo sum +
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
On Thu, 21 Apr 2005, Mark Kettenis wrote:
> Date: Wed, 20 Apr 2005 10:07:32 -0500 (CDT)
> From: Manoj Iyer <manjo@austin.ibm.com>
>
> The psim.c file is missing a header file libiberty.h, this causes the
> linker (AIX) to report an unresolved symbol namely ".alloca". cc -g -o
> psim main.o libsim.a ../../bfd/libbfd.a ../../libiberty/libiberty.a ld:
> 0711-317 ERROR: Undefined symbol: .alloca ld: 0711-345 Use the -bloadmap
> or -bnoquiet option to obtain more information.
>
> The patch below adds the headerfile to psim.c file. Please review and ok
> to commit.
>
> This is ok, but please make sure there's a blank line between the
> header and the actual content of the ChangeLog entry when you check it
> in.
>
> Mark
>
> ------------------------------------------------------------------------
>
> 2005-04-20 Manoj Iyer <manjo@austin.ibm.com>
> * psim.c: Added libiberty.h header file.
>
> --- src/sim/ppc/psim.c 2003-06-22 11:48:12.000000000 -0500
> +++ new/src/sim/ppc/psim.c 2005-04-20 10:02:43.000000000 -0500
> @@ -49,6 +49,7 @@
>
>
> #include "bfd.h"
> +#include "libiberty.h"
>
>
> /* system structure, actual size of processor array determined at
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-04-20 22:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-04-20 15:06 [RFC] psim.c file is missing a header file libiberty.h Manoj Iyer
2005-04-20 22:09 ` Mark Kettenis
2005-04-20 22:34 ` [COMMIT] " Manoj Iyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox