Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH] gdb.base/float.exp gdb.base/commands.exp
@ 2005-03-07 20:08 Manoj Iyer
  2005-03-07 20:10 ` Daniel Jacobowitz
  0 siblings, 1 reply; 2+ messages in thread
From: Manoj Iyer @ 2005-03-07 20:08 UTC (permalink / raw)
  To: gdb-patches



Here is a patch that fixes testcase problems with float.exp and
commands.exp that causes the tests to fail on PowerPC.


2005-03-07  Manoj Iyer  <manjo@austin.ibm.com>

        * commands.exp: Change hardcoded value to regular expression.
        * float.exp: Add powerpc to the list of targets checked.


--------- float.exp -------------------

diff -Naurp ./old/src/gdb/testsuite/gdb.base/float.exp ./new/src/gdb/testsuite/gdb.base/float.exp
--- ./old/src/gdb/testsuite/gdb.base/float.exp	2005-03-07 13:19:16.000000000 -0600
+++ ./new/src/gdb/testsuite/gdb.base/float.exp	2005-03-07 13:28:33.000000000 -0600
@@ -65,6 +65,8 @@ if { [istarget "alpha*-*-*"] } then {
     gdb_test "info float" "fp0.*fp1.*fp7.*" "info float"
 } elseif [istarget "mips*-*-*"] then {
     gdb_test "info float" "f0:.*flt:.*dbl:.*" "info float"
+} elseif [istarget "powerpc*-*-*"] then {
+    gdb_test "info float" "f0.*f1.*f31.*fpscr.*" "info float"
 } elseif [istarget "s390*-*-*"] then {
     gdb_test "info float" "fpc.*f0.*f1.*f15.*" "info float"
 } elseif [istarget "sh*-*"] then {
--------------------------------------

-------------- commands.exp ---------------
diff -Naurp ./old/src/gdb/testsuite/gdb.base/commands.exp ./new/src/gdb/testsuite/gdb.base/commands.exp
--- ./old/src/gdb/testsuite/gdb.base/commands.exp	2005-03-07 13:19:16.000000000 -0600
+++ ./new/src/gdb/testsuite/gdb.base/commands.exp	2005-03-07 13:21:49.000000000 -0600
@@ -331,7 +331,7 @@ proc watchpoint_command_test {} {
     }
     send_gdb "continue\n"
     gdb_expect {
-	-re "Continuing.*\[Ww\]atchpoint $wp_id deleted because the program has left the block in.*which its expression is valid.*run.c:57.*$gdb_prompt $" {
+	-re "Continuing.*\[Ww\]atchpoint $wp_id deleted because the program has left the block in.*which its expression is valid.*run.c:(57|82).*$gdb_prompt $" {
 	    pass "continue with watch"
 	}
 	-re "$gdb_prompt $"   {fail "continue with watch"}
-----------------------------------------------------------------

Cheers
-----
manjo
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ Cogito ergo sum                                                          +
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] gdb.base/float.exp gdb.base/commands.exp
  2005-03-07 20:08 [PATCH] gdb.base/float.exp gdb.base/commands.exp Manoj Iyer
@ 2005-03-07 20:10 ` Daniel Jacobowitz
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Jacobowitz @ 2005-03-07 20:10 UTC (permalink / raw)
  To: Manoj Iyer; +Cc: gdb-patches

On Mon, Mar 07, 2005 at 01:52:47PM -0600, Manoj Iyer wrote:
> 
> 
> Here is a patch that fixes testcase problems with float.exp and
> commands.exp that causes the tests to fail on PowerPC.
> 
> 
> 2005-03-07  Manoj Iyer  <manjo@austin.ibm.com>
> 
>         * commands.exp: Change hardcoded value to regular expression.
>         * float.exp: Add powerpc to the list of targets checked.

This patch is OK.

The changelog should say gdb.base/commands.exp and gdb.base/float.exp,
and go in testsuite/ChangeLog.


-- 
Daniel Jacobowitz
CodeSourcery, LLC


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-03-07 20:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-03-07 20:08 [PATCH] gdb.base/float.exp gdb.base/commands.exp Manoj Iyer
2005-03-07 20:10 ` Daniel Jacobowitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox