[RFC] gdb/testsuite/gdb.exp not taking environment variable.

[RFC] gdb/testsuite/gdb.exp not taking environment variable.

[Manoj Iyer]

hi,

gdb/testsuite/gdb.exp is not taking the environment variable
TOOL_EXECUTABLE, here is a simple fix that does that.

--- gdb_test1/src/gdb/testsuite/lib/gdb.exp     2004-06-14
10:29:30.000000000 -0500
+++ gdb_test/src/gdb/testsuite/lib/gdb.exp      2004-07-29
15:25:50.000000000 -0500
@@ -29,8 +29,8 @@

 global GDB

-if [info exists TOOL_EXECUTABLE] {
-    set GDB $TOOL_EXECUTABLE;
+if [info exists env(TOOL_EXECUTABLE)] {
+    set GDB $env(TOOL_EXECUTABLE);
 }
 if ![info exists GDB] {
     if ![is_remote host] {

Thanks
----- ----
Manoj Iyer
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ Cognito ergo sum                                                          +
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Re: [RFC] gdb/testsuite/gdb.exp not taking environment variable.

[Michael Chastain]

Hi Manoj,

TOOL_EXECUTABLE is not an environment variable.  It's a TCL variable
which is initalized by runtest.exp in dejagnu, set by the
"--tool_exec" flag.

So the test-runner would say:

  runtest --tool_exec /path/path/my_gdb ...

And not: "export TOOL_EXECUTABLE=/path/path/my_gdb ; make check".

You can do this at the 'make check' level with:

  make check RUNTESTFLAGS="--tool_exec /path/path/my_gdb"

Or:

  export RUNTESTFLAGS="--tool_exec /path/path/my_gdb"
  make -e check

I don't want gdb/lib.exp to change the interface of an existing
variable name which is imported from runtest.exp.

Michael C

Re: [RFC] gdb/testsuite/gdb.exp not taking environment variable.

[Manoj Iyer]

Cool! I will use --tool_exec instead. Is this documented some place? for
my future reference?

Thanks
----- ----
Manoj Iyer
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ Cognito ergo sum                                                          +
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

On Thu, 29 Jul 2004, Michael Chastain wrote:

> Hi Manoj,
>
> TOOL_EXECUTABLE is not an environment variable.  It's a TCL variable
> which is initalized by runtest.exp in dejagnu, set by the
> "--tool_exec" flag.
>
> So the test-runner would say:
>
>   runtest --tool_exec /path/path/my_gdb ...
>
> And not: "export TOOL_EXECUTABLE=/path/path/my_gdb ; make check".
>
> You can do this at the 'make check' level with:
>
>   make check RUNTESTFLAGS="--tool_exec /path/path/my_gdb"
>
> Or:
>
>   export RUNTESTFLAGS="--tool_exec /path/path/my_gdb"
>   make -e check
>
> I don't want gdb/lib.exp to change the interface of an existing
> variable name which is imported from runtest.exp.
>
> Michael C
>

Re: [RFC] gdb/testsuite/gdb.exp not taking environment variable.

[Michael Chastain]

Manoj Iyer <manjo@austin.ibm.com> wrote:
> Cool! I will use --tool_exec instead. Is this documented some place? for
> my future reference?

With dejagnu 1.4.4, it's not documented in 'man runtest', but it is
listed in 'runtest --help', and mentioned in doc/overview.ps and
doc/user.sgml in the dejagnu 1.4.4 doc/ subtree.

Also, by the way, dejagnu thinks that it is testing one tool at a time.
It doesn't understand that gdb needs to specify several other tools
as well (versions of gcc and binutils).  There is some confusion about
this in lib/java.exp where java_init uses TOOL_EXECUTABLE to initialize
GCJ_UNDER_TEST.  I need to fix that.  Until then, if you set
TOOL_EXECUTABLE, I think the Java tests will screw up.

Michael C