Re: gdb-5.3 -- some minor build problems + 3 patches

Re: gdb-5.3 -- some minor build problems + 3 patches

[Peter Breitenlohner]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 756 bytes --]

On Wed, 22 Jan 2003, Michael Elizabeth Chastain wrote:

> If you can, please start with the current cvs version rather than gdb 5.3.
> See http://sources.redhat.com/gdb/current/ for instructions.  You can work
> from either a current weekly snapshot or do a cvs checkout.
>
> Please send patches to the mailing list 'gdb-patches@sources.redhat.com',
> one patch per e-mail.  Many more developers read gdb-patches than
> bug-gdb@gnu.org.

Hi Michael,

can do, attached the first patch against gdb+dejagnu-weekly-CVS-20030121:

	gdbreplay.c uses `#ifdef HAVE_STDLIB_H', but configure and config.h
	don't define this. Consequently <stdlib.h> was not included,
	resulting in an "implicit declaration 	of `atoi'" warning.

Peter Breitenlohner <peb@mppmu.mpg.de>

[-- Attachment #2: Type: TEXT/PLAIN, Size: 2183 bytes --]

	gdbreplay.c uses `#ifdef HAVE_STDLIB_H', but configure and config.h
	don't define this. Consequently <stdlib.h> was not included,
	resulting in an "implicit declaration of `atoi'" warning.

diff -ur gdb+dejagnu-weekly-CVS-20030121.orig/src/gdb/gdbserver/config.in gdb+dejagnu-weekly-CVS-20030121/src/gdb/gdbserver/config.in
--- gdb+dejagnu-weekly-CVS-20030121.orig/src/gdb/gdbserver/config.in	2002-07-24 23:30:46.000000000 +0200
+++ gdb+dejagnu-weekly-CVS-20030121/src/gdb/gdbserver/config.in	2003-01-22 19:03:52.000000000 +0100
@@ -25,6 +25,9 @@
 /* Define if you have the <sgtty.h> header file.  */
 #undef HAVE_SGTTY_H
 
+/* Define if you have the <stdlib.h> header file.  */
+#undef HAVE_STDLIB_H
+
 /* Define if you have the <string.h> header file.  */
 #undef HAVE_STRING_H
 
diff -ur gdb+dejagnu-weekly-CVS-20030121.orig/src/gdb/gdbserver/configure gdb+dejagnu-weekly-CVS-20030121/src/gdb/gdbserver/configure
--- gdb+dejagnu-weekly-CVS-20030121.orig/src/gdb/gdbserver/configure	2002-07-24 23:30:46.000000000 +0200
+++ gdb+dejagnu-weekly-CVS-20030121/src/gdb/gdbserver/configure	2003-01-22 19:03:59.000000000 +0100
@@ -1105,7 +1105,7 @@
 fi
 
 
-for ac_hdr in sgtty.h termio.h termios.h sys/reg.h string.h 		 proc_service.h sys/procfs.h thread_db.h linux/elf.h unistd.h
+for ac_hdr in sgtty.h termio.h termios.h sys/reg.h stdlib.h string.h 		 proc_service.h sys/procfs.h thread_db.h linux/elf.h unistd.h
 do
 ac_safe=`echo "$ac_hdr" | sed 'y%./+-%__p_%'`
 echo $ac_n "checking for $ac_hdr""... $ac_c" 1>&6
diff -ur gdb+dejagnu-weekly-CVS-20030121.orig/src/gdb/gdbserver/configure.in gdb+dejagnu-weekly-CVS-20030121/src/gdb/gdbserver/configure.in
--- gdb+dejagnu-weekly-CVS-20030121.orig/src/gdb/gdbserver/configure.in	2002-07-24 23:30:46.000000000 +0200
+++ gdb+dejagnu-weekly-CVS-20030121/src/gdb/gdbserver/configure.in	2003-01-22 19:03:35.000000000 +0100
@@ -30,7 +30,7 @@
 
 AC_HEADER_STDC
 
-AC_CHECK_HEADERS(sgtty.h termio.h termios.h sys/reg.h string.h dnl
+AC_CHECK_HEADERS(sgtty.h termio.h termios.h sys/reg.h stdlib.h string.h dnl
 		 proc_service.h sys/procfs.h thread_db.h linux/elf.h unistd.h)
 
 . ${srcdir}/configure.srv

Re: gdb-5.3 -- some minor build problems + 3 patches

[Peter Breitenlohner]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 454 bytes --]

and here the second patch:

	LDFLAGS were not propagated from gdb to gdb/gdbserver.
	Consequently "make LDFLAGS=-s" did produced unstripped gdbreplay and
	gdbserver binaries.

	All this wouldn't be needed, if the gdb distribution were to support
	"make install-strip" as most modern packages do. Unfortunately this
	feature has not (yet?) found its way into the cygnus type source
	trees (nor has DESTDIR support).

Peter Breitenlohner <peb@mppmu.mpg.de>

[-- Attachment #2: Type: TEXT/PLAIN, Size: 906 bytes --]

	LDFLAGS were not propagated from gdb to gdb/gdbserver.
	Consequently "make LDFLAGS=-s" did produced unstripped gdbreplay and
	gdbserver binaries.

	All this wouldn't be needed, if the gdb distribution were to support
	"make install-strip" as most modern packages do. Unfortunately this
	feature has not (yet?) found its way into the cygnus type source
	trees (nor has DESTDIR support).

diff -ur gdb+dejagnu-weekly-CVS-20030121.orig/src/gdb/Makefile.in gdb+dejagnu-weekly-CVS-20030121/src/gdb/Makefile.in
--- gdb+dejagnu-weekly-CVS-20030121.orig/src/gdb/Makefile.in	2003-01-18 18:25:22.000000000 +0100
+++ gdb+dejagnu-weekly-CVS-20030121/src/gdb/Makefile.in	2003-01-22 19:04:56.000000000 +0100
@@ -431,6 +431,7 @@
 	"CXX=$(CXX)" \
 	"CXXFLAGS=$(CXXFLAGS)" \
 	"DLLTOOL=$(DLLTOOL)" \
+	"LDFLAGS=$(LDFLAGS)" \
 	"RANLIB=$(RANLIB)" \
 	"MAKEINFO=$(MAKEINFO)" \
 	"MAKEHTML=$(MAKEHTML)" \