Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Theodore A. Roth" <troth@openavr.org>
To: gdb-patches@sources.redhat.com
Subject: [RFC:avr] use regcache instead of read_register
Date: Fri, 20 Jun 2003 06:22:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.44.0306192310130.3963-200000@bozoland.mynet> (raw)

[-- Attachment #1: Type: TEXT/PLAIN, Size: 487 bytes --]

Hi,

The ARI caught this and it seems like a trivial change. There is a bit of 
confusion though in the use of current_regcache since the ARI says this:

  current regcache 57 Replace current_regcache with explict parameter

What would that explicit parameter be?

If this patch is ok, it brings the ARI count for the AVR down to 0.

Ted Roth

2003-06-19  Theodore A. Roth  <troth@openavr.org>

	* avr-tdep.c (avr_read_pc): Use regcache instead of read_register.
	(avr_read_sp): Ditto.


[-- Attachment #2: Type: TEXT/PLAIN, Size: 1094 bytes --]

2003-06-19  Theodore A. Roth  <troth@openavr.org>

	* avr-tdep.c (avr_read_pc): Use regcache instead of read_register.
	(avr_read_sp): Ditto.

Index: avr-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/avr-tdep.c,v
retrieving revision 1.64
diff -u -r1.64 avr-tdep.c
--- avr-tdep.c	20 Jun 2003 05:53:42 -0000	1.64
+++ avr-tdep.c	20 Jun 2003 06:09:27 -0000
@@ -324,12 +324,12 @@
 avr_read_pc (ptid_t ptid)
 {
   ptid_t save_ptid;
-  CORE_ADDR pc;
+  ULONGEST pc;
   CORE_ADDR retval;
 
   save_ptid = inferior_ptid;
   inferior_ptid = ptid;
-  pc = (int) read_register (AVR_PC_REGNUM);
+  regcache_cooked_read_unsigned (current_regcache, AVR_PC_REGNUM, &pc);
   inferior_ptid = save_ptid;
   retval = avr_make_iaddr (pc);
   return retval;
@@ -349,7 +349,10 @@
 static CORE_ADDR
 avr_read_sp (void)
 {
-  return (avr_make_saddr (read_register (AVR_SP_REGNUM)));
+  ULONGEST sp;
+
+  regcache_cooked_read_unsigned (current_regcache, AVR_SP_REGNUM, &sp);
+  return (avr_make_saddr (sp));
 }
 
 static int

             reply	other threads:[~2003-06-20  6:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-20  6:22 Theodore A. Roth [this message]
2003-06-20 14:19 ` Andrew Cagney
2003-06-20 17:09   ` Theodore A. Roth
2003-06-20 17:39     ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44.0306192310130.3963-200000@bozoland.mynet \
    --to=troth@openavr.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox