Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] stack.c: Always set current_source_{symtab,line}
Date: Thu, 22 Aug 2002 11:09:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.44.0208221104590.1410-100000@valrhona.uglyboxes.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0208141621210.1407-100000@valrhona.uglyboxes.com>

Ping.

On Wed, 14 Aug 2002, Keith Seitz wrote:

> Hi,
> 
> Another MI fallout. This has changed a few times in the past few months, 
> but I believe that this is how it should be for anything that uses the 
> CLI/command interpreter.
> 
> Without this, an -interpreter-exec call in MI will get "lost". (Use MI to 
> stop at breakpoint, step a few times, use console interp to "break" -- 
> breakpoint would be set someplace other than current location.)
> 
> I've run this through the testsuite, and it introduces no new failures. 
> (And of course, it still works with Insight.)
> 
> Keith
> 
> ChangeLog
> 2002-08-14  Keith Seitz  <keiths@redhat.com>
> 
>         * stack.c (print_frame_info_base): Always set current_source_symtab
>         and current_source_line.
> 
> Patch
> Index: stack.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/stack.c,v
> retrieving revision 1.40
> diff -p -r1.40 stack.c
> *** stack.c	11 Jul 2002 19:29:08 -0000	1.40
> --- stack.c	14 Aug 2002 23:17:59 -0000
> *************** print_frame_info_base (struct frame_info
> *** 398,403 ****
> --- 398,408 ----
>       print_frame (fi, level, source, args, sal);
>   
>     source_print = (source == SRC_LINE || source == SRC_AND_LOC);
> +   if (sal.symtab != NULL)
> +     {
> +       current_source_symtab = sal.symtab;
> +       current_source_line = sal.line;
> +     }
>   
>     if (source_print && sal.symtab)
>       {
> *************** print_frame_info_base (struct frame_info
> *** 410,419 ****
>         if (!done)
>   	{
>   	  if (print_frame_info_listing_hook)
> ! 	    {
> ! 	      print_frame_info_listing_hook (sal.symtab, sal.line, sal.line + 1, 0);
> ! 	      current_source_symtab = sal.symtab;
> ! 	    }
>   	  else
>   	    {
>   	      /* We used to do this earlier, but that is clearly
> --- 415,421 ----
>         if (!done)
>   	{
>   	  if (print_frame_info_listing_hook)
> ! 	    print_frame_info_listing_hook (sal.symtab, sal.line, sal.line + 1, 0);
>   	  else
>   	    {
>   	      /* We used to do this earlier, but that is clearly
> 
> 
> 
> 


  reply	other threads:[~2002-08-22 18:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-14 16:25 Keith Seitz
2002-08-22 11:09 ` Keith Seitz [this message]
2002-08-26 15:57   ` Kevin Buettner
2002-08-29  8:07 ` Elena Zannoni
2002-08-29  9:10   ` Keith Seitz
2002-08-29 12:32     ` Elena Zannoni
2002-08-29 12:43       ` Keith Seitz
2002-08-29 12:54         ` Elena Zannoni
2002-08-29 13:16           ` Keith Seitz
2002-08-29 20:28     ` Elena Zannoni
2002-08-30 11:12       ` Keith Seitz
2002-08-30 12:44         ` Andrew Cagney
2002-08-30 12:57           ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44.0208221104590.1410-100000@valrhona.uglyboxes.com \
    --to=keiths@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox