Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@ges.redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sources.redhat.com, Elena Zannoni <ezannoni@redhat.com>
Subject: Re: [RFA] stack.c: Always set current_source_{symtab,line}
Date: Fri, 30 Aug 2002 12:44:00 -0000	[thread overview]
Message-ID: <3D6FCA0F.8050407@ges.redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0208301019550.1395-100000@valrhona.uglyboxes.com>

> On Thu, 29 Aug 2002, Elena Zannoni wrote:
> 
> 
>> Another  thought: could a testcase be added, just like the one below?
> 
> 
> Already in mi-cli.exp on the branch. (I think I submitted it, too, to this 
> list.) The method is different, but it demonstrates the failure using 
> "list" with the console interpreter.

For MI, the testcase needs to go in at the same time as the fix (this is 
stronger then the rest of GDB where it is a ``should'').  It's also 
important to check that the test actually fails without the fix.  That 
way we know that the change at least fixed something :-)

enjoy,
Andrew



  reply	other threads:[~2002-08-30 19:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-14 16:25 Keith Seitz
2002-08-22 11:09 ` Keith Seitz
2002-08-26 15:57   ` Kevin Buettner
2002-08-29  8:07 ` Elena Zannoni
2002-08-29  9:10   ` Keith Seitz
2002-08-29 12:32     ` Elena Zannoni
2002-08-29 12:43       ` Keith Seitz
2002-08-29 12:54         ` Elena Zannoni
2002-08-29 13:16           ` Keith Seitz
2002-08-29 20:28     ` Elena Zannoni
2002-08-30 11:12       ` Keith Seitz
2002-08-30 12:44         ` Andrew Cagney [this message]
2002-08-30 12:57           ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D6FCA0F.8050407@ges.redhat.com \
    --to=ac131313@ges.redhat.com \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox