From: Daniel Berlin <dberlin@dberlin.org>
To: Jim Blandy <jimb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: coding style tweaks
Date: Mon, 13 May 2002 17:31:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.44.0205132029510.16238-100000@dberlin.org> (raw)
In-Reply-To: <20020514000203.B09085EA11@zwingli.cygnus.com>
> }
>
> /* It's not us. Try all our children, and return the lowest. */
> {
> struct macro_source_file *child;
> ! struct macro_source_file *best = NULL;
> ! int best_depth = 0;
>
> for (child = source->includes; child; child = child->next_included)
> {
This has to be wrong.
If you initialize best_depth to be 0, unless result_depth is somehow < 0,
it'll never be the new best.
--Dan
next prev parent reply other threads:[~2002-05-14 0:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-13 17:02 Jim Blandy
2002-05-13 17:31 ` Daniel Berlin [this message]
2002-05-13 18:20 ` Andrew Cagney
2002-05-13 18:28 ` Daniel Berlin
2002-05-13 19:16 ` Andrew Cagney
2002-05-14 14:31 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0205132029510.16238-100000@dberlin.org \
--to=dberlin@dberlin.org \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox