From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-15467-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 30012 invoked by alias); 14 May 2002 00:31:05 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 30005 invoked from network); 14 May 2002 00:31:03 -0000
Received: from unknown (HELO www.dberlin.org) (151.203.29.129)
  by sources.redhat.com with SMTP; 14 May 2002 00:31:03 -0000
Received: from localhost (localhost.localdomain [127.0.0.1])
	by www.dberlin.org (Postfix) with ESMTP
	id D56404A4EA; Mon, 13 May 2002 20:31:02 -0400 (EDT)
Date: Mon, 13 May 2002 17:31:00 -0000
From: Daniel Berlin <dberlin@dberlin.org>
To: Jim Blandy <jimb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: coding style tweaks
In-Reply-To: <20020514000203.B09085EA11@zwingli.cygnus.com>
Message-ID: <Pine.LNX.4.44.0205132029510.16238-100000@dberlin.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SW-Source: 2002-05/txt/msg00515.txt.bz2

>     }
>   
>     /* It's not us.  Try all our children, and return the lowest.  */
>     {
>       struct macro_source_file *child;
> !     struct macro_source_file *best = NULL;
> !     int best_depth = 0;
>   
>       for (child = source->includes; child; child = child->next_included)
>         {

This has to be wrong.

If you initialize best_depth to be 0, unless result_depth is somehow < 0, 
it'll never be the new best.
--Dan