Re: [RFA] Fix for gdb-gnats bug #14

["John R. Moore" <jmoore@cygnus.com>]

On Fri, 16 Feb 2001, Michael Elizabeth Chastain wrote:

> I proofread this patch plus I tested on a Solaris 2.6 native with gcc
> 2.9-gnupro-99r1.  It works for me.
> 
> I recommend that the maintainers approve the patch as submitted.
> 
> But I have more comments ...
> 
> I note that the test has two branches: an hpux branch and a non-hpux
> branch.  This is strange, because the underlying feature is not
> target specific.
> 
> The hpux branch contains the correct expectatation: it expects the "step"
> commands not to run.  I checked this by reading the test carefully and
> also by examining test results:
> 
>   /tantor/build/gnupro-00r1/hppa1.1-hp-hpux10.20/tests/hppa1.1-hp-hpux10.20/010214/gdb/testsuite/gdb.log 
>   /tantor/build/gnupro-00r1/sparc-sun-solaris2.6/tests/sparc-sun-solaris2.6/010204/gdb/testsuite/gdb.log 
> 
> So:
> 
>   . gdb always behaves as documented in the manual
>   . the hpux version of the test is correct.
>     gdb behaves as documented, and the test PASSes.
>   . the non-hpux version of the test is incorrect.
>     gdb behaves as documented, but the test FAILs.
>   . your patch actually makes the non-hpux test the same as the hpux test
> 
> If you care to do more work, you could remove the hpux test, kill the
> non-hpux expression completely, and use the hpux expression on all
> platforms.
> 
> It's up to the maintainers (Stan Shebs and Fernando Nasser) whether
> to accept the patch or remand it for more work.  I recommend accepting it
> and then doing more work as a second patch.
> 
> Michael Elizabeth Chastain

I (of course) noted the same and wondered why the hpux might be
different, but didn't give it a second thought, thinking that there
always could be an exception (and besides, I didn't have an hpux
to try it out on).

I see no big deal (do more work) to eliminate the hpux exception.
It might be that somebody somewhere fixed this once on an hpux,
but didn't bother to fix any other os?  The more work would simply
involve removing the "if hpux" block of script.

John