Re: [RFA] Fix for gdb-gnats bug #14

[Michael Elizabeth Chastain <chastain@cygnus.com>]

Hi John,

I'm having trouble applying this patch.  The original file has a lot
of TAB characters in it, but in your patch, they are expanded to spaces.
This makes the patch not apply, and it also makes the new code incorrect
(these TABs are literal characters in regular expressions).

Could you please check your source carefully to make sure that you have
the right characters in the new source lines 213-214:

  \ [ SPACE TAB \ ] *

Once the source file is correct, be careful with cut-and-paste, and
check your mailer.

Also the first line of the ChangeLog starts with eight spaces; please make
that a tab.  I wouldn't mention that except I am asking you to re-make
the patch anyways.

Michael

===

The fix was tested on Red Hat Linux 7.0 with 2.4 kernel.

2001-02-16  John Moore  <jmoore@redhat.com>

        * gdb.base/commands.exp (infrun_breakpoint_command_test):
	Removed non-expected items following a "step" command
	(see gnats bug report for gdb #14).

Index: gdb.base/commands.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/commands.exp,v
retrieving revision 1.6
diff -p -u -w -r1.6 commands.exp
--- commands.exp        2000/10/24 18:36:32     1.6
+++ commands.exp        2001/02/16 17:48:18
@@ -210,17 +210,8 @@ proc infrun_breakpoint_command_test {} {
        gdb_test "continue" \
                "Breakpoint \[0-9\]*, factorial \\(value=5\\).*at.*
 \[0-9\]*\[     \]*if \\(value > 1\\) \{.*
-\[0-9\]*\[     \]*value \\*= factorial \\(value - 1\\);.*
-factorial \\(value=4\\) at.*\[0-9\]*\[         \]*if \\(value > 1\\) \{.*
-\[0-9\]*\[     \]*value \\*= factorial \\(value - 1\\);.*
-factorial \\(value=3\\) at .*
-\[0-9\]*\[     \]*if \\(value > 1\\) \{.*
-#0  factorial \\(value=3\\).*
-#1  \[0-9a-fx\]* in factorial \\(value=4\\).*
-#2  \[0-9a-fx\]* in factorial \\(value=5\\).*
-#3  \[0-9a-fx\]* in factorial \\(value=6\\).*
-#4  \[0-9a-fx\]* in main \\(.*\\).*" \
-               "continue in infrun_breakpoint_command_test";
+\[0-9\]*\[     \]*value \\*= factorial \\(value - 1\\);.*" \
+               "continue in infrun_breakpoint_command_test"
     }

     gdb_stop_suppressing_tests;