Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Kaveh R. GHAZI" <ghazi@caip.rutgers.edu>
To: Nick Clifton <nickc@redhat.com>
Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org
Subject: Re: Add ATTRIBUTE_PACKED to ansidecl.h
Date: Wed, 06 Dec 2006 23:40:00 -0000	[thread overview]
Message-ID: <Pine.GSO.4.58.0612061837490.2248@caipclassic.rutgers.edu> (raw)
In-Reply-To: <m38xhk3nk9.fsf@redhat.com>

On Wed, 6 Dec 2006, Nick Clifton wrote:

> +/* Useful for structures whoes layout must much some binary specification
> +   regardless of the alignment and padding qualities of the compiler.  */
> +#ifndef ATTRIBUTE_PACKED
> +# define ATTRIBUTE_PACKED __attribute__ ((packed))
> +#endif

Please consider using "__packed__" not "packed".  All the other ATTRIBUTE
macros use underscores to avoid conflicts with user-space macros.

		Thanks,
		--Kaveh
--
Kaveh R. Ghazi			ghazi@caip.rutgers.edu


      parent reply	other threads:[~2006-12-06 23:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-06 18:08 Nick Clifton
2006-12-06 18:47 ` Ian Lance Taylor
2006-12-06 23:40 ` Kaveh R. GHAZI [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.GSO.4.58.0612061837490.2248@caipclassic.rutgers.edu \
    --to=ghazi@caip.rutgers.edu \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox