From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12640 invoked by alias); 6 Dec 2006 23:40:50 -0000 Received: (qmail 12632 invoked by uid 22791); 6 Dec 2006 23:40:49 -0000 X-Spam-Check-By: sourceware.org Received: from caip.rutgers.edu (HELO caip.rutgers.edu) (128.6.236.16) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 06 Dec 2006 23:40:44 +0000 Received: from caipclassic.rutgers.edu (caipclassic.rutgers.edu [128.6.237.54]) by caip.rutgers.edu (8.13.5/8.13.5) with ESMTP id kB6NeV3I029590 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 6 Dec 2006 18:40:31 -0500 Date: Wed, 06 Dec 2006 23:40:00 -0000 From: "Kaveh R. GHAZI" To: Nick Clifton cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org Subject: Re: Add ATTRIBUTE_PACKED to ansidecl.h In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00087.txt.bz2 On Wed, 6 Dec 2006, Nick Clifton wrote: > +/* Useful for structures whoes layout must much some binary specification > + regardless of the alignment and padding qualities of the compiler. */ > +#ifndef ATTRIBUTE_PACKED > +# define ATTRIBUTE_PACKED __attribute__ ((packed)) > +#endif Please consider using "__packed__" not "packed". All the other ATTRIBUTE macros use underscores to avoid conflicts with user-space macros. Thanks, --Kaveh -- Kaveh R. Ghazi ghazi@caip.rutgers.edu