* [RFA] Don't ignore UI_OUT for print_insn
@ 2001-08-21 11:38 Keith Seitz
2001-08-21 12:22 ` Andrew Cagney
2001-08-21 12:25 ` Keith Seitz
0 siblings, 2 replies; 4+ messages in thread
From: Keith Seitz @ 2001-08-21 11:38 UTC (permalink / raw)
To: gdb-patches
Hi,
This small patch will honor the given UI_OUT for print_insn, which is
currently ignored.
Ok?
Keith
ChangeLog
2001-08-21 Keith Seitz <keiths@redhat.com>
* printcmd.c (print_insn): Use the given stream for
output.
Patch
Index: printcmd.c
===================================================================
RCS file: /cvs/src/src/gdb/printcmd.c,v
retrieving revision 1.25
diff -u -p -r1.25 printcmd.c
--- printcmd.c 2001/08/02 11:58:29 1.25
+++ printcmd.c 2001/08/21 18:37:02
@@ -2441,6 +2441,8 @@ print_insn (CORE_ADDR memaddr, struct ui
TARGET_PRINT_INSN_INFO->mach = TARGET_ARCHITECTURE->mach;
/* else: should set .mach=0 but some disassemblers don't grok this */
+ TARGET_PRINT_INSN_INFO->stream = stream;
+
return TARGET_PRINT_INSN (memaddr, TARGET_PRINT_INSN_INFO);
}
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [RFA] Don't ignore UI_OUT for print_insn
2001-08-21 11:38 [RFA] Don't ignore UI_OUT for print_insn Keith Seitz
@ 2001-08-21 12:22 ` Andrew Cagney
2001-08-21 12:25 ` Keith Seitz
1 sibling, 0 replies; 4+ messages in thread
From: Andrew Cagney @ 2001-08-21 12:22 UTC (permalink / raw)
To: Keith Seitz; +Cc: gdb-patches
> Hi,
>
> This small patch will honor the given UI_OUT for print_insn, which is
> currently ignored.
>
> Ok?
> Keith
>
> ChangeLog
> 2001-08-21 Keith Seitz <keiths@redhat.com>
>
> * printcmd.c (print_insn): Use the given stream for
> output.
Given GDB is moving to adding explict ui_out/ui_file parameters,
honoring the ones that are already there I think is pretty obvious.
Yes.
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFA] Don't ignore UI_OUT for print_insn
2001-08-21 11:38 [RFA] Don't ignore UI_OUT for print_insn Keith Seitz
2001-08-21 12:22 ` Andrew Cagney
@ 2001-08-21 12:25 ` Keith Seitz
2001-09-18 8:01 ` [PATCH/5.1] (was Re: [RFA] Don't ignore UI_OUT for print_insn) Keith Seitz
1 sibling, 1 reply; 4+ messages in thread
From: Keith Seitz @ 2001-08-21 12:25 UTC (permalink / raw)
To: gdb-patches
On Tue, 21 Aug 2001, Andrew Cagney wrote:
> Given GDB is moving to adding explict ui_out/ui_file parameters,
> honoring the ones that are already there I think is pretty obvious.
>
> Yes.
Done. Thanks.
Keith
On Tue, 21 Aug 2001, Keith Seitz wrote:
> ChangeLog
> 2001-08-21 Keith Seitz <keiths@redhat.com>
>
> * printcmd.c (print_insn): Use the given stream for
> output.
>
> Patch
> Index: printcmd.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/printcmd.c,v
> retrieving revision 1.25
> diff -u -p -r1.25 printcmd.c
> --- printcmd.c 2001/08/02 11:58:29 1.25
> +++ printcmd.c 2001/08/21 18:37:02
> @@ -2441,6 +2441,8 @@ print_insn (CORE_ADDR memaddr, struct ui
> TARGET_PRINT_INSN_INFO->mach = TARGET_ARCHITECTURE->mach;
> /* else: should set .mach=0 but some disassemblers don't grok this */
>
> + TARGET_PRINT_INSN_INFO->stream = stream;
> +
> return TARGET_PRINT_INSN (memaddr, TARGET_PRINT_INSN_INFO);
> }
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH/5.1] (was Re: [RFA] Don't ignore UI_OUT for print_insn)
2001-08-21 12:25 ` Keith Seitz
@ 2001-09-18 8:01 ` Keith Seitz
0 siblings, 0 replies; 4+ messages in thread
From: Keith Seitz @ 2001-09-18 8:01 UTC (permalink / raw)
To: gdb-patches
FYI, I've committed this to the 5.1 branch.
Keith
On Tue, 21 Aug 2001, Keith Seitz wrote:
> On Tue, 21 Aug 2001, Andrew Cagney wrote:
>
> > Given GDB is moving to adding explict ui_out/ui_file parameters,
> > honoring the ones that are already there I think is pretty obvious.
> >
> > Yes.
>
> Done. Thanks.
> Keith
>
> On Tue, 21 Aug 2001, Keith Seitz wrote:
>
> > ChangeLog
> > 2001-08-21 Keith Seitz <keiths@redhat.com>
> >
> > * printcmd.c (print_insn): Use the given stream for
> > output.
> >
> > Patch
> > Index: printcmd.c
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/printcmd.c,v
> > retrieving revision 1.25
> > diff -u -p -r1.25 printcmd.c
> > --- printcmd.c 2001/08/02 11:58:29 1.25
> > +++ printcmd.c 2001/08/21 18:37:02
> > @@ -2441,6 +2441,8 @@ print_insn (CORE_ADDR memaddr, struct ui
> > TARGET_PRINT_INSN_INFO->mach = TARGET_ARCHITECTURE->mach;
> > /* else: should set .mach=0 but some disassemblers don't grok this */
> >
> > + TARGET_PRINT_INSN_INFO->stream = stream;
> > +
> > return TARGET_PRINT_INSN (memaddr, TARGET_PRINT_INSN_INFO);
> > }
> >
> >
> >
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2001-09-18 8:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-08-21 11:38 [RFA] Don't ignore UI_OUT for print_insn Keith Seitz
2001-08-21 12:22 ` Andrew Cagney
2001-08-21 12:25 ` Keith Seitz
2001-09-18 8:01 ` [PATCH/5.1] (was Re: [RFA] Don't ignore UI_OUT for print_insn) Keith Seitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox