[RFA] Initialize new struct data

[RFA] Initialize new struct data

[Keith Seitz]

Hi,

I think this qualifies as obvious, but I'd rather be safe than sorry.

cli-out.c added a new data member to ui_out_data called "suppress_output".
This new member was left uninitialized in cli_out_new, suppressing all
command output.

Keith

ChangeLog
2001-06-21  Keith Seitz  <keiths@redhat.com>

	* cli-out.c (cli_out_new): Initialize new structure member
	"suppress_output".

Patch
Index: cli-out.c
===================================================================
RCS file: /cvs/src/src/gdb/cli-out.c,v
retrieving revision 1.10
diff -p -u -r1.10 cli-out.c
--- cli-out.c	2001/06/19 20:30:11	1.10
+++ cli-out.c	2001/06/21 17:03:54
@@ -363,6 +363,7 @@ cli_out_new (struct ui_file *stream)

   struct ui_out_data *data = XMALLOC (struct ui_out_data);
   data->stream = stream;
+  data->suppress_output = 0;
   return ui_out_new (&cli_ui_out_impl, data, flags);
 }

Re: [RFA] Initialize new struct data

[Keith Seitz]

On Thu, 21 Jun 2001, Keith Seitz wrote:

> I think this qualifies as obvious, but I'd rather be safe than sorry.

Ok, just talked to Andrew. This is as obvious as I thought. I've committed
this.

Keith
>
> ChangeLog
> 2001-06-21  Keith Seitz  <keiths@redhat.com>
>
> 	* cli-out.c (cli_out_new): Initialize new structure member
> 	"suppress_output".
>
> Patch
> Index: cli-out.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/cli-out.c,v
> retrieving revision 1.10
> diff -p -u -r1.10 cli-out.c
> --- cli-out.c	2001/06/19 20:30:11	1.10
> +++ cli-out.c	2001/06/21 17:03:54
> @@ -363,6 +363,7 @@ cli_out_new (struct ui_file *stream)
>
>    struct ui_out_data *data = XMALLOC (struct ui_out_data);
>    data->stream = stream;
> +  data->suppress_output = 0;
>    return ui_out_new (&cli_ui_out_impl, data, flags);
>  }
>
>
>

Re: [RFA] Initialize new struct data

[Andrew Cagney]

> I think this qualifies as obvious, but I'd rather be safe than sorry.


Yes and thanks.  I must have been picking up unused memory out of the heap.

	Andrew