Re: [PATCH v2] gdb: AC_INIT should be called with package and version arguments

[Enze Li via Gdb-patches <gdb-patches@sourceware.org>]

Hi Andreas,

Thanks for the review.

I thought I'd do some explaining.

The version info that will be generated by this patch and the version
info generated in gdb/version.c are both from the version.in file. The
difference is that the patch is generated before compilation, while the
version info generated in the version.c file is generated during the
compilation process. Note that the version.c file is dynamically
generated by the create-version.sh script.

This is my understanding. I'm not sure I've articulated that clearly.

If there is a demand, I think we can modify it a bit more, we can use
the macros in the config.h header file automatically generated by this
patch and embed them directly into the c code.

It's just a thought.

If I'm going in the wrong direction, please feel free to point it out.
I would be happy to ask for your advice.

Thanks,
Enze

On Tue, 2021-11-23 at 16:06 +0100, Andreas Schwab wrote:
> 
> That should produce the same version as written in gdb/version.c.
> 
> Andreas.
>