From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id khesDO23n2F3CwAAWB0awg (envelope-from ) for ; Thu, 25 Nov 2021 11:21:01 -0500 Received: by simark.ca (Postfix, from userid 112) id 1EFE91F0CE; Thu, 25 Nov 2021 11:21:01 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_REPLYTO_END_DIGIT,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7BA1F1EDEE for ; Thu, 25 Nov 2021 11:21:00 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B1CBE3858D3C for ; Thu, 25 Nov 2021 16:20:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B1CBE3858D3C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637857259; bh=PqPOAyo8rQVC4SWbiKOqJ43CNlEYtxNg5XN+8LAUOPM=; h=Subject:To:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=KdEipvt2gJ6OJziHsQBKDvo0hbSclQ/SyCIH0Pb10c26y77kJTPIrQfjd3Z7+UIV+ W0llt6CNRgwGpY1PQgh97d/UqfhSCn1UBbtFNGB22CXkw62lDEXaP1oz8Q4k1//6k7 27O/TNp9atPSKXgKInTgRPGC2gG3u09y2VCpf6Yo= Received: from AUS01-ME3-obe.outbound.protection.outlook.com (mail-me3aus01olkn2156.outbound.protection.outlook.com [40.92.63.156]) by sourceware.org (Postfix) with ESMTPS id 371703858D35 for ; Thu, 25 Nov 2021 16:20:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 371703858D35 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D0ja9cqQmfeKiWIsX0rzhFpzkJfY3prngIFt/ubyIs+sMktiIncDhdkWGwp1N/zXzRU0ooZdftHXu1zQJoccNAYIm38WrtUlqO7FaN8HTJYpO0gGdaVh5wqlRA/aMEAl+F4q8D+gGTAAYOJpNEXGmfaLzh4UHRiMVhVzzogQ2a/9ELyMYrfHsj5ionTBEQZzDGqXqG6YTI8+ry5A97RKCyHl6GiTScKHOUlG+KB46ZYB0vfuYl/ncqhiOWaO6Ru4VV6SeyOsI1S6IyVm6Qv9IojlFLyiCAEtN9vCFW9HNxLYz9zhh+0/rRfvwReR+85Sv3qy5jSNcKt1pYZyiRipNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PqPOAyo8rQVC4SWbiKOqJ43CNlEYtxNg5XN+8LAUOPM=; b=mj+CNjozpqY3u2/yHL5I/HVhmxj62f6QMiqFmSszZSiEjbV/3FEEBEJ2Pcz+6tsxvHliljS4Xog/RTAc2kPPWcQ8ZAD5WsjbET2IvRL2WezKF/g3lQf7f6CXLhSD+u89UyRVPhAeVAPVlBuVmxotdg/opWzUMmU2G3v1F8RFlbU4QF2iJmnsvvMK3CN+J1lD39PIYdQViW42gC50YnvPwnTiDCGNM81ACSGm3TJ4Up/BNmcpzhVDwMcq1IBgcIKCr4RTriIQCDZjsoXDw1QGiBp5FYJZix5yIdMa6Yry/6Ot39LPI93BwfMT/r7kjbYWEuEGFnZhAY6wRaw5KqHofA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:71::10) by MEYP282MB2053.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:bd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.21; Thu, 25 Nov 2021 16:20:33 +0000 Received: from MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM ([fe80::b1d5:bf09:16b0:4b2c]) by MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM ([fe80::b1d5:bf09:16b0:4b2c%7]) with mapi id 15.20.4713.027; Thu, 25 Nov 2021 16:20:33 +0000 Message-ID: Subject: Re: [PATCH v2] gdb: AC_INIT should be called with package and version arguments To: Andreas Schwab , Enze Li via Gdb-patches Date: Fri, 26 Nov 2021 00:20:28 +0800 In-Reply-To: <87czmqgbdo.fsf@igel.home> References: <87czmqgbdo.fsf@igel.home> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 Content-Transfer-Encoding: 7bit X-TMN: [p8c4wDdbSR2O4ZmUUa9zfGVu+QNK9dY3] X-ClientProxiedBy: HK2PR02CA0193.apcprd02.prod.outlook.com (2603:1096:201:21::29) To MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:71::10) X-Microsoft-Original-Message-ID: <5acae693afb7cb5ff63f863c2e992542589650bb.camel@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.3.105] (61.48.211.155) by HK2PR02CA0193.apcprd02.prod.outlook.com (2603:1096:201:21::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.20 via Frontend Transport; Thu, 25 Nov 2021 16:20:32 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a3f81199-a1e3-4a2d-01ad-08d9b02f81b2 X-MS-TrafficTypeDiagnostic: MEYP282MB2053: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c8j6O9WdbV+rHjntwSYJ8KTJMJKL1yx/jQVljsI/TZ2t9IcZj/lH9Hv7f+zlkE9zx88AFp3upRL18DU2Fkc3i/1I1mbLuxt8xw7lFZPCz22TaKf8grDFiJtKrxoTkanFUVI430cbHeYHomtepAB0RZOTHUXKAQdQZIam6hlCbjdjzge8HQxRCdeNE8+2A9G2PVITkPYymQ0i49Xj2JEloECIZatr5HRcEq8NwNIJ/FgCP8LCUuFTZhQ6X37RF6wKGEQFwPim4iCHfH5vAUJq5SQGfHG0YUahLVUtVmRDd1mtvRXdqMJa/4uM4cuwB8/048ouER35novXm1bFBn2bpoTAbDo8iRzc/2O33TBHEfSR4pVjlZQtnWSL5A6nAZlP+fr3Y760w3OeUi0CWhXBBce44LDwr9Nl1jOx5QFVqb3AI6dsFX1q5xxxpVkt7Npi0A37P6H4JOLPnHwi2clK+Bwt+BC0f58DIDgMoK06669PlH/IfqGjER9iM1AarNvvB+7uCW//M/W29lhlylYA695Asf+D7ubLmwP5iIDDsApj4/xZdXv/DZ/OpmjmjzWj+Ciw9cHZ79jvgqitLURwfQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ww+YiUpFNbhQ9rNwVMdsrTbesa5f56kkNFvJkc6JWzFm98NAa9Xe/UA04/uDgQeVjvBOUHJB8tlRxobXYdwyzZ5YzGAxBc5MTFFovPfeql1fBb/Ja06yB4+3mNPEIme6iP67u9sSctf8G/iBfZa3mm905s9IM46xl78NIiyax/Ciw1Mep6S5/w1Db3+C7i6MOnM9WyWiEiwA/3X9pZIKNTEFVy5Gn7kp/6gsc4OyP0WbAEOqB6cvatF5zghR+ORtRx0XI/3Ui8oTpfwFFBmhWHZWZCqaWt7H0qJIIwYBs0Zpw0B+3P1Oz34Z7aXi72/yq6Rt/Ydz0oMQwZh14EToQ0wd9/fWzKtE93Sg6aVxmTBQlOWgKc6kuSPVT9EQNFKpVi4TxZA/dkutPrrTHZ8yKShnFDX8zmz42y1VDyNioRZ9TwSj+y7szL4/3a9GjMHIObesTqtyAW6lIbB5l9fClaHZYLewVBIyufIAGpWuUWcR7sIDBEvXDp78J1asYk+r5wiw/ez+uuGytYBj58wCJwd0h1Myey7RrEh9UA69fXpsOys8awlI2CivVllNaWCPAbIa5EfPHMA9ems9aGBhDQhmZzdS9cS3MSuX5uDiWgpAiqbWXhi1ivp/ETIMT/CfAwUc4whv4+USGITzMPdfiS6QgtiNi7nXN5FdTmjXyvry5amhmr7mMqLoF8bZgyyORk8MQnKqCcR0XqiSJ9VwSQ== X-OriginatorOrg: sct-15-20-3174-20-msonline-outlook-8dac2.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: a3f81199-a1e3-4a2d-01ad-08d9b02f81b2 X-MS-Exchange-CrossTenant-AuthSource: MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2021 16:20:33.8822 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MEYP282MB2053 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Enze Li via Gdb-patches Reply-To: Enze Li Cc: brobecker@adacore.com Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi Andreas, Thanks for the review. I thought I'd do some explaining. The version info that will be generated by this patch and the version info generated in gdb/version.c are both from the version.in file. The difference is that the patch is generated before compilation, while the version info generated in the version.c file is generated during the compilation process. Note that the version.c file is dynamically generated by the create-version.sh script. This is my understanding. I'm not sure I've articulated that clearly. If there is a demand, I think we can modify it a bit more, we can use the macros in the config.h header file automatically generated by this patch and embed them directly into the c code. It's just a thought. If I'm going in the wrong direction, please feel free to point it out. I would be happy to ask for your advice. Thanks, Enze On Tue, 2021-11-23 at 16:06 +0100, Andreas Schwab wrote: > > That should produce the same version as written in gdb/version.c. > > Andreas. >