From: Marc Khouzam <marc.khouzam@ericsson.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [MI] Wrong error message when parsing invalid --thread-group
Date: Wed, 08 Dec 2010 01:24:00 -0000 [thread overview]
Message-ID: <F7CE05678329534C957159168FA70DEC572E0C0DEF@EUSAACMS0703.eamcs.ericsson.se> (raw)
Hi,
with the fix of
http://sourceware.org/ml/gdb-patches/2010-12/msg00049.html
that added a missing else clause, another latent (mini) issue came out.
(gdb) interpreter-exec mi "28-break-insert --thread-group ix"
28^error,msg="Invalid value for the '--thread' option"
The error msg says "thread" instead of "thread-group".
Here is a fix.
Ok for HEAD and 7_2? (this is not so important for 7_2)
Thanks
2010-12-07 Marc Khouzam <marc.khouzam@ericsson.com>
* mi/mi-parse.c (mi_parse): Wrong error message.
### Eclipse Workspace Patch 1.0
#P src
Index: gdb/mi/mi-parse.c
===================================================================
RCS file: /cvs/src/src/gdb/mi/mi-parse.c,v
retrieving revision 1.21.2.1
diff -u -r1.21.2.1 mi-parse.c
--- gdb/mi/mi-parse.c 6 Dec 2010 14:23:40 -0000 1.21.2.1
+++ gdb/mi/mi-parse.c 8 Dec 2010 01:09:37 -0000
@@ -338,7 +338,8 @@
if (*chp != '\0' && !isspace (*chp))
error (_("Invalid value for the '%s' option"),
- start[2] == 't' ? "--thread" : "--frame");
+ start[2] == 'f' ? "--frame" :
+ start[8] == '-' ? "--thread-group" : "--thread");
while (isspace (*chp))
chp++;
}
next reply other threads:[~2010-12-08 1:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 1:24 Marc Khouzam [this message]
2010-12-08 16:35 ` Tom Tromey
2010-12-08 16:53 ` Marc Khouzam
2010-12-09 19:22 ` Tom Tromey
2010-12-09 20:42 ` Marc Khouzam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F7CE05678329534C957159168FA70DEC572E0C0DEF@EUSAACMS0703.eamcs.ericsson.se \
--to=marc.khouzam@ericsson.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox