From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76839-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18705 invoked by alias); 8 Dec 2010 01:24:01 -0000
Received: (qmail 18689 invoked by uid 22791); 8 Dec 2010 01:24:01 -0000
X-SWARE-Spam-Status: No, hits=-1.5 required=5.0	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from imr3.ericy.com (HELO imr3.ericy.com) (198.24.6.13)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 08 Dec 2010 01:23:47 +0000
Received: from eusaamw0711.eamcs.ericsson.se ([147.117.20.178])	by imr3.ericy.com (8.13.8/8.13.8) with ESMTP id oB81NjsV010451	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL)	for <gdb-patches@sourceware.org>; Tue, 7 Dec 2010 19:23:45 -0600
Received: from EUSAACMS0703.eamcs.ericsson.se ([169.254.1.63]) by eusaamw0711.eamcs.ericsson.se ([147.117.20.178]) with mapi; Tue, 7 Dec 2010 20:23:45 -0500
From: Marc Khouzam <marc.khouzam@ericsson.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Date: Wed, 08 Dec 2010 01:24:00 -0000
Subject: [MI] Wrong error message when parsing invalid --thread-group
Message-ID: <F7CE05678329534C957159168FA70DEC572E0C0DEF@EUSAACMS0703.eamcs.ericsson.se>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-12/txt/msg00084.txt.bz2

Hi,

with the fix of
http://sourceware.org/ml/gdb-patches/2010-12/msg00049.html
that added a missing else clause, another latent (mini) issue came out.

(gdb) interpreter-exec mi "28-break-insert --thread-group ix"
28^error,msg=3D"Invalid value for the '--thread' option"

The error msg says "thread" instead of "thread-group".

Here is a fix.
Ok for HEAD and 7_2? (this is not so important for 7_2)

Thanks

2010-12-07  Marc Khouzam  <marc.khouzam@ericsson.com>

	* mi/mi-parse.c (mi_parse): Wrong error message.
=20=20=20=20=20=20=20=20
### Eclipse Workspace Patch 1.0
#P src
Index: gdb/mi/mi-parse.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/src/src/gdb/mi/mi-parse.c,v
retrieving revision 1.21.2.1
diff -u -r1.21.2.1 mi-parse.c
--- gdb/mi/mi-parse.c   6 Dec 2010 14:23:40 -0000       1.21.2.1
+++ gdb/mi/mi-parse.c   8 Dec 2010 01:09:37 -0000
@@ -338,7 +338,8 @@
=20
       if (*chp !=3D '\0' && !isspace (*chp))
        error (_("Invalid value for the '%s' option"),
-              start[2] =3D=3D 't' ? "--thread" : "--frame");
+              start[2] =3D=3D 'f' ? "--frame" :
+                start[8] =3D=3D '-' ? "--thread-group" : "--thread");
       while (isspace (*chp))
        chp++;
     }