From: "Abid, Hafiz" <Hafiz_Abid@mentor.com>
To: "Zhu, Hui" <Hui_Zhu@mentor.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH] Add CTF support to GDB [1/4] Add "-ctf" to tsave command
Date: Wed, 21 Nov 2012 06:47:00 -0000 [thread overview]
Message-ID: <EB3B29AD43CA924DA27099BC8519237696CB817C@EU-MBX-02.mgc.mentorg.com> (raw)
In-Reply-To: <50AC3217.6040608@mentor.com>
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Zhu, Hui
> Sent: Wednesday, November 21, 2012 1:45 AM
> To: gdb-patches@sourceware.org
> Subject: [PATCH] Add CTF support to GDB [1/4] Add "-ctf" to tsave
> command
>
> This patch is for the CTF write.
> It add "-ctf" to tsave command. With this option, tsave can save
> current trace frame to CTF file format.
>
> Thanks,
> Hui
>
> 2012-11-20 Hui Zhu <hui_zhu@mentor.com>
>
> * Makefile.in (REMOTE_OBS): Add ctf.o.
> (SFILES): Add ctf.c.
> (HFILES_NO_SRCDIR): Add ctf.h.
> * ctf.c, ctf.h: New files.
Some more comments in these file will help understand the code better. Most of the function don't have any comments in the start so it is difficult to follow.
>+ case TYPE_CODE_INT:
>+ /* XXX: didn't check !TYPE_NOSIGN (t->type) because char is
>+ signed in C. */
This statement is not completely true. I think it is left to implementation to decide the signed-ness of char.
>+ /* XXX: no sure about variable_length
>+ and need set is_variable_length if need. */
This comment is confusing.
>+ warning (_("\
>+Traceframe %d is dropped because try to get the value of \"%s\" got error: %s"),
>+ warning (_("\
>+Not save \"%s\" of tracepoint %d to ctf file because get its value fail: %s"),
Many error and warning messages need some improvement.
> * mi/mi-main.c (ctf.h): New include.
> (mi_cmd_trace_save): Add "-ctf".
> * tracepoint.c (ctf.h): New include.
> (collect_pseudocommand): Remove static.
> (trace_save_command): Add "-ctf".
> (_initialize_tracepoint): Ditto.
> * tracepoint.h (collect_pseudocommand): Add extern.
next prev parent reply other threads:[~2012-11-21 6:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 1:45 Hui Zhu
2012-11-21 6:47 ` Abid, Hafiz [this message]
2012-12-03 9:31 ` Hui Zhu
2012-11-29 20:06 ` Tom Tromey
2012-12-05 1:47 ` Hui Zhu
2012-12-05 18:21 ` Tom Tromey
2012-12-14 11:37 ` Hui Zhu
2012-12-18 14:27 ` Hui Zhu
2012-12-20 8:13 ` Hui Zhu
2013-01-03 21:36 ` Tom Tromey
2013-01-08 1:41 ` Hui Zhu
2013-01-14 5:19 ` Hui Zhu
2013-01-14 14:28 ` Abid, Hafiz
2013-01-18 1:17 ` Hui Zhu
2013-01-18 14:29 ` Hafiz Abid Qadeer
2013-01-23 13:33 ` Hui Zhu
2013-02-04 15:33 ` Abid, Hafiz
2013-02-04 22:52 ` Hui Zhu
2013-02-11 12:54 ` Hui Zhu
2013-02-19 7:06 ` Hui Zhu
2013-02-20 10:48 ` Abid, Hafiz
2013-01-18 15:19 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EB3B29AD43CA924DA27099BC8519237696CB817C@EU-MBX-02.mgc.mentorg.com \
--to=hafiz_abid@mentor.com \
--cc=Hui_Zhu@mentor.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox