From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6165 invoked by alias); 21 Nov 2012 06:47:47 -0000 Received: (qmail 6082 invoked by uid 22791); 21 Nov 2012 06:47:46 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Nov 2012 06:47:40 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1Tb45z-0002Cz-Lg from Hafiz_Abid@mentor.com for gdb-patches@sourceware.org; Tue, 20 Nov 2012 22:47:39 -0800 Received: from SVR-IES-FEM-05.mgc.mentorg.com ([137.202.0.112]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 20 Nov 2012 22:47:39 -0800 Received: from EU-MBX-02.mgc.mentorg.com ([169.254.3.224]) by SVR-IES-FEM-05.mgc.mentorg.com ([137.202.0.112]) with mapi id 14.01.0289.001; Wed, 21 Nov 2012 06:47:37 +0000 From: "Abid, Hafiz" To: "Zhu, Hui" , "gdb-patches@sourceware.org" Subject: RE: [PATCH] Add CTF support to GDB [1/4] Add "-ctf" to tsave command Date: Wed, 21 Nov 2012 06:47:00 -0000 Message-ID: References: <50AC3217.6040608@mentor.com> In-Reply-To: <50AC3217.6040608@mentor.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00561.txt.bz2 > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Zhu, Hui > Sent: Wednesday, November 21, 2012 1:45 AM > To: gdb-patches@sourceware.org > Subject: [PATCH] Add CTF support to GDB [1/4] Add "-ctf" to tsave > command >=20 > This patch is for the CTF write. > It add "-ctf" to tsave command. With this option, tsave can save > current trace frame to CTF file format. >=20 > Thanks, > Hui >=20 > 2012-11-20 Hui Zhu >=20 > * Makefile.in (REMOTE_OBS): Add ctf.o. > (SFILES): Add ctf.c. > (HFILES_NO_SRCDIR): Add ctf.h. > * ctf.c, ctf.h: New files. Some more comments in these file will help understand the code better. Most= of the function don't have any comments in the start so it is difficult to= follow. >+ case TYPE_CODE_INT: >+ /* XXX: didn't check !TYPE_NOSIGN (t->type) because char is >+ signed in C. */ This statement is not completely true. I think it is left to implementation= to decide the signed-ness of char. >+ /* XXX: no sure about variable_length >+ and need set is_variable_length if need. */ This comment is confusing.=20 >+ warning (_("\ >+Traceframe %d is dropped because try to get the value of \"%s\" got error= : %s"), >+ warning (_("\ >+Not save \"%s\" of tracepoint %d to ctf file because get its value fail: = %s"), Many error and warning messages need some improvement. > * mi/mi-main.c (ctf.h): New include. > (mi_cmd_trace_save): Add "-ctf". > * tracepoint.c (ctf.h): New include. > (collect_pseudocommand): Remove static. > (trace_save_command): Add "-ctf". > (_initialize_tracepoint): Ditto. > * tracepoint.h (collect_pseudocommand): Add extern.