RE: [PATCH] PR breakpoints/15697: Remove =breakpoint-modified when hitting dprintf

[Marc Khouzam <marc.khouzam@ericsson.com>]

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Marc Khouzam
> Sent: Tuesday, April 29, 2014 1:48 PM
> To: 'Pedro Alves'
> Cc: 'gdb-patches@sourceware.org'
> Subject: RE: [PATCH] PR breakpoints/15697: Remove =breakpoint-modified
> when hitting dprintf
> 
> > -----Original Message-----
> > From: Pedro Alves [mailto:palves@redhat.com]
> > Sent: Tuesday, April 29, 2014 1:01 PM
> > To: Marc Khouzam
> > Cc: gdb-patches@sourceware.org
> > Subject: Re: [PATCH] PR breakpoints/15697: Remove =breakpoint-modified
> > when hitting dprintf
> 
> [Bunch of very valid concerns]
> 
> > Related, I'm not sure we should filter the
> > observer_notify_breakpoint_modified call -- it would seem better if
> > observers are notified, and the its MI that filters out those
> > modifications that it isn't interested in.
> > E.g., could TUI be interested in still receiving the nofications?
> 
> Something to think about.  Simon made the same comment off-line.
> 
> > I don't have answers to the above, but I think these issues all need
> > to be considered, and whatever resolutions we end up with need to be
> > cast as comments in the code and manual.
> 
> Thanks Pedro, you are bringing up valid (and tricky :-)) points.  I'll look into
> them and see if I can come up with equally valid solutions.

To follow up on this.  After discussing with Pedro offline, he helped point-out
that the many =breakpoint-modified notifications were not actually causing
any problems to Eclipse.  The issue was actually in the corresponding extra
*running event.

Pedro has already followed-up on a fix for the *running event here (thanks!):
https://sourceware.org/ml/gdb-patches/2014-05/msg00273.html

And I'm dropping this patch, as it is not helpful.

Thanks

Marc